[GitHub] [drill] paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated list accessors

2020-03-24 Thread GitBox
paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated 
list accessors
URL: https://github.com/apache/drill/pull/2018#issuecomment-603434987
 
 
   @arina-ielchiieva, thanks for the suggestions, they solved the problem. I 
suspect we have some confusion with those methods based on earlier testing, but 
we'll fix those issues later.
   
   Squashed commits and reran all unit tests. We should be good to go. Thanks 
again for your help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [drill] paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated list accessors

2020-03-24 Thread GitBox
paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated 
list accessors
URL: https://github.com/apache/drill/pull/2018#issuecomment-603078801
 
 
   After rebasing I'm seeing a number of metastore test failures:
   ```
   [ERROR] Errors: 
   [ERROR]   TestTableMetadataUnitConversion.testBaseTableMetadata:145 » 
IllegalArgument Un...
   [ERROR]   TestTableMetadataUnitConversion.testFileMetadata:280 » 
IllegalArgument Unable ...
   [ERROR]   TestTableMetadataUnitConversion.testPartitionMetadata:383 » 
IllegalArgument Un...
   [ERROR]   TestTableMetadataUnitConversion.testRowGroupMetadata:332 » 
IllegalArgument Una...
   [ERROR]   TestTableMetadataUnitConversion.testSegmentMetadata:237 » 
IllegalArgument Unab...
   ```
   
   It is not immediately obvious what went wrong; I'll poke around tomorrow to 
see if I can find the cause.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [drill] paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated list accessors

2020-03-24 Thread GitBox
paul-rogers commented on issue #2018: DRILL-7633: Fixes for union and repeated 
list accessors
URL: https://github.com/apache/drill/pull/2018#issuecomment-603075717
 
 
   Squashed commits and rebased on the latest master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services