[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401548402 Thanks all, for the review! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401441469 Filed DRILL-6562 to track this. Regarding one vs multiple files, my reasoning was to keep it more human readable and flexible - giving options to selectively import any plugin as needed. So suggested a compressed folder with each of the plugin files. But your approach sounds good. I'm thinking the "Export All" option would be used for All or None scenarios. And the regular per plugin "Export" option being introduced in this PR can support the flexible per plugin import. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations
Agirish commented on issue #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#issuecomment-401424556 @arina-ielchiieva, I thought about that - but it's a bit more complicated in how i'd like it to be: An "Export All" button" should export each of the storage plugin configurations into JSON files and generate a single compressed folder which contains each of these JSON files individually. And an "Import" button which can support importing either a single JSON file or a compressed folder which can create one or more storage plugins. I think having individual export button is helpful. We could keep it in the "Update" page (image 2 above). We could remove it from the main storage plugin list page (image 1) if you think it's cluttering the UI. In a later PR, we can add support for the "Export All" and "Import" (one or more) buttons. Would that be okay? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
