[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-14 Thread HanumathRao
Github user HanumathRao commented on the issue:

https://github.com/apache/drill/pull/1110
  
@amansinha100  @vrozov  Thanks for the review. I have squashed all the 
commits into two commits.

Please merge these two commits individually into the apache master branch. 
First commit is for refactoring existing code. Second commit is about fixing 
this JIRA request.


---


[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-14 Thread vrozov
Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1110
  
LGTM, please squash two last commits.


---


[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-14 Thread amansinha100
Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/1110
  
LGTM.  +1


---


[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-13 Thread HanumathRao
Github user HanumathRao commented on the issue:

https://github.com/apache/drill/pull/1110
  
@amansinha100 @vrozov  Thank you for the review. I have addressed all the 
review comments. Please let me know if any changes are required.

The commits are organized such that one commit is for refactoring the 
existing code and the second one is specific to the changes required for this 
JIRA. This is done for ease of reviewing the code. 


---


[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-11 Thread amansinha100
Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/1110
  
@HanumathRao I have a few comments in the JIRA for the overall design; we 
can discuss. 


---


[GitHub] drill issue #1110: DRILL-6115: SingleMergeExchange is not scaling up when ma...

2018-02-11 Thread HanumathRao
Github user HanumathRao commented on the issue:

https://github.com/apache/drill/pull/1110
  
@vrozov  Thank you for reviewing the code. I have incorporated all the 
review comments. Please let me know if anything needs to be changed.


---