[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1182 Sorry, Maven not being a strong point, I didn't understand initially what I was looking at. +1 ---
[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1182 There are two issues with enabling `apache-release` by default: - it triggers creating source `apache-drill-...-src.tar.gz` and `apache-drill-...-src.zip` archives. - maven build for any sub-module fails. The change disables activation of the `apache-release` profile based on JDK version and requires explicit activation during the Apache release process. JDK 1.7 is not supported. See DRILL-1491 and #1143. ---
[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1182 I don't understand why the apache-release be disabled by default. And I don't see how this change achieves that anyway. Also, moving -Xdoclint:none to all profiles implies we are no longer supporting development using JDK7 ? I'm OK with that, but not sure if we concluded that at the time of the 1.13 release. If that's what we want to do, I'm fine with this change. ---
[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1182 @parthchandra Please review ---
