[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/500
  
Changed merged into master with commit id - 
223507b76ff6c2227e667ae4a53f743c92edd295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-16 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/500
  
Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-15 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/500
  
+1 looks good. Can you squash and rebase ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-14 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/500
  
@parthchandra 
I have added / updated several unit test with second commit. Could you 
please take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-13 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/500
  
Looks Good. Can you add another test case where a field contains a some of 
the initial bytes of the multibyte line delimiter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---