[GitHub] drill issue #519: DRILL-4530: Optimize partition pruning with metadata cachi...

2016-07-18 Thread jinfengni
Github user jinfengni commented on the issue:

https://github.com/apache/drill/pull/519
  
+1

LGTM.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #519: DRILL-4530: Optimize partition pruning with metadata cachi...

2016-07-15 Thread amansinha100
Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/519
  
@jinfengni ,  thanks for the review.  I have addressed your review 
comments.  Pls take another look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #519: DRILL-4530: Optimize partition pruning with metadata cachi...

2016-07-12 Thread jinfengni
Github user jinfengni commented on the issue:

https://github.com/apache/drill/pull/519
  
Other than prior comments, the pruning logic looks good to me. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---