[GitHub] drill issue #774: DRILL-5337: OpenTSDB storage plugin

2017-11-13 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/774
  
+1, LGTM.


---


[GitHub] drill issue #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/774
  
@Vlad-Storona I have deployed your branch and have noticed several more 
issues:
1. When I openTSDB storage plugin tab for the first time, its content is 
showing as null.
2. When I have indicated incorrect connection, the following exception is 
displayed in the log:
```
 org.apache.drill.common.exceptions.ExecutionSetupException: Failure 
setting up new storage plugin configuration for config 
org.apache.drill.exec.store.openTSDB.OpenTSDBStoragePluginConfig@a837d5e8
```
3. When I try to query with incorrect syntax, the following error is 
displayed:
```
 0: jdbc:drill:drillbit=localhost> select * from `mymetric.stock`;
Error: SYSTEM ERROR: IllegalArgumentException: Chunk [mymetric.stock] is 
not a valid entry
 
 Caused by: java.lang.IllegalArgumentException: Chunk [mymetric.stock] is 
not a valid entry
at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) 
~[guava-18.0.jar:na]
at com.google.common.base.Splitter$MapSplitter.split(Splitter.java:508) 
~[guava-18.0.jar:na]
```
4. When I try to enable storage plugin config with incorrect connection, it 
fails. I think we should allow enabling config even if we could not connect to 
openTSDB as others plugins do but fail when we try to query the data.


---


[GitHub] drill issue #774: DRILL-5337: OpenTSDB storage plugin

2017-11-03 Thread Vlad-Storona
Github user Vlad-Storona commented on the issue:

https://github.com/apache/drill/pull/774
  
@arina-ielchiieva Thanks for the review. I updated the PR. 

Please review updated changes.


---


[GitHub] drill issue #774: DRILL-5337: OpenTSDB storage plugin

2017-03-21 Thread dmitriyHavrilovich
Github user dmitriyHavrilovich commented on the issue:

https://github.com/apache/drill/pull/774
  
@arina-ielchiieva we done major refactor of code to follow your guideline


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---