[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
GitHub user ebegoli opened a pull request: https://github.com/apache/drill/pull/139 DRILL-3724 - added javadoc for core classes for storage plugin development. Changes are only to the javadoc. Code is not affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ebegoli/drill master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit ff8a310e2acb467d84d089eccd1314b81cb90d08 Author: Edmon Begoli Date: 2015-08-30T14:56:22Z DRILL-3724 Improve javadoc of the plugin component Improve the javadoc of the key methods and classes for custom plugin development. commit 6c47dc0a2372847fe755f30ad6199ae6acbe0523 Author: Edmon Begoli Date: 2015-08-30T15:00:18Z DRILL-3724 Improve javadoc of the plugin component Improve the javadoc of the key methods and classes for custom plugin development. commit d755eb391c1a9c4c7d39bcca93069c14b35ec7a7 Author: Edmon Begoli Date: 2015-08-30T15:03:43Z DRILL-3724 Improve javadoc of the plugin component commit b52d33c9750253e83ec8b03b01b2e71698de0609 Author: Edmon Begoli Date: 2015-08-30T15:08:35Z DRILL-3724 Improve javadoc of the plugin component --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/139#discussion_r38272883
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
@@ -115,6 +115,10 @@ public boolean isBlockSplittable() {
return blockSplittable;
}
+ /** Whether or not this format could also be in a compression container
(for example: csv.gz versus csv).
+ * This is an external compression container that would be handled
outside of the format code.
+ * This is an internal compression scheme, not supported by Parquet.
--- End diff --
A little unclear. Maybe "If this format uses its own internal compression
scheme, such as Parquet does, then this should return false."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user ebegoli commented on the pull request: https://github.com/apache/drill/pull/139#issuecomment-136155633 Fixed. Review please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/139#issuecomment-136156114 Looks good to me +1. I'll get this merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user ebegoli closed the pull request at: https://github.com/apache/drill/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
GitHub user ebegoli reopened a pull request: https://github.com/apache/drill/pull/139 DRILL-3724 - added javadoc for core classes for storage plugin development. Changes are only to the javadoc. Code is not affected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ebegoli/drill master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit ff8a310e2acb467d84d089eccd1314b81cb90d08 Author: Edmon Begoli Date: 2015-08-30T14:56:22Z DRILL-3724 Improve javadoc of the plugin component Improve the javadoc of the key methods and classes for custom plugin development. commit 6c47dc0a2372847fe755f30ad6199ae6acbe0523 Author: Edmon Begoli Date: 2015-08-30T15:00:18Z DRILL-3724 Improve javadoc of the plugin component Improve the javadoc of the key methods and classes for custom plugin development. commit d755eb391c1a9c4c7d39bcca93069c14b35ec7a7 Author: Edmon Begoli Date: 2015-08-30T15:03:43Z DRILL-3724 Improve javadoc of the plugin component commit b52d33c9750253e83ec8b03b01b2e71698de0609 Author: Edmon Begoli Date: 2015-08-30T15:08:35Z DRILL-3724 Improve javadoc of the plugin component commit 51f1206a953a347118e44a4db54f92287eb407b0 Author: Edmon Begoli Date: 2015-08-30T15:56:18Z DRILL-3724 Improve javadoc of storage components. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/139#issuecomment-139965734 This has been merged. However, I forgot to include the "merged in" message so @ebegoli , can you please close? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user ebegoli closed the pull request at: https://github.com/apache/drill/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request: DRILL-3724 - added javadoc for core classes fo...
Github user ebegoli commented on the pull request: https://github.com/apache/drill/pull/139#issuecomment-140044982 Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
