[GitHub] drill pull request #1127: DRILL-6021:Show shutdown button when authenticatio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1127


---

[GitHub] drill pull request #1127: DRILL-6021:Show shutdown button when authenticatio...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1127#discussion_r171075361
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java 
---
@@ -355,14 +356,16 @@ public ClusterInfo(Collection drillbits,
  boolean userEncryption,
  boolean bitEncryption,
  boolean shouldShowAdminInfo,
- QueueInfo queueInfo) {
+ QueueInfo queueInfo,
+ boolean authEnabled ) {
--- End diff --

Please remove space after `authEnabled` and before `)`.


---

[GitHub] drill pull request #1127: DRILL-6021:Show shutdown button when authenticatio...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1127#discussion_r171075503
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java 
---
@@ -411,6 +415,8 @@ public String getCurrentVersion() {
   public boolean shouldShowAdminInfo() { return shouldShowAdminInfo; }
 
   public QueueInfo queueInfo() { return queueInfo; }
+
+  public boolean authEnabled() { return  authEnabled; }
--- End diff --

Please rename `authEnabled` -> `isAuthEnabled`.


---

[GitHub] drill pull request #1127: DRILL-6021:Show shutdown button when authenticatio...

[dvjyothsna]

GitHub user dvjyothsna opened a pull request:

https://github.com/apache/drill/pull/1127

DRILL-6021:Show shutdown button when authentication is not enabled

Display the shutdown button when authentication is not enabled since the 
user is by default the admin when the authentication is not enabled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dvjyothsna/drill DRILL-6021

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1127


commit 788f65083e78795e6bf71a6d22150d9268169484
Author: Jyothsna Donapati 
Date:   2018-02-22T19:17:48Z

DRILL-6021:Show shutdown button when authentication is not enabled




---