[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1178


---

[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

[ilooner]

Github user ilooner commented on a diff in the pull request:

https://github.com/apache/drill/pull/1178#discussion_r176947145
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
 ---
@@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws 
Exception {
   @Test
   public void sortOneKeyAscending() throws Throwable {
 ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
-  .configProperty(ClassBuilder.CODE_DIR_OPTION, 
dirTestWatcher.getDir().getAbsolutePath())
   .configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
--- End diff --

Thanks for catching. Removed it.


---

[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1178#discussion_r176936575
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
 ---
@@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws 
Exception {
   @Test
   public void sortOneKeyAscending() throws Throwable {
 ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
-  .configProperty(ClassBuilder.CODE_DIR_OPTION, 
dirTestWatcher.getDir().getAbsolutePath())
   .configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
--- End diff --

I think this line should be also removed since 
`ENABLE_SAVE_CODE_FOR_DEBUG_TOPN` should be disabled for tests.


---

[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

[ilooner]

GitHub user ilooner opened a pull request:

https://github.com/apache/drill/pull/1178

DRILL-6278: Removed temp codegen directory in testing framework.

@vvysotskyi Please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner/drill DRILL-6278

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1178


commit bde89d68b570eaa8792baa2517fab3c9765c28a4
Author: Timothy Farkas 
Date:   2018-03-21T06:00:22Z

DRILL-6278: Removed temp codegen directory in testing framework.




---