[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1195 ---
[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178953868 --- Diff: tools/fmpp/src/main/java/bsh/package-info.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + /** + * Generate-fmpp has a dependency on beanshell EvalError. Beanshell doesn't have a valid + * Apache License, So beanshell is excluded and EvalError class is added to handle the dependency. + */ + +package bsh; --- End diff -- Please add LF and squash commits. ---
[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178364790 --- Diff: tools/fmpp/src/main/java/bsh/EvalError.java --- @@ -0,0 +1,28 @@ +/** --- End diff -- Please do not use doc comment for the license. ---
[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178365989 --- Diff: tools/fmpp/src/main/java/bsh/EvalError.java --- @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package bsh; +/** --- End diff -- will be better to have this comment in package-info. ---
[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178366218 --- Diff: tools/fmpp/pom.xml --- @@ -57,6 +57,10 @@ commons-logging-api commons-logging + + bsh --- End diff -- add bsh:org.beanshell to the prohibited dependencies. ---
[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...
GitHub user dvjyothsna opened a pull request: https://github.com/apache/drill/pull/1195 DRILL-6273: Removed dependency licensed under Category X @vrozov Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/dvjyothsna/drill DRILL-6273 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/1195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1195 commit fddaf9f88edd1f7584f86a1c77efb041dbf1fce9 Author: dvjyothsna Date: 2018-03-29T18:16:56Z DRILL-6273: Removed dependency licensed under Category X ---
