[GitHub] drill pull request #635: DRILL-4927 (part 2): Add support for Null Equality ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/635


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #635: DRILL-4927 (part 2): Add support for Null Equality ...

[amansinha100]

Github user amansinha100 commented on a diff in the pull request:

https://github.com/apache/drill/pull/635#discussion_r85625856
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
@@ -493,4 +496,81 @@ public void withNullEqualAdditionFilter() throws 
Exception {
 .go();
   }
 
+  @Test
+  public void withMixedEqualAndIsNotDistinctHashJoin() throws Exception {
--- End diff --

Could you add a test with the predicate of type: 
t1.key = t2.key AND ((t1.data=t2.data) OR (t1.data IS NULL AND t2.data 
IS NULL))
where the right side of the AND gets converted to IS NOT DISTINCT FROM.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #635: DRILL-4927 (part 2): Add support for Null Equality ...

[KulykRoman]

GitHub user KulykRoman opened a pull request:

https://github.com/apache/drill/pull/635

DRILL-4927 (part 2): Add support for Null Equality Joins (mixed compa…

…rators)

This changes are a subset of the original pull request from DRILL-4539 
(PR-462).
- Added changes to support mixed comparators;
- Added tests for it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KulykRoman/drill DRILL-4927

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #635


commit 47abbd9aa21443d76bb58b001d3f8a2e36511a7f
Author: Roman Kulyk 
Date:   2016-10-28T13:26:53Z

DRILL-4927 (part 2): Add support for Null Equality Joins (mixed comparators)

This changes are a subset of the original pull request from DRILL-4539 
(PR-462).
- Added changes to support mixed comparators;
- Added tests for it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---