[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446661541 Thanks so much @vdiravka for merging it in. Yes, I plan to create a JIRA to track the disabled tests - they have some dependency on the index reference implementation so will need to be addressed later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446417564 @amansinha100 thanks for the review and approval. I have addressed your remaining review comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446398113 @amansinha100 I have made the changes you requested. Please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin
gparai commented on issue #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568#issuecomment-446035159 @amansinha100 I have modified the rowkeyjoin pushdown testcases. With these changes I now see only the following unit test failures which are unrelated to this feature. IndexPlanTest.testNoFilterGroupByHashIndex IndexPlanTest.testNoFilterOrderByHashIndex Please take a look. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
