[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437862742 @vvysotskyi I was able to remove warning on startup by adding `--add-opens` for all accessed modules. But there is not guarantee that this warning will not be shown later. What about Visual C++ Runtime library? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437848102 @vvysotskyi, `2.7.1` is the latest version of `hadoop-winutils` (in central.maven.org) > Also, could you please hide warnings which are displayed after starting Drill in embedded mode for JDK 9+ for both Linux and Windows? According to http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-May/012673.html there is no official way to remove this warnings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437848102 @vvysotskyi, `2.7.1` is the latest version of `hadoop-winutils`. > Also, could you please hide warnings which are displayed after starting Drill in embedded mode for JDK 9+ for both Linux and Windows? According to http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-May/012673.html there is no official way to remove this warnings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 @vvysotskyi I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils) requires a `visual c ++ redistributable` (msvcr100.dll). There is 2 options: 1) Require `visual c ++ redistributable` to be installed by user (via documentation?) 2) Add msvcr100.dll for Windows x64 into `winutils/bin` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils) requires a `visual c ++ redistributable` (msvcr100.dll). There is 2 options: 1) Require `visual c ++ redistributable` to be installed by user (via documentation?) 2) Add msvcr100.dll for Windows x64 into `winutils/bin` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437823097 I finally managed to reproduce the error. The `winutils.exe` (Hadoop WinUtils) requires a `visual c ++ redistributable` (msvcr100.dll). There is 2 options: 1) Require `visual c ++ redistributable` to be installed by user (via documentation maybe?) 2) Add msvcr100.dll for Windows x64 into `winutils/bin` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437384087 @vvysotskyi Sorry, I cannot reproduce this issue on Windows... 1) This method not calling during Drill startup 2) Even if I try to add a storage plugin, it works just fine. P.S. Time limit error for last build... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437014456 @vvysotskyi Thanks for sqlline validation. I can run Drill from user home directory on fresh windows 10 installation in virtual box without any error message. Can you provide more information about error? Configured file storage plugins for example? P.S. Do you have a `HADOOP_HOME` or `hadoop.home.dir` variable set? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-437014456 @vvysotskyi Thanks for sqlline validation. I can run Drill from user home directory on fresh windows 10 installation in virtual box without any error message. Can you provide more information about error? Configured file storage plugins for example? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-436205818 @vvysotskyi review, please. Also, can you validate the `sqlline.bat` on Windows? I have no Windows PC available This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-435043350 @vvysotskyi 1) Javassist with Java 11 support released today (https://github.com/jboss-javassist/javassist/releases/tag/rel_3_24_0_ga) and now missing in central maven repository. I will provide fixes when this version appears in maven. :) 2) According to http://www.javassist.org/html/javassist/util/proxy/DefineClassHelper.html#toClass(java.lang.String,java.lang.Class,java.lang.ClassLoader,java.security.ProtectionDomain,byte%5B%5D), --add-opens should be added for java 9+ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-435013897 @vvysotskyi please, review my changes in jdbc-all pom.xml I had to add `com.jasonclawson` into relocation, because drill start fails with HoconFactory to JsonFactory cast error in StoragePluginsHandlerService P.S. Maybe com.jasonclawson can be excluded from shade? It is used only in StoragePluginsHandlerService located in org.apache.drill.exec.store package and this package excluded from shaded artifact. FYI. https://stackoverflow.com/questions/53010200/maven-surefire-could-not-find-forkedbooter-class/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-435013897 @vvysotskyi please, review my changes in jdbc-all pom.xml I had to add `com.jasonclawson` into relocation, because drill start fails with HoconFactory to JsonFactory cast error in StoragePluginsHandlerService P.S. Maybe com.jasonclawson can be excluded from shade? It is used only in StoragePluginsHandlerService located in org.apache.drill.exec.store package and this package excluded from shaded artifact. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434277967 @vvysotskyi > I think it is ok to change modifier to PRIVATE for inner and nested classes. The PRIVATE modifier has been removed, not added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434254256 @vvysotskyi Sory, i was mistaken in > This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. NestingKind getNestingKind() exists since Java 1.6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434263357 @vvysotskyi I managed to fix this for Java 11 by removing PRIVATE modifier from inner / inner static classes in ClassGenerator. Is this acceptable? P.S. I accidentally added a locale settings in surefire with last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434263357 @vvysotskyi I managed to fix this for Java 11 by removing PRIVATE modifier from inner / inner static classes in ClassGenerator. Is this acceptable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434254256 @vvysotskyi Sory, i was mistaken in > This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. NestingKind getNestingKind() exists from Java 1.6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires correctly specified "nest host" for inner classes. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. For java 11 target support in JDK compiler CompilationConfig#ASM_API_VERSION should be set to ASM7, but it can break compatibility with Java 8. May be this version can be detected in runtime? P.P.S. "Nest host" can be added with ASM ClassVisitor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434251463 @vvysotskyi TestLargeFileCompilation.testEXTERNAL_SORT:153->BaseTestQuery.testNoResult:384 » Rpc TestLargeFileCompilation.testPARQUET_WRITER:140->BaseTestQuery.testNoResult:384 » Rpc TestLargeFileCompilation.testProject:172->BaseTestQuery.testNoResult:384 » Rpc TestLargeFileCompilation.testTOP_N_SORT:159->BaseTestQuery.testNoResult:384 » Rpc Error text: > Caused by: java.lang.IncompatibleClassChangeError: Type org.apache.drill.exec.test.generated.ProjectorGen30258$ProjectorGen302580 is not a nest member of org.apache.drill.exec.test.generated.ProjectorGen30258: current type is not listed as a nest member >at org.apache.drill.exec.test.generated.ProjectorGen30258.__DRILL_INIT__(ProjectorTemplate.java) ~[na:na] >at org.apache.drill.exec.test.generated.ProjectorGen30258.(ProjectorTemplate.java:41) ~[na:na] >at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:na] >at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:na] >at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:na] >at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[na:na] >at java.base/java.lang.Class.newInstance(Class.java:584) ~[na:na] >at org.apache.drill.exec.compile.CodeCompiler.createInstances(CodeCompiler.java:193) ~[classes/:na] >at org.apache.drill.exec.compile.CodeCompiler.createInstance(CodeCompiler.java:163) ~[classes/:na] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires correctly specified kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. For java 11 target support in JDK compiler CompilationConfig#ASM_API_VERSION should be set to ASM7, but it can break compatibility with Java 8. May be this version can be detected in runtime? P.P.S. "Nest host" can be added with ASM ClassVisitor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires correctly specified kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. For java 11 JDK compiler support CompilationConfig#ASM_API_VERSION should be set to ASM7, but it can break compatibility with Java 8. May be this version can be detected in runtime? P.P.S. "Nest host" can be added with ASM ClassVisitor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires correctly specified kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. For java 11 JDK compiler support CompilationConfig#ASM_API_VERSION should be set to ASM7, but it can break compatibility with Java 8. May be this version can be detected in runtime? P.P.S. "Nestmates" can be added with ASM ClassVisitor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires you yo correctly specify the kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. May be "nestmates" can be added with ASM ClassVisitor? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires correctly specified kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility. P.S. May be "nestmates" can be added with ASM ClassVisitor? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-434231490 @vvysotskyi > Also, recently was released ASM 7.0, which supports JDK 11 features, so we can update it and revert changes connected with specifying the target and source versions in JDKClassCompiler. There is an issue with java 11 JDK compiler and Drill code generation even after asm version update. JDK compiler requires you yo correctly specify the kind of "nest" for inner classes. This can be done by overriding SimpleJavaFileObject#getNestingKind, but it will break java 11- compatibility. So source and target version should be specified for JDK compiler Also, thanks for your note about HBase version. I had tried to update it to 1.1.11, but run into problems with Guava versions incompatibility This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver
fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
URL: https://github.com/apache/drill/pull/1446#issuecomment-432165721
> @oleg-zinovev, Is it make sence to move these two dependencies to the root
pom?
@vvysotskyi, it isn't make sence at all, so i remove this dependencies.
I try to build Drill with fresh JDK 11 and fix new errors:
1) JMockit 1.39 -> 1.43. JMockit had an issue with java 11
(https://github.com/jmockit/jmockit1/issues/534), so I had to update this
dependecy. Starting JMockit 1.42, "-javaagent" must be specified to run tests
(http://jmockit.github.io/tutorial/Introduction.html#runningTests) and
jmockit.integration.junit4.JMockit.class was removed. That's why i have to
change this tests:
- TestCastFunctions.java
- TestConstantFolding.java
- TestDateConversions.java
- TestDateFunctions.java
- TestExtendedTypes.java
- TestUtf8SupportInQueryString.java
- AvroFormatTest.java
2) BoundsCheckingTest.java fails with IllegalAccessException. This was fixed
by adding a call of setAccessible(true).
3) JDKClassCompiler.java - Java 11 intoduces 'Nests'
(http://openjdk.java.net/jeps/181), and resulting byte-code, generated by javac
11 requires a "Nests" support from ASM visitors. Since Drill supports java 1.8+
i simply add a target and source version to javac call, to not have to change
ASM visitors.
4) hadoop 2.7.1 -> 2.7.4. Haboop org.apache.hadoop.util.Shell class in
version 2.7.1 contains a Java version check:
`System.getProperty("java.version").substring(0, 3).compareTo("1.7") >= 0;`
But, for jdk 11 (at least for OpenJDK Ubuntu package),
System.getProperty("java.version") return "11", and substring call fails. I had
to update hadoop to minimal version, which not contains this call.
5) TestImpersonationMetadata.java - in hadoop 2.7.4 error message was
changed, so i slightly change a "expected" error to fit both new and old
messages.
6) maven-source-plugin fails to execute "jar-no-fork" on JDK 11, and i
update it to the latest version.
Now on java 11 fails:
1) HBase tests
2) Hive test
I will try to update a HBase and revalidate drill on JDK 9 and JDK 10 to the
end of the week.
P.S. I am sorry for possible mistakes because of my bad English
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-416520694 build works with Java 9, except hive and kafka tests (HBase tests surprisely works) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
oleg-zinovev edited a comment on issue #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#issuecomment-416298784 At least Kafka and HBase tests can not be fixed under Java 9+ HBase: https://hbase.apache.org/book.html#java - Java 9+ not supported yet Kafka: https://kafka.apache.org/documentation/#java - only Java 8 is mentioned This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
