[GitHub] vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files
vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin
for LTSV files
URL: https://github.com/apache/drill/pull/1627#discussion_r255199611
##
File path:
contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.ltsv;
+
+import org.apache.drill.common.exceptions.ExecutionSetupException;
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.common.logical.StoragePluginConfig;
+import org.apache.drill.exec.ops.FragmentContext;
+import org.apache.drill.exec.proto.UserBitShared;
+import org.apache.drill.exec.server.DrillbitContext;
+import org.apache.drill.exec.store.RecordReader;
+import org.apache.drill.exec.store.RecordWriter;
+import org.apache.drill.exec.store.dfs.DrillFileSystem;
+import org.apache.drill.exec.store.dfs.easy.EasyFormatPlugin;
+import org.apache.drill.exec.store.dfs.easy.EasyWriter;
+import org.apache.drill.exec.store.dfs.easy.FileWork;
+import org.apache.hadoop.conf.Configuration;
+
+import java.io.IOException;
+import java.util.List;
+
+public class LTSVFormatPlugin extends EasyFormatPlugin
{
+
+private static final boolean IS_COMPRESSIBLE = false;
+private static final String DEFAULT_NAME = "ltsv";
+private LTSVFormatPluginConfig config;
+
+private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(LTSVFormatPlugin.class);
+
+public LTSVFormatPlugin(String name, DrillbitContext context,
Configuration fsConf, StoragePluginConfig storageConfig) {
+this(name, context, fsConf, storageConfig, new
LTSVFormatPluginConfig());
+}
+
+public LTSVFormatPlugin(String name, DrillbitContext context,
Configuration fsConf, StoragePluginConfig config, LTSVFormatPluginConfig
formatPluginConfig) {
+super(name, context, fsConf, config, formatPluginConfig, true, false,
false, IS_COMPRESSIBLE, formatPluginConfig.getExtensions(), DEFAULT_NAME);
+this.config = formatPluginConfig;
+}
+
+@Override
+public RecordReader getRecordReader(FragmentContext context,
DrillFileSystem dfs, FileWork fileWork,
+List columns, String
userName) throws ExecutionSetupException {
+return new LTSVRecordReader(context, fileWork.getPath(), dfs, columns,
config);
+}
+
+
+@Override
+public int getReaderOperatorType() {
+// TODO Is it correct??
+return UserBitShared.CoreOperatorType.JSON_SUB_SCAN_VALUE;
Review comment:
@shimamoto @cgivre
The good news:
by simply rebasing to the master branch you can see the Protobuf job in
Travis.
If it fails, it means your changes require Protobuf regenerating.
So you can do protobuf regenerating or just copy the `git diff` from the
Protobuf Travis job and apply it as a patch in your IDE.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin for LTSV files
vdiravka commented on a change in pull request #1627: DRILL-7014: Format plugin
for LTSV files
URL: https://github.com/apache/drill/pull/1627#discussion_r253824507
##
File path:
contrib/format-ltsv/src/main/java/org/apache/drill/exec/store/ltsv/LTSVFormatPlugin.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.ltsv;
+
+import org.apache.drill.common.exceptions.ExecutionSetupException;
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.common.logical.StoragePluginConfig;
+import org.apache.drill.exec.ops.FragmentContext;
+import org.apache.drill.exec.proto.UserBitShared;
+import org.apache.drill.exec.server.DrillbitContext;
+import org.apache.drill.exec.store.RecordReader;
+import org.apache.drill.exec.store.RecordWriter;
+import org.apache.drill.exec.store.dfs.DrillFileSystem;
+import org.apache.drill.exec.store.dfs.easy.EasyFormatPlugin;
+import org.apache.drill.exec.store.dfs.easy.EasyWriter;
+import org.apache.drill.exec.store.dfs.easy.FileWork;
+import org.apache.hadoop.conf.Configuration;
+
+import java.io.IOException;
+import java.util.List;
+
+public class LTSVFormatPlugin extends EasyFormatPlugin
{
+
+private static final boolean IS_COMPRESSIBLE = false;
+private static final String DEFAULT_NAME = "ltsv";
+private LTSVFormatPluginConfig config;
+
+private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(LTSVFormatPlugin.class);
+
+public LTSVFormatPlugin(String name, DrillbitContext context,
Configuration fsConf, StoragePluginConfig storageConfig) {
+this(name, context, fsConf, storageConfig, new
LTSVFormatPluginConfig());
+}
+
+public LTSVFormatPlugin(String name, DrillbitContext context,
Configuration fsConf, StoragePluginConfig config, LTSVFormatPluginConfig
formatPluginConfig) {
+super(name, context, fsConf, config, formatPluginConfig, true, false,
false, IS_COMPRESSIBLE, formatPluginConfig.getExtensions(), DEFAULT_NAME);
+this.config = formatPluginConfig;
+}
+
+@Override
+public RecordReader getRecordReader(FragmentContext context,
DrillFileSystem dfs, FileWork fileWork,
+List columns, String
userName) throws ExecutionSetupException {
+return new LTSVRecordReader(context, fileWork.getPath(), dfs, columns,
config);
+}
+
+
+@Override
+public int getReaderOperatorType() {
+// TODO Is it correct??
+return UserBitShared.CoreOperatorType.JSON_SUB_SCAN_VALUE;
Review comment:
It is used for Drill RPC. You can find more info about it here:
https://github.com/paul-rogers/drill/wiki/RPC-Protocol
In your case it is necessary for determining proper type of the reader for
`EasySubScan` operator, once the last is transferred to some Drill fragment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
