[GitHub] vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21
vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21 URL: https://github.com/apache/drill/pull/1561#issuecomment-444990050 @sohami oops, sorry, missed that. Also I have a conversation with @arina-ielchiieva and @vvysotskyi about Avatica version update. It is not safe to update it without Calcite version update, see code changes in Calcite project for leveraging 1.13.0 Avatica version: https://github.com/julianhyde/calcite/commit/86377861bb761373fe9dc2a792b0c28b53ee5911 Versions of some libs will be different without update onto Calcite 1.18.0 in Drill. It is better to update them together. I will factor out changes regarding Avatica update into separate commit and will make the reference onto it in Calcite [DRILL-6862](https://issues.apache.org/jira/browse/DRILL-6751). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21
vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21 URL: https://github.com/apache/drill/pull/1561#issuecomment-444928201 @sohami Thank you for review. Looks like there is no more need in converting `RuntimeException` to `SQLException`, it was resolved in Avatica-1.9.0 for a long time ago, see [CALCITE-1408](https://issues.apache.org/jira/browse/CALCITE-1408) For now it is [`SQLDataException`](https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java#L367) (inheritor of `java.sql.SQLException`). Therefore no need to have WrappedAccessor in Drill. I have updated it and squashed "Changes after the review" with the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21
vdiravka commented on issue #1561: DRILL-6751: Upgrade Apache parent POM to version 21 URL: https://github.com/apache/drill/pull/1561#issuecomment-444175473 @sohami Could you please review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
