[GitHub] vvysotskyi commented on issue #1445: DRILL-6706: fixed null pointer exception in HashJoin
vvysotskyi commented on issue #1445: DRILL-6706: fixed null pointer exception in HashJoin URL: https://github.com/apache/drill/pull/1445#issuecomment-416532411 @ilooner, I don't have any objection regarding this PR. If this bug is critical, it may be merged and DRILL-6714 with more proper fix may be done later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvysotskyi commented on issue #1445: DRILL-6706: fixed null pointer exception in HashJoin
vvysotskyi commented on issue #1445: DRILL-6706: fixed null pointer exception in HashJoin URL: https://github.com/apache/drill/pull/1445#issuecomment-416167363 @sachouche, I think more proper solution is to store `SchemaPath` instances or their string representations in `columnSizes` map to avoid ambiguities. Also, logic in `getComplexColumn` should be rewritten (all this code was added after DRILL-4264, but this logic breaks changes made in DRILL-4264). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
