Re: Load JDBC service ServiceLoader

2016-09-06 Thread Laurent Goujon
That sounds like a good idea. The JDBC example has a
Class.forName("org.apache.drill.jdbc.Driver") statement to force driver
registration, but a ServiceLoader registration is pretty standard. Maybe
you should open a bug for it?

Laurent

On Tue, Sep 6, 2016 at 9:53 AM, Sudip Mukherjee 
wrote:

> Hi,
> I am trying out a java program where I want to load drill JDBC driver
> using ServiceLoader.load like all other jdbc drivers. But the code is
> failing to load org.apache.drill.jdbc.Driver class. One possible reason
> Is that the drill jdbc driver jar doesn't have a java.sql.Driver file
> under META_INF/services which is common for all the other driver jars.
>
> Can the drill jdbc driver jar come with the driver file?
>
> Thanks,
> Sudip
>


RE: Load JDBC service ServiceLoader

2016-09-06 Thread Sudip Mukherjee
Hi Laurent,
Thanks for your comment. I've created a Jira DRILL-4880.

Sudip

-Original Message-
From: Laurent Goujon [mailto:laur...@dremio.com] 
Sent: Wednesday, September 07, 2016 4:33 AM
To: dev@drill.apache.org
Subject: Re: Load JDBC service ServiceLoader

That sounds like a good idea. The JDBC example has a
Class.forName("org.apache.drill.jdbc.Driver") statement to force driver 
registration, but a ServiceLoader registration is pretty standard. Maybe you 
should open a bug for it?

Laurent

On Tue, Sep 6, 2016 at 9:53 AM, Sudip Mukherjee 
wrote:

> Hi,
> I am trying out a java program where I want to load drill JDBC driver 
> using ServiceLoader.load like all other jdbc drivers. But the code is 
> failing to load org.apache.drill.jdbc.Driver class. One possible 
> reason Is that the drill jdbc driver jar doesn't have a 
> java.sql.Driver file under META_INF/services which is common for all the 
> other driver jars.
>
> Can the drill jdbc driver jar come with the driver file?
>
> Thanks,
> Sudip
>