Re: Review Request 34024: DRILL-3010: Convert bad command error messages into UserExceptions in SqlHandlers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34024/#review83207 --- Ship it! Ship It! - Mehant Baid On May 10, 2015, 4:23 p.m., Venki Korukanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34024/ --- (Updated May 10, 2015, 4:23 p.m.) Review request for drill and Mehant Baid. Bugs: DRILL-3010 https://issues.apache.org/jira/browse/DRILL-3010 Repository: drill-git Description --- Please see for details: https://issues.apache.org/jira/browse/DRILL-3010 Diffs - common/src/main/java/org/apache/drill/common/exceptions/UserException.java 9283339 exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 9e2f210 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/AbstractSqlHandler.java 96fd877 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java e9ac1e1 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java c76914b exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java 7062375 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java 3d42f76 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 7ae5e0d exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/UseSchemaHandler.java e17e275 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java c59c3a2 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 9f1a695 exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 33ddea5 exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 916564d exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java f8ec090 exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java 411660f exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 958cf1a exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java 5fff956 exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java 8bcbc7a exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 0fc1f32 protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java a229450 protocol/src/main/java/org/apache/drill/exec/proto/beans/DrillPBError.java 873ffa4 protocol/src/main/protobuf/UserBitShared.proto a17dbc7 Diff: https://reviews.apache.org/r/34024/diff/ Testing --- Existing unittest have good coverage of various exepected bad command message. Converted those to test for UserException with expected error message. Thanks, Venki Korukanti
Re: Review Request 34024: DRILL-3010: Convert bad command error messages into UserExceptions in SqlHandlers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34024/ --- (Updated May 10, 2015, 9:23 a.m.) Review request for drill and Mehant Baid. Changes --- posting the actual patch. Bugs: DRILL-3010 https://issues.apache.org/jira/browse/DRILL-3010 Repository: drill-git Description --- Please see for details: https://issues.apache.org/jira/browse/DRILL-3010 Diffs (updated) - common/src/main/java/org/apache/drill/common/exceptions/UserException.java 9283339 exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 9e2f210 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/AbstractSqlHandler.java 96fd877 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java e9ac1e1 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeTableHandler.java c76914b exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowFileHandler.java 7062375 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ShowTablesHandler.java 3d42f76 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 7ae5e0d exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/UseSchemaHandler.java e17e275 exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java c59c3a2 exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 9f1a695 exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 33ddea5 exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 916564d exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java f8ec090 exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java 411660f exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 958cf1a exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java 5fff956 exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java 8bcbc7a exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 0fc1f32 protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java a229450 protocol/src/main/java/org/apache/drill/exec/proto/beans/DrillPBError.java 873ffa4 protocol/src/main/protobuf/UserBitShared.proto a17dbc7 Diff: https://reviews.apache.org/r/34024/diff/ Testing --- Existing unittest have good coverage of various exepected bad command message. Converted those to test for UserException with expected error message. Thanks, Venki Korukanti
Review Request 34024: DRILL-3010: Convert bad command error messages into UserExceptions in SqlHandlers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34024/ --- Review request for drill and Mehant Baid. Bugs: DRILL-3010 https://issues.apache.org/jira/browse/DRILL-3010 Repository: drill-git Description --- Please see for details: https://issues.apache.org/jira/browse/DRILL-3010 Diffs - pom.xml 8c9f09e Diff: https://reviews.apache.org/r/34024/diff/ Testing --- Existing unittest have good coverage of various exepected bad command message. Converted those to test for UserException with expected error message. Thanks, Venki Korukanti
