Review Request 34234: DRILL-3071: fix memory leak in RecordBatchLoader#load
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34234/ --- Review request for drill, Parth Chandra and Steven Phillips. Repository: drill-git Description --- DRILL-3071: fix memory leak in RecordBatchLoader#load - Clean up allocated vectors in case loading a batch fails. Diffs - exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java 1b8b7cea870d252d0c16babc975de5d2caa56d42 Diff: https://reviews.apache.org/r/34234/diff/ Testing --- unit + regression Thanks, Hanifi Gunes
Re: Review Request 34234: DRILL-3071: fix memory leak in RecordBatchLoader#load
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34234/ --- (Updated May 14, 2015, 9:20 p.m.) Review request for drill, Parth Chandra and Steven Phillips. Changes --- - consistently use VV#clear - typo fix Repository: drill-git Description --- DRILL-3071: fix memory leak in RecordBatchLoader#load - Clean up allocated vectors in case loading a batch fails. Diffs (updated) - exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java 1b8b7cea870d252d0c16babc975de5d2caa56d42 Diff: https://reviews.apache.org/r/34234/diff/ Testing --- unit + regression Thanks, Hanifi Gunes
Re: Review Request 34234: DRILL-3071: fix memory leak in RecordBatchLoader#load
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34234/#review83842 --- Ship it! Ship It! - Steven Phillips On May 14, 2015, 9:06 p.m., Hanifi Gunes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34234/ > --- > > (Updated May 14, 2015, 9:06 p.m.) > > > Review request for drill, Parth Chandra and Steven Phillips. > > > Repository: drill-git > > > Description > --- > > DRILL-3071: fix memory leak in RecordBatchLoader#load > > - Clean up allocated vectors in case loading a batch fails. > > > Diffs > - > > > exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java > 1b8b7cea870d252d0c16babc975de5d2caa56d42 > > Diff: https://reviews.apache.org/r/34234/diff/ > > > Testing > --- > > unit + regression > > > Thanks, > > Hanifi Gunes > >
