Review Request 37896: DRILL-3719: Adding negative sign in front of EXTRACT triggers Assertion Error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37896/ --- Review request for drill, Aman Sinha, Jinfeng Ni, and Mehant Baid. Bugs: DRILL-3719 https://issues.apache.org/jira/browse/DRILL-3719 Repository: drill-git Description --- Expand -expression as -1 * expression in DrillOptiq Diffs - exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 11b9c9e exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf Diff: https://reviews.apache.org/r/37896/diff/ Testing --- on the way Thanks, Sean Hsuan-Yi Chu
Re: Review Request 37896: DRILL-3719: Adding negative sign in front of EXTRACT triggers Assertion Error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37896/ --- (Updated Aug. 28, 2015, 11:03 p.m.) Review request for drill, Aman Sinha, Jinfeng Ni, and Mehant Baid. Bugs: DRILL-3719 https://issues.apache.org/jira/browse/DRILL-3719 Repository: drill-git Description --- Expand -expression as -1 * expression in DrillOptiq Diffs - exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 11b9c9e exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf Diff: https://reviews.apache.org/r/37896/diff/ Testing (updated) --- all passed Thanks, Sean Hsuan-Yi Chu
Re: Review Request 37896: DRILL-3719: Adding negative sign in front of EXTRACT triggers Assertion Error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37896/#review96926 --- exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java (line 1107) https://reviews.apache.org/r/37896/#comment152618 shouldn't the test case expression be: -Extract(day from birth_date) and not include the multiplication explicitly? - Mehant Baid On Aug. 28, 2015, 5:40 p.m., Sean Hsuan-Yi Chu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37896/ --- (Updated Aug. 28, 2015, 5:40 p.m.) Review request for drill, Aman Sinha, Jinfeng Ni, and Mehant Baid. Bugs: DRILL-3719 https://issues.apache.org/jira/browse/DRILL-3719 Repository: drill-git Description --- Expand -expression as -1 * expression in DrillOptiq Diffs - exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 11b9c9e exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf Diff: https://reviews.apache.org/r/37896/diff/ Testing --- on the way Thanks, Sean Hsuan-Yi Chu
Re: Review Request 37896: DRILL-3719: Adding negative sign in front of EXTRACT triggers Assertion Error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37896/ --- (Updated Aug. 28, 2015, 10:14 p.m.) Review request for drill, Aman Sinha, Jinfeng Ni, and Mehant Baid. Changes --- Addressed the comments Bugs: DRILL-3719 https://issues.apache.org/jira/browse/DRILL-3719 Repository: drill-git Description --- Expand -expression as -1 * expression in DrillOptiq Diffs (updated) - exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java 11b9c9e exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java 6b74ecf Diff: https://reviews.apache.org/r/37896/diff/ Testing --- on the way Thanks, Sean Hsuan-Yi Chu
