[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403121757 @leventov : Created a new PR, please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403543885 @leventov: last batch of comments was re lines more than 120 cols, add line breaks and reformatted code. Also replied to your comments on previous PR, If you have any more comments can you please add them here ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403850554 Thanks @jihoonson for helping with the review and taking this PR forward. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-407462520 @leventov @jihoonson : Thanks for the review comments, addressed them. Do you have any more comments ? Also, can you please add some info on how much of the review is pending and when can we expect to merge this one in. Its blocking feature development/patches for Apache Hive Integration for handling nulls coming from druid properly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
