Re: Metrics updates in Release Notes
Thanks Roman. I'm helping with the release this time so I will check the PRs with that label and include them in the release notes as appropriate. As far as I know, there isn't any document like that, but I agree it would be quite useful. On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov wrote: > It's suggested that the person that prepares Druid Release Notes (I think > it's Jon usually) goes through all PRs labelled "Area - Metrics/Event > Emitting" ( > > https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 > ) > along with "Release Notes", to present this information in the release > notes. > > BTW I wonder is the a document in the repository or elsewhere that > describes the release process? >
Re: Metrics updates in Release Notes
Why not also tag those with "Release Notes"? It makes it a lot easier for release managers to do their jobs if they just have to look at one label. (Or two, I guess: "release notes" and "incompatible". But I would be down to merge them.) On Wed, Oct 31, 2018 at 9:26 AM David Lim wrote: > Thanks Roman. I'm helping with the release this time so I will check the > PRs with that label and include them in the release notes as appropriate. > > As far as I know, there isn't any document like that, but I agree it would > be quite useful. > > On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov > wrote: > > > It's suggested that the person that prepares Druid Release Notes (I think > > it's Jon usually) goes through all PRs labelled "Area - Metrics/Event > > Emitting" ( > > > > > https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 > > ) > > along with "Release Notes", to present this information in the release > > notes. > > > > BTW I wonder is the a document in the repository or elsewhere that > > describes the release process? > > >
Re: Metrics updates in Release Notes
I don't think we have a doc about how to do a release, but yeah it would be great to have it. Dave, would you be able to put it together while you manage this release? I am sure it will differ substantially from what we've done in the past, because of the new Apache-ified stuff. On Wed, Oct 31, 2018 at 10:07 AM Gian Merlino wrote: > Why not also tag those with "Release Notes"? It makes it a lot easier for > release managers to do their jobs if they just have to look at one label. > (Or two, I guess: "release notes" and "incompatible". But I would be down > to merge them.) > > On Wed, Oct 31, 2018 at 9:26 AM David Lim wrote: > >> Thanks Roman. I'm helping with the release this time so I will check the >> PRs with that label and include them in the release notes as appropriate. >> >> As far as I know, there isn't any document like that, but I agree it would >> be quite useful. >> >> On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov >> wrote: >> >> > It's suggested that the person that prepares Druid Release Notes (I >> think >> > it's Jon usually) goes through all PRs labelled "Area - Metrics/Event >> > Emitting" ( >> > >> > >> https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 >> > ) >> > along with "Release Notes", to present this information in the release >> > notes. >> > >> > BTW I wonder is the a document in the repository or elsewhere that >> > describes the release process? >> > >> >
Re: Metrics updates in Release Notes
I think people will often forget to put both tags, so the person who does the release should check the tag Metrics/Event Emitting anyway, just in case. On Wed, 31 Oct 2018 at 18:09, Gian Merlino wrote: > I don't think we have a doc about how to do a release, but yeah it would be > great to have it. Dave, would you be able to put it together while you > manage this release? I am sure it will differ substantially from what we've > done in the past, because of the new Apache-ified stuff. > > On Wed, Oct 31, 2018 at 10:07 AM Gian Merlino wrote: > > > Why not also tag those with "Release Notes"? It makes it a lot easier for > > release managers to do their jobs if they just have to look at one label. > > (Or two, I guess: "release notes" and "incompatible". But I would be down > > to merge them.) > > > > On Wed, Oct 31, 2018 at 9:26 AM David Lim wrote: > > > >> Thanks Roman. I'm helping with the release this time so I will check the > >> PRs with that label and include them in the release notes as > appropriate. > >> > >> As far as I know, there isn't any document like that, but I agree it > would > >> be quite useful. > >> > >> On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov > >> wrote: > >> > >> > It's suggested that the person that prepares Druid Release Notes (I > >> think > >> > it's Jon usually) goes through all PRs labelled "Area - Metrics/Event > >> > Emitting" ( > >> > > >> > > >> > https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 > >> > ) > >> > along with "Release Notes", to present this information in the release > >> > notes. > >> > > >> > BTW I wonder is the a document in the repository or elsewhere that > >> > describes the release process? > >> > > >> > > >
Re: Metrics updates in Release Notes
Why is "metrics / event emitting" special, though? Why shouldn't we ask the release manager to look at _all_ tags just in case? (Which is clearly too much burden for a release manager -- I'm trying to make an argument, I guess, that it's fair to push some of the burden to the committer that originally merged the PR.) On Wed, Oct 31, 2018 at 10:44 AM Roman Leventov wrote: > I think people will often forget to put both tags, so the person who does > the release should check the tag Metrics/Event Emitting anyway, just in > case. > > On Wed, 31 Oct 2018 at 18:09, Gian Merlino wrote: > > > I don't think we have a doc about how to do a release, but yeah it would > be > > great to have it. Dave, would you be able to put it together while you > > manage this release? I am sure it will differ substantially from what > we've > > done in the past, because of the new Apache-ified stuff. > > > > On Wed, Oct 31, 2018 at 10:07 AM Gian Merlino wrote: > > > > > Why not also tag those with "Release Notes"? It makes it a lot easier > for > > > release managers to do their jobs if they just have to look at one > label. > > > (Or two, I guess: "release notes" and "incompatible". But I would be > down > > > to merge them.) > > > > > > On Wed, Oct 31, 2018 at 9:26 AM David Lim wrote: > > > > > >> Thanks Roman. I'm helping with the release this time so I will check > the > > >> PRs with that label and include them in the release notes as > > appropriate. > > >> > > >> As far as I know, there isn't any document like that, but I agree it > > would > > >> be quite useful. > > >> > > >> On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov > > >> wrote: > > >> > > >> > It's suggested that the person that prepares Druid Release Notes (I > > >> think > > >> > it's Jon usually) goes through all PRs labelled "Area - > Metrics/Event > > >> > Emitting" ( > > >> > > > >> > > > >> > > > https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 > > >> > ) > > >> > along with "Release Notes", to present this information in the > release > > >> > notes. > > >> > > > >> > BTW I wonder is the a document in the repository or elsewhere that > > >> > describes the release process? > > >> > > > >> > > > > > >
Re: Metrics updates in Release Notes
I think because Metrics / Event Emitting PRs usually make something that needs to be reflected in the release notes, while ordinary PRs - not so often. On Wed, 31 Oct 2018 at 18:47, Gian Merlino wrote: > Why is "metrics / event emitting" special, though? Why shouldn't we ask the > release manager to look at _all_ tags just in case? (Which is clearly too > much burden for a release manager -- I'm trying to make an argument, I > guess, that it's fair to push some of the burden to the committer that > originally merged the PR.) > > On Wed, Oct 31, 2018 at 10:44 AM Roman Leventov > wrote: > > > I think people will often forget to put both tags, so the person who does > > the release should check the tag Metrics/Event Emitting anyway, just in > > case. > > > > On Wed, 31 Oct 2018 at 18:09, Gian Merlino wrote: > > > > > I don't think we have a doc about how to do a release, but yeah it > would > > be > > > great to have it. Dave, would you be able to put it together while you > > > manage this release? I am sure it will differ substantially from what > > we've > > > done in the past, because of the new Apache-ified stuff. > > > > > > On Wed, Oct 31, 2018 at 10:07 AM Gian Merlino wrote: > > > > > > > Why not also tag those with "Release Notes"? It makes it a lot easier > > for > > > > release managers to do their jobs if they just have to look at one > > label. > > > > (Or two, I guess: "release notes" and "incompatible". But I would be > > down > > > > to merge them.) > > > > > > > > On Wed, Oct 31, 2018 at 9:26 AM David Lim > wrote: > > > > > > > >> Thanks Roman. I'm helping with the release this time so I will check > > the > > > >> PRs with that label and include them in the release notes as > > > appropriate. > > > >> > > > >> As far as I know, there isn't any document like that, but I agree it > > > would > > > >> be quite useful. > > > >> > > > >> On Wed, Oct 31, 2018 at 9:04 AM Roman Leventov > > > > >> wrote: > > > >> > > > >> > It's suggested that the person that prepares Druid Release Notes > (I > > > >> think > > > >> > it's Jon usually) goes through all PRs labelled "Area - > > Metrics/Event > > > >> > Emitting" ( > > > >> > > > > >> > > > > >> > > > > > > https://github.com/apache/incubator-druid/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Area+-+Metrics%2FEvent+Emitting%22+is%3Aclosed+milestone%3A0.13.0 > > > >> > ) > > > >> > along with "Release Notes", to present this information in the > > release > > > >> > notes. > > > >> > > > > >> > BTW I wonder is the a document in the repository or elsewhere that > > > >> > describes the release process? > > > >> > > > > >> > > > > > > > > > >
