Re: group-by v1

2023-07-17 Thread Gian Merlino
+1 to removing it.

The only benefit I am aware of is the same one that you mentioned. But I
don't think this needs to block removing the old v1 algo.

On Wed, Jul 12, 2023 at 4:07 AM Clint Wylie  wrote:

> Is anyone opposed to removing group-by v1? I think it would allow us
> to simplify quite a lot of stuff. While it would very nice to
> implement 'growable' buffer aggregators so that the v2 algorithm could
> be a bit more flexible and finally cover the only potential reason I
> can imagine people might still be using v1, I don't think that this
> needs to block removal.
>
> So, is anyone out there still using group-by v1 and would be sad by it
> going away?
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
> For additional commands, e-mail: dev-h...@druid.apache.org
>
>


group-by v1

2023-07-12 Thread Clint Wylie
Is anyone opposed to removing group-by v1? I think it would allow us
to simplify quite a lot of stuff. While it would very nice to
implement 'growable' buffer aggregators so that the v2 algorithm could
be a bit more flexible and finally cover the only potential reason I
can imagine people might still be using v1, I don't think that this
needs to block removal.

So, is anyone out there still using group-by v1 and would be sad by it
going away?

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org