[GitHub] ralf0131 commented on issue #1500: not support java 10
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-375189599 What JMH version are you using, is it Java 10 compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hank-whu commented on issue #1500: not support java 10
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-375187678 There's no exception, but not work. You can run the test: https://github.com/hank-whu/rpc-benchmark/tree/master/dubbo-client https://github.com/hank-whu/rpc-benchmark/tree/master/dubbo-server This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hank-whu commented on issue #1500: not support java 10
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-375187678 There's no exception, but not work. You can run the test: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zonghaishang commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者
zonghaishang commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/66#issuecomment-375187446 @luffyke I have written a demo for you. [simpledemo.zip](https://github.com/apache/incubator-dubbo-spring-boot-project/files/1836229/simpledemo.zip) f the same service provider and consumer are in one project, the consumer will not initiate a remote invocation because of use injvm protocol.   You can debug my demo to see that, Hopefully I can helpe to you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1500: not support java 10
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-375186994 Hi, Welcome! Can you provide more details, e.g. do you have stack trace? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] c297186864 opened a new issue #77: Do you have a complete configuration file (application.properties)?
c297186864 opened a new issue #77: Do you have a complete configuration file (application.properties)? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/77 Or explain the document This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1499: move JettyContainer and PageHandler's impls classes
ralf0131 commented on issue #1499: move JettyContainer and PageHandler's impls classes URL: https://github.com/apache/incubator-dubbo/issues/1499#issuecomment-375186663 Hi, Welcome! Would you mind send a PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vangoleo commented on issue #1393: Please subscribe the Apache incubator mailing list
vangoleo commented on issue #1393: Please subscribe the Apache incubator mailing list URL: https://github.com/apache/incubator-dubbo/issues/1393#issuecomment-375185433 Subscribed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hank-whu opened a new issue #1500: not support java 10
hank-whu opened a new issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500 Can't start the dubbo server. VM version: JDK 10, VM 10+46 OS version: Ubuntu 16.04 x64 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] apel-apel commented on issue #1498: 服务端崩溃，报RpcException(Forbid consumer)时，mock无效
apel-apel commented on issue #1498: 服务端崩溃，报RpcException(Forbid consumer)时，mock无效
URL:
https://github.com/apache/incubator-dubbo/issues/1498#issuecomment-375172819
### similar question
I feel that the mock is not work,this is my spring xml config about dubbo
below：
provider.xml
```xml
```
consumer.xml
```xml
```
my provider obviously throw a RpcExcepton, and I expect the mock result
return, but consumer still throws the exception;
my provider class:
```java
public class DemoServiceImpl implements DemoService {
public String sayHello(String name) {
System.out.println("[" + new SimpleDateFormat("HH:mm:ss").format(new
Date()) + "] Hello " + name + ", request from consumer: " +
RpcContext.getContext().getRemoteAddress());
if (true) {
throw new RpcException("system error");
}
return "Hello " + name + ", response form provider: " +
RpcContext.getContext().getLocalAddress();
}
}
```
my mock class:
```java
public class DemoServiceMock implements DemoService {
public DemoServiceMock() {
}
@Override
public String sayHello(String name) {
return "I am mock";
}
}
```
is there something wrong?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] qcxyzff commented on issue #423: 服务提供者启动暴露服务后，总出现少量请求超时，Consumer出现RpcException异常.
qcxyzff commented on issue #423: 服务提供者启动暴露服务后，总出现少量请求超时，Consumer出现RpcException异常. URL: https://github.com/apache/incubator-dubbo/issues/423#issuecomment-375169611 这个是刚开始启动时，需要连monitorservice，而且是加锁的，你可以把monitor功能关掉，就可以了 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 0oo commented on issue #1497: 修复使用simpleregistry时provider注册异常
0oo commented on issue #1497: 修复使用simpleregistry时provider注册异常 URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-375161055 发现是 Fixes #1289, use bind_port as mapping key 108fe0f72f57a4e137c5203e293dc05d7a90d4dd 引入的问题， bind_port可能导致其它问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 0oo commented on issue #1497: 修复使用simpleregistry时provider注册异常
0oo commented on issue #1497: 修复使用simpleregistry时provider注册异常 URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-375161055 发现是 Fixes #1289, use bind_port as mapping key 108fe0f72f57a4e137c5203e293dc05d7a90d4dd 引入的问题， 改用bind_port可能导致其它问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #76: 请问2.0什么时候能出来啊？
ralf0131 commented on issue #76: 请问2.0什么时候能出来啊？ URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/76#issuecomment-375160618 Hi, you can ask by sending an email to dev@dubbo.apache.org , issues are used to track bugs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 closed issue #76: 请问2.0什么时候能出来啊？
ralf0131 closed issue #76: 请问2.0什么时候能出来啊？ URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/76 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wannshan opened a new issue #1499: move JettyContainer and PageHandler's impls classes
wannshan opened a new issue #1499: move JettyContainer and PageHandler's impls classes URL: https://github.com/apache/incubator-dubbo/issues/1499 JettyContainer and PageHandler's impls classes should move to dubbo-ops/dubbo-monitor-simple from dubbo.jar This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luffyke commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者
luffyke commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/66#issuecomment-375155895 @zonghaishang Is there any document or code i can reference to for what you say > If the same service provider and consumer are in one project, the consumer will inject from the spring context to get the provider and will not initiate a remote invocation? What i concern is that we use provider and consumer in the same project, and i found that many user have such requirement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luffyke commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者
luffyke commented on issue #66: 请问如何配置一个项目既是消费者，又是提供者 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/66#issuecomment-375155895 @zonghaishang Is there any document or code i can reference to for what you say "If the same service provider and consumer are in one project, the consumer will inject from the spring context to get the provider and will not initiate a remote invocation"? What i concern is that we use provider and consumer in the same project, and i found that many user have such requirement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] c297186864 commented on issue #76: 请问2.0什么时候能出来啊？
c297186864 commented on issue #76: 请问2.0什么时候能出来啊？ URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/76#issuecomment-375153371 ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luffyke commented on issue #68: Infer dubbo configuration without classpath scanning
luffyke commented on issue #68: Infer dubbo configuration without classpath scanning URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/68#issuecomment-374827502 @adriancole, do you mean use Annotation instead of config ```dubbo.scan.basePackages = com.demo.dubbo.boot.demo.service``` in config file, such as ```@EnableDubboConfiguration``` in another dubbo-starter project(i guess [alibaba/dubbo-spring-boot-starter](https://github.com/alibaba/dubbo-spring-boot-starter))? @mercyblitz pls correct below sentence to remove Reference in README because Reference not need to scan as you said. ``` # Base packages to scan Dubbo Components (e.g @Service , @Reference) ``` and i suggest to use Annotation instead of config **dubbo.scan.basePackages**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luffyke commented on issue #76: 请问2.0什么时候能出来啊？
luffyke commented on issue #76: 请问2.0什么时候能出来啊？ URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/76#issuecomment-375152288 Please use English when firing issue as Dubbo has been a apache incubator project. Support Spring Boot 2.0 question is duplicated with #71 This dubbo-spring-boot-project is official project, dubbo-spring-boot-starter under alibaba group is 3rd support project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] c297186864 opened a new issue #76: 请问2.0什么时候能出来啊？
c297186864 opened a new issue #76: 请问2.0什么时候能出来啊？ URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/76 如题，请问2.0什么事出来，https://github.com/alibaba/dubbo-spring-boot-starter 这个项目是你们的吗 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] luffyke commented on issue #75: How to use with zookeeper
luffyke commented on issue #75: How to use with zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/75#issuecomment-375151703 Duplicated with #61 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo
AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-375146698 公司：长江证券股份有限公司 地址：武汉 联系方式：zhoubin_...@163.com 业务场景：部分业务服务化以及服务治理 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo
AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-375146698 公司：长江证券股份有限公司 地址：武汉 联系方式：zhoubin_...@163.com 业务场景：部分业务服务化以及服务治理 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo
AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-375146698 公司：长江证券股份有限公司 地址：武汉 联系方式：邮箱 zhoubin_...@163.com 业务场景：部分业务服务化以及服务治理 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo
AaronZhou-WHU commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-375146698 公司：长江证券股份有限公司 地址：武汉 联系方式：zhoubin_...@163.com 业务场景：部分业务服务化以及服务治理 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrhou commented on issue #1012: Wanted: who's using dubbo
xrhou commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-375035049 公司：杭州庙街网络科技有限公司 地址：中国浙江杭州 联系方式： 微信 murd555you，邮箱：ho...@qq.com 业务场景：核心业务系统内部服务化 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
consider merge this pr: make ExecutionDispatcher meet the description of dubbo-user-book
Hi guys, please consider merge pr https://github.com/apache/incubator-dubbo/pull/1449 it fixes issue https://github.com/apache/incubator-dubbo/issues/1089, issue digest: ExecutionDispatcher is differ from the description in dubbo-user-book, it's almost the same with AllDispatcher.
[GitHub] mercyblitz commented on issue #63: Replace META-INF/spring-configuration-metadata.json manually
mercyblitz commented on issue #63: Replace META-INF/spring-configuration-metadata.json manually URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/63#issuecomment-374917555 @duming08899 I will commit code in this week, will release one in next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz closed issue #74: 可以在生产环境上使用么
mercyblitz closed issue #74: 可以在生产环境上使用么 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/74 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz commented on issue #74: 可以在生产环境上使用么
mercyblitz commented on issue #74: 可以在生产环境上使用么 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/74#issuecomment-374917163 It works on Aliyun Cloud production environment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning
mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/68#issuecomment-374917007 In a word , Dubbo's `@Service` is like Spring's `@Service` ,and `@Reference` is like `@Autowired`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning
mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/68#issuecomment-374916705 @luffyke Annotation and `dubbo.scan.basePackages` property both works fine. 1. If prefer to annotation-driven , `@DubboComponentScan` scans `@Service` 2. All `@Reference` injections do not depend on `dubbo.scan.basePackages` or `@DubboComponentScan` in Spring Boot application. it only requires `@Reference` declaring class is a valid `@Component` class or its' variants. 3. The usage of `@DubboComponentScan` is same as `@ComponentScan` , all attributes are optional. If `com.acme.Comfiguration` annotated `@ComponentScan` , all valid `@Component` class or its' variants class will be scanned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning
mercyblitz commented on issue #68: Infer dubbo configuration without classpath scanning URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/68#issuecomment-374916705 @luffyke Annotation and `dubbo.scan.basePackages` property both works fine. 1. If prefer to annotation-driven , `@DubboComponentScan` scans `@Service` 2. All `@Reference` injections does not depend on `dubbo.scan.basePackages` or `@DubboComponentScan` in Spring Boot application. it only requires `@Reference` declaring class is a valid `@Component` class or its' variants. 3. The usage of `@DubboComponentScan` is same as `@ComponentScan` , all attributes are optional. If `com.acme.Comfiguration` annotated `@ComponentScan` , all valid `@Component` class or its' variants class will be scanned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] paopaoteng commented on issue #487: 有没有人遇到消费者调用dubbo服务 Forbid 问题
paopaoteng commented on issue #487: 有没有人遇到消费者调用dubbo服务 Forbid 问题 URL: https://github.com/apache/incubator-dubbo/issues/487#issuecomment-374915147 如果provider掉线报forbid的错误，那什么时候会报no provider的错误呢？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JackLee1993 commented on issue #1475: update StringUtils isBlank and add isNotBlank method
JackLee1993 commented on issue #1475: update StringUtils isBlank and add isNotBlank method URL: https://github.com/apache/incubator-dubbo/pull/1475#issuecomment-374910829 It is too slow to deal with merge requests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JackLee1993 closed pull request #1475: update StringUtils isBlank and add isNotBlank method
JackLee1993 closed pull request #1475: update StringUtils isBlank and add
isNotBlank method
URL: https://github.com/apache/incubator-dubbo/pull/1475
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanDescriptor.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanDescriptor.java
index ab6060663d..456833397c 100644
---
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanDescriptor.java
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanDescriptor.java
@@ -22,6 +22,9 @@
import java.util.LinkedHashMap;
import java.util.Map;
+import static com.alibaba.dubbo.common.utils.Assert.notBlank;
+import static com.alibaba.dubbo.common.utils.Assert.notNull;
+
public final class JavaBeanDescriptor implements Serializable,
Iterable> {
public static final int TYPE_CLASS = 1;
@@ -65,7 +68,7 @@ public JavaBeanDescriptor() {
}
public JavaBeanDescriptor(String className, int type) {
-notEmpty(className, "class name is empty");
+notBlank(className, "class name is empty");
if (!isValidType(type)) {
throw new IllegalArgumentException(
new StringBuilder(16).append("type [ ")
@@ -195,20 +198,4 @@ public int propertySize() {
private boolean isValidType(int type) {
return TYPE_MIN <= type && type <= TYPE_MAX;
}
-
-private void notNull(Object obj, String message) {
-if (obj == null) {
-throw new IllegalArgumentException(message);
-}
-}
-
-private void notEmpty(String string, String message) {
-if (isEmpty(string)) {
-throw new IllegalArgumentException(message);
-}
-}
-
-private boolean isEmpty(String string) {
-return string == null || "".equals(string.trim());
-}
}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
index 72a242f9bc..54ec69333c 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
@@ -34,4 +34,15 @@ public static void notNull(Object obj, RuntimeException
exeception) {
}
}
+public static void notEmpty(String string, String message) {
+if (StringUtils.isEmpty(string)) {
+throw new IllegalArgumentException(message);
+}
+}
+
+public static void notBlank(String string, String message) {
+if (StringUtils.isBlank(string)) {
+throw new IllegalArgumentException(message);
+}
+}
}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
index faf349f801..ee56c4b804 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
@@ -48,9 +48,18 @@ private StringUtils() {
}
public static boolean isBlank(String str) {
-if (str == null || str.length() == 0)
-return true;
-return false;
+if (isEmpty(str)) return true;
+
+for (int i = 0; i < str.length(); i++) {
+if (!Character.isWhitespace(str.charAt(i))) {
+return false;
+}
+}
+return true;
+}
+
+public static boolean isNotBlank(String str) {
+return !isBlank(str);
}
/**
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] paopaoteng opened a new issue #1498: 服务端崩溃，报RpcException(Forbid consumer)时，mock无效
paopaoteng opened a new issue #1498: 服务端崩溃，报RpcException(Forbid consumer)时，mock无效 URL: https://github.com/apache/incubator-dubbo/issues/1498 在xml文件里配置 当服务端全部挂掉时，客户端调用服务报Forbid consumer的RpcException，此时Mock没有生效。 看源码是RegistryDirectory.refreshInvoker中将forbidden修改为true，此时mock也会报同样的错误。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenwenzhang commented on issue #75: How to use with zookeeper
chenwenzhang commented on issue #75: How to use with zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/75#issuecomment-374896449 @Jukewu thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1497: 修复使用simpleregistry时provider注册异常
codecov-io commented on issue #1497: 修复使用simpleregistry时provider注册异常 URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-374891504 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=h1) Report > Merging [#1497](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=desc) into [2.5.x](https://codecov.io/gh/apache/incubator-dubbo/commit/4f3454002414f19ee07664c731a02aa30c4d8b27?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=tree) ```diff @@Coverage Diff @@ ##2.5.x#1497 +/- ## == - Coverage 28.34% 28.34% -0.01% == Files 791 791 Lines 4173541735 Branches 8529 8529 == - Hits1183011829 -1 - Misses 2782927831 +2 + Partials 2076 2075 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...a/dubbo/registry/simple/SimpleRegistryService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tc2ltcGxlL2R1YmJvLXJlZ2lzdHJ5LXNpbXBsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlZ2lzdHJ5L3NpbXBsZS9TaW1wbGVSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `4.2% <0%> (ø)` | :arrow_up: | | [...aba/dubbo/monitor/simple/SimpleMonitorService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tc2ltcGxlL2R1YmJvLW1vbml0b3Itc2ltcGxlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vbW9uaXRvci9zaW1wbGUvU2ltcGxlTW9uaXRvclNlcnZpY2UuamF2YQ==) | `48.08% <0%> (-3.83%)` | :arrow_down: | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `73.14% <0%> (-2.78%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kZWZhdWx0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9GdXR1cmVGaWx0ZXIuamF2YQ==) | `54.54% <0%> (-2.03%)` | :arrow_down: | | [...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=) | `3.17% <0%> (-0.87%)` | :arrow_down: | | [...mmon/serialize/support/dubbo/GenericDataInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L2R1YmJvL0dlbmVyaWNEYXRhSW5wdXQuamF2YQ==) | `60.23% <0%> (+1.93%)` | :arrow_up: | | [...mon/serialize/support/dubbo/GenericDataOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9zdXBwb3J0L2R1YmJvL0dlbmVyaWNEYXRhT3V0cHV0LmphdmE=) | `68.07% <0%> (+3.5%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1497/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kZWZhdWx0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9DaGFuZ2VUZWxuZXRIYW5kbGVyLmphdmE=) | `90.9% <0%> (+4.54%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=footer). Last update [4f34540...a243a07](https://codecov.io/gh/apache/incubator-dubbo/pull/1497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] CLAassistant commented on issue #1497: 修复使用simpleregistry时provider注册异常
CLAassistant commented on issue #1497: 修复使用simpleregistry时provider注册异常 URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-374887241 [](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=1497) All committers have signed the CLA. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] CLAassistant commented on issue #1497: 修复使用simpleregistry时provider注册异常
CLAassistant commented on issue #1497: 修复使用simpleregistry时provider注册异常 URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-374887241 [](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=1497) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=1497) before we can accept your contribution.**0oo** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/apache/incubator-dubbo?pullRequest=1497) it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 0oo opened a new pull request #1497: 修复使用simpleregistry时provider注册异常
0oo opened a new pull request #1497: 修复使用simpleregistry时provider注册异常
URL: https://github.com/apache/incubator-dubbo/pull/1497
修复使用simpleregistry时provider注册异常，原因：simpleregistry在notify时将URL对象中的para
meters中的bind.port传给客户端，导致异常
[21/03/18 06:07:16:016 CST] New I/O client worker #1-1 INFO
dubbo.CallbackServiceCodec: [DUBBO] Not found exported service:
com.alibaba.dubbo.registry.NotifyListener.617013740:61709 in
[com.alibaba.dubbo.registry.NotifyListener.1141296884:61709,
com.alibaba.dubbo.registry.NotifyListener.617013740:9090,
com.alibaba.dubbo.demo.DemoService:20880], may be version or group mismatch ,
channel: consumer: /192.168.84.31:9090 --> provider: /192.168.84.31:61709,
message:RpcInvocation [methodName=notify, parameterTypes=[interface
java.util.List], arguments=null, attachments={dubbo=2.0.1, input=721,
_isCallBackServiceInvoke=true, sys_callback_arg-1=617013740,
path=com.alibaba.dubbo.registry.NotifyListener,
callback.service.instid=617013740,
interface=com.alibaba.dubbo.registry.RegistryService, version=null}], dubbo
version: 2.0.1, current host: 192.168.84.31
com.alibaba.dubbo.remoting.RemotingException: Not found exported service:
com.alibaba.dubbo.registry.NotifyListener.617013740:61709 in
[com.alibaba.dubbo.registry.NotifyListener.1141296884:61709,
com.alibaba.dubbo.registry.NotifyListener.617013740:9090,
com.alibaba.dubbo.demo.DemoService:20880], may be version or group mismatch ,
channel: consumer: /192.168.84.31:9090 --> provider: /192.168.84.31:61709,
message:RpcInvocation [methodName=notify, parameterTypes=[interface
java.util.List], arguments=null, attachments={dubbo=2.0.1, input=721,
_isCallBackServiceInvoke=true, sys_callback_arg-1=617013740,
path=com.alibaba.dubbo.registry.NotifyListener,
callback.service.instid=617013740,
interface=com.alibaba.dubbo.registry.RegistryService, version=null}]
at
com.alibaba.dubbo.rpc.protocol.dubbo.DubboProtocol.getInvoker(DubboProtocol.java:202)
at
com.alibaba.dubbo.rpc.protocol.dubbo.CallbackServiceCodec.decodeInvocationArgument(CallbackServiceCodec.java:270)
at
com.alibaba.dubbo.rpc.protocol.dubbo.DecodeableRpcInvocation.decode(DecodeableRpcInvocation.java:127)
at
com.alibaba.dubbo.rpc.protocol.dubbo.DecodeableRpcInvocation.decode(DecodeableRpcInvocation.java:68)
at
com.alibaba.dubbo.rpc.protocol.dubbo.DubboCodec.decodeBody(DubboCodec.java:128)
at
com.alibaba.dubbo.remoting.exchange.codec.ExchangeCodec.decode(ExchangeCodec.java:120)
at
com.alibaba.dubbo.remoting.exchange.codec.ExchangeCodec.decode(ExchangeCodec.java:81)
at
com.alibaba.dubbo.rpc.protocol.dubbo.DubboCountCodec.decode(DubboCountCodec.java:44)
at
com.alibaba.dubbo.remoting.transport.netty.NettyCodecAdapter$InternalDecoder.messageReceived(NettyCodecAdapter.java:133)
at
org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80)
at
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
at
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274)
at
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261)
at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349)
at
org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280)
at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200)
at
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
at
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:662)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #1496: Update DemoServiceImpl.java
codecov-io commented on issue #1496: Update DemoServiceImpl.java URL: https://github.com/apache/incubator-dubbo/pull/1496#issuecomment-374882147 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=h1) Report > Merging [#1496](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/1ca021ca71841ab1a32e017f5836daaf2c2d59a0?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1496 +/- ## == - Coverage 31.58% 31.55% -0.04% == Files 682 682 Lines 3303533035 Branches 6592 6592 == - Hits1043510425 -10 - Misses 2074720755 +8 - Partials 1853 1855 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...m/alibaba/dubbo/demo/provider/DemoServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9EZW1vU2VydmljZUltcGwuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0%> (-11.27%)` | :arrow_down: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | :arrow_down: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1496/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+5%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=footer). Last update [1ca021c...2e5716b](https://codecov.io/gh/apache/incubator-dubbo/pull/1496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Jukewu commented on issue #75: How to use with zookeeper
Jukewu commented on issue #75: How to use with zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/75#issuecomment-374876243 you can refer to #61 or > dubbo.registry.id= > dubbo.registry.protocol=zookeeper > dubbo.registry.address=192.168.86.119 > dubbo.registry.port=2184 > dubbo.registry.client=curator This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] CLAassistant commented on issue #1496: Update DemoServiceImpl.java
CLAassistant commented on issue #1496: Update DemoServiceImpl.java URL: https://github.com/apache/incubator-dubbo/pull/1496#issuecomment-374875538 [](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=1496) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/apache/incubator-dubbo?pullRequest=1496) before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/apache/incubator-dubbo?pullRequest=1496) it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mp16 opened a new pull request #1496: Update DemoServiceImpl.java
mp16 opened a new pull request #1496: Update DemoServiceImpl.java URL: https://github.com/apache/incubator-dubbo/pull/1496 修改一个小小的微不足道的问题。 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mp16 commented on issue #1496: Update DemoServiceImpl.java
mp16 commented on issue #1496: Update DemoServiceImpl.java URL: https://github.com/apache/incubator-dubbo/pull/1496#issuecomment-374874602 修改一个小小的问题 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenwenzhang opened a new issue #75: How to use with zookeeper
chenwenzhang opened a new issue #75: How to use with zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/75 How to use with zookeeper This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] adriancole commented on issue #68: Infer dubbo configuration without classpath scanning
adriancole commented on issue #68: Infer dubbo configuration without classpath scanning URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/68#issuecomment-374865582 Basically I want to be precise within a package.. explicitly not try to wire things that happen to be in same package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] linuke opened a new issue #1495: When provide netty4 compares the performance test with the netty3.
linuke opened a new issue #1495: When provide netty4 compares the performance test with the netty3. URL: https://github.com/apache/incubator-dubbo/issues/1495 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
