[GitHub] vangoleo commented on issue #1501: local mock not work according by the user manual
vangoleo commented on issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379654105 @diecui1202 Finished. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1501: local mock not work according by the user manual
ralf0131 commented on issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379654948 This has been fixed by https://github.com/apache/incubator-dubbo-docs/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 closed issue #1501: local mock not work according by the user manual
ralf0131 closed issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] proaway commented on issue #1012: Wanted: who's using dubbo
proaway commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379622902 公司:银湖网络科技有限公司 地址:中国北京 联系方式: proa...@qq.com 场景:共享服务体系架构 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type
nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180007828 ## File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extension/SpringExtensionFactory.java ## @@ -47,6 +52,24 @@ public static void removeApplicationContext(ApplicationContext context) { } } } + +if (logger.isDebugEnabled()) { +logger.debug("No spring extension(bean) named:" + name + ", type:" + type.getName() + " found. Will try to get bean by type only."); +} + +for (ApplicationContext context : contexts) { +try { +return context.getBean(type); Review comment: whether the getBean() returns null or not, this line will end the function progress, is it the real purpose? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool
carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#discussion_r180008545 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/enhanced/EnhancedThreadPoolExecutor.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.dubbo.common.threadpool.support.enhanced; + +import java.util.concurrent.RejectedExecutionHandler; +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.RejectedExecutionException; +import java.util.concurrent.atomic.AtomicInteger; + +/** + * Enhanced thread pool + */ +public class EnhancedThreadPoolExecutor extends ThreadPoolExecutor { + +//task count +private final AtomicInteger submittedTaskCount = new AtomicInteger(0); + +public EnhancedThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime, TimeUnit unit, EnhancedTaskQueue workQueue, ThreadFactory threadFactory, RejectedExecutionHandler handler) { +super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory, handler); +} + +/** + * @return current tasks which are executed + */ +public int getSubmittedTaskCount() { +return submittedTaskCount.get(); +} + +@Override +protected void afterExecute(Runnable r, Throwable t) { +submittedTaskCount.decrementAndGet(); +} + +@Override +public void execute(Runnable command) { +//do not increment in method beforeExecute! +submittedTaskCount.incrementAndGet(); +try { +super.execute(command); +} catch (RejectedExecutionException rx) { Review comment: It can not be a problem because the `submittedTaskCount` will be decreased in the 'afterExecute' method. But the RejectedExecutionException is thrown before the task run. So when the RejectedExecutionException is thrown , we should decrease the submittedTaskCount. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leyou240 commented on issue #1553: add missing @Override to classes
leyou240 commented on issue #1553: add missing @Override to classes URL: https://github.com/apache/incubator-dubbo/pull/1553#issuecomment-379661581 aim to #1239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool
carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#discussion_r180009020 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/enhanced/EnhancedTaskQueue.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.dubbo.common.threadpool.support.enhanced; Review comment: How about EagerThreadPoolExecutor means the executor is eager to more tasks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] VanXD commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突
VanXD commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379671041 @tangdu is there any way use java config?there nothing about qos, did i miss something? ![image](https://user-images.githubusercontent.com/9159171/38486846-d0f22f18-3c10-11e8-9d37-da3495b5ce15.png) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mzorro opened a new pull request #1573: Method extraction & Unnecessary code remove & Typo fix
mzorro opened a new pull request #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573 - Break old "loadFile" into pieces, improve readability. - Remove some unnecessary code. - Some typo fix. In conclusion, this change has no actual effects, just some code improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wanhuhou opened a new pull request #1574: circuitBreaker
wanhuhou opened a new pull request #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574 ## What is the purpose of the change Add CircuitBreaker This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix
codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573#issuecomment-379682150 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=h1) Report > Merging [#1573](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `71.87%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/graphs/tree.svg?token=VnEIkiFQT0&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1573 +/- ## == + Coverage 32.17% 32.19% +0.02% == Files 682 682 Lines 3297232977 +5 Branches 6597 6598 +1 == + Hits1060810617 +9 + Misses 2046820467 -1 + Partials 1896 1893 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `71.69% <71.87%> (+0.7%)` | :arrow_up: | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `38% <0%> (-0.46%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `56.56% <0%> (+2.02%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=footer). Last update [497803c...bb3eb3a](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix
codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573#issuecomment-379682150 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=h1) Report > Merging [#1573](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `71.87%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/graphs/tree.svg?src=pr&token=VnEIkiFQT0&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1573 +/- ## == + Coverage 32.17% 32.19% +0.02% == Files 682 682 Lines 3297232977 +5 Branches 6597 6598 +1 == + Hits1060810617 +9 + Misses 2046820467 -1 + Partials 1896 1893 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `71.69% <71.87%> (+0.7%)` | :arrow_up: | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `38% <0%> (-0.46%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `56.56% <0%> (+2.02%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=footer). Last update [497803c...bb3eb3a](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1568: Extension: Enhanced Thread Pool
codecov-io commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9003c125a97280624a1e312ac1f5f22d05a491bf?src=pr&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `62.22%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/graphs/tree.svg?src=pr&token=VnEIkiFQT0&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1568 +/- ## == + Coverage 32.14% 32.25% +0.11% == Files 682 685 +3 Lines 3297233017 +45 Branches 6597 6603 +6 == + Hits1060010651 +51 + Misses 2048020467 -13 - Partials 1892 1899 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...eadpool/support/eager/EagerThreadPoolExecutor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2xFeGVjdXRvci5qYXZh) | `52.63% <52.63%> (ø)` | | | [...bbo/common/threadpool/support/eager/TaskQueue.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9UYXNrUXVldWUuamF2YQ==) | `56.25% <56.25%> (ø)` | | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <90%> (ø)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-5.56%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `54.54% <0%> (-2.03%)` | :arrow_down: | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `38% <0%> (-0.46%)` | :arrow_down: | | [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `25.93% <0%> (+0.89%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=footer). Last update [9003c12...eb2c406](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1574: circuitBreaker
ralf0131 commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379685516 1. The CI has failed. 2. This is a significant change, you need to sign the SGA before merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iamybj commented on issue #1012: Wanted: who's using dubbo
iamybj commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379691513 熊样,都是一群小鸡巴公司。 阿里所谓的开源,就是为了KPI和名声,把人家外国公司早就开源的程序,拿过来自己改改,然后新起一个名字,释放出去沽名钓誉。 这和它妈的中国某些部门,把人家外国的东西拿来打磨掉LOGO,然后把自己的LOGO印上去,就说是自主知识产权有什么区别? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iamybj commented on issue #1012: Wanted: who's using dubbo
iamybj commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379691513 熊样,都是一群小鸡巴公司。 阿里所谓的开源,就是为了KPI和名声,把人家外国公司早就开源的程序,拿过来自己改改,然后新起一个名字,释放出去沽名钓誉。 这和它妈的中国某些部门,把人家外国的东西拿来打磨掉LOGO,然后把自己的LOGO印上去,就说是自主知识产权有什么区别? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wzlee commented on issue #1571: Is there any deadline to release a version?
wzlee commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379694174 @litttlefisher https://github.com/apache/incubator-dubbo-spring-boot-project This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hengyunabc commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突
hengyunabc commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379694617 @VanXD https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.1/dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/protocol/QosProtocolWrapper.java#L79 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] litttlefisher commented on issue #1571: Is there any deadline to release a version?
litttlefisher commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379699560 [issue91](https://github.com/apache/incubator-dubbo-spring-boot-project/issues/91) It's said that dubbo-spring-boot is waiting dubbo 2.5.11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1574: circuitBreaker
codecov-io commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379704926 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=h1) Report > Merging [#1574](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **decrease** coverage by `0.35%`. > The diff coverage is `2.12%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/graphs/tree.svg?src=pr&token=VnEIkiFQT0&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1574 +/- ## == - Coverage 32.17% 31.81% -0.36% == Files 682 692 +10 Lines 3297233394 +422 Branches 6597 6679 +82 == + Hits1060810625 +17 - Misses 2046820869 +401 - Partials 1896 1900 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | :arrow_up: | | [...alibaba/dubbo/flowcontrol/CircuitBreakerUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZmxvd2NvbnRyb2wvQ2lyY3VpdEJyZWFrZXJVdGlscy5qYXZh) | `0% <0%> (ø)` | | | [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvaW50ZWdyYXRpb24vUmVnaXN0cnlEaXJlY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...in/java/com/alibaba/dubbo/flowcontrol/Circuit.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZmxvd2NvbnRyb2wvQ2lyY3VpdC5qYXZh) | `0% <0%> (ø)` | | | [...alibaba/dubbo/flowcontrol/CircuitBreakerState.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtZGVmYXVsdC9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2Zsb3djb250cm9sL0NpcmN1aXRCcmVha2VyU3RhdGUuamF2YQ==) | `0% <0%> (ø)` | | | [...ubbo/flowcontrol/CircuitBreakerManagerDefault.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtZGVmYXVsdC9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2Zsb3djb250cm9sL0NpcmN1aXRCcmVha2VyTWFuYWdlckRlZmF1bHQuamF2YQ==) | `0% <0%> (ø)` | | | [.../com/alibaba/dubbo/flowcontrol/CircuitBreaker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtZGVmYXVsdC9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2Zsb3djb250cm9sL0NpcmN1aXRCcmVha2VyLmphdmE=) | `0% <0%> (ø)` | | | [.../cluster/loadbalance/CircuitRandomLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL0NpcmN1aXRSYW5kb21Mb2FkQmFsYW5jZS5qYXZh) | `0% <0%> (ø)` | | | [...ain/java/com/alibaba/dubbo/flowcontrol/Bucket.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtZGVmYXVsdC9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2Zsb3djb250cm9sL0J1Y2tldC5qYXZh) | `0% <0%> (ø)` | | | [...dubbo/flowcontrol/filter/CircuitBreakerFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree#diff-ZHViYm8tZmxvd2NvbnRyb2wvZHViYm8tZmxvd2NvbnRyb2wtYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZmxvd2NvbnRyb2wvZmlsdGVyL0NpcmN1aXRCcmVha2VyRmlsdGVyLmphdmE=) | `0% <0%> (ø)` | | | ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1574/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubb
[GitHub] htynkn opened a new pull request #1575: [dubbo-1521]add java 9 in travis yml
htynkn opened a new pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575 ## What is the purpose of the change add java9 in ci ## Brief changelog use jacoco fix reflection issue ## Verifying this change ci pass coverage in codecov.io close #1521 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1575: [dubbo-1521]add java 9 in travis yml
codecov-io commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379710354 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1575?src=pr&el=h1) Report > Merging [#1575](https://codecov.io/gh/apache/incubator-dubbo/pull/1575?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `2.26%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/graphs/tree.svg?token=VnEIkiFQT0&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1575?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1575 +/- ## + Coverage 32.17% 34.43% +2.26% - Complexity0 3669+3669 Files 682 618 -64 Lines 3297230823-2149 Branches 6597 5445-1152 + Hits 1060810615 +7 + Misses2046818378-2090 + Partials 1896 1830 -66 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1575?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/com/alibaba/dubbo/common/utils/ReflectUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL1JlZmxlY3RVdGlscy5qYXZh) | `44.7% <100%> (+0.63%)` | `112 <0> (+112)` | :arrow_up: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L2Rpc3BhdGNoZXIvV3JhcHBlZENoYW5uZWxIYW5kbGVyLmphdmE=) | `30.3% <0%> (-12.13%)` | `2% <0%> (+2%)` | | | [...com/alibaba/dubbo/common/logger/LoggerFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2xvZ2dlci9Mb2dnZXJGYWN0b3J5LmphdmE=) | `28.26% <0%> (-7.16%)` | `3% <0%> (+3%)` | | | [...ing/transport/dispatcher/ChannelEventRunnable.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L2Rpc3BhdGNoZXIvQ2hhbm5lbEV2ZW50UnVubmFibGUuamF2YQ==) | `77.08% <0%> (-6.25%)` | `9% <0%> (+9%)` | | | [...ubbo/common/compiler/support/AbstractCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvQWJzdHJhY3RDb21waWxlci5qYXZh) | `45.45% <0%> (-4.55%)` | `3% <0%> (+3%)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-3.6%)` | `3% <0%> (+3%)` | | | [...ibaba/dubbo/rpc/protocol/thrift/ThriftInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdEludm9rZXIuamF2YQ==) | `56.81% <0%> (-3.19%)` | `5% <0%> (+5%)` | | | [.../com/alibaba/dubbo/rpc/filter/ExceptionFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0V4Y2VwdGlvbkZpbHRlci5qYXZh) | `19.04% <0%> (-2.39%)` | `2% <0%> (+2%)` | | | [...rpc/protocol/thrift/ext/MultiServiceProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L2V4dC9NdWx0aVNlcnZpY2VQcm9jZXNzb3IuamF2YQ==) | `12.76% <0%> (-2.13%)` | `3% <0%> (+3%)` | | | [...ubbo/remoting/transport/mina/MinaCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDb2RlY0FkYXB0ZXIuamF2YQ==) | `56.89% <0%> (-2.12%)` | `3% <0%> (+3%)` | | | ... and [199 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1575/diff?src=pr&el=tree-more) | | -- [Continue to
[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379713035 @suclogger I know it's quite annoying, but do you have any idea that once any changes applied to the working simple, it stops to work anymore. I'm able to run your official simples (provider vs consumer) like a charm, however, I'd like to tweak that simple to work with my own scenario, the thing is, no matter how do I follow the exact simple, it never work even just the class name changes, I'm frustrated. This is the exception: ``` com.alibaba.dubbo.remoting.RemotingException: Not found exported service: com.ont.palm.rpc.EchoService:1.0.0:12345 in [com.ont.messager.rpc.EchoService:1.0.0:12345], may be version or group mismatch , channel: consumer: /20.20.20.20:56722 --> provider: /20.20.20.20:12345, message:RpcInvocation [methodName=greet, parameterTypes=[], arguments=[], attachments={path=com.ont.palm.rpc.EchoService, input=153, dubbo=2.0.1, interface=com.ont.palm.rpc.EchoService, version=1.0.0}] at com.alibaba.dubbo.rpc.protocol.dubbo.DubboProtocol.getInvoker(DubboProtocol.java:202) at com.alibaba.dubbo.rpc.protocol.dubbo.DubboProtocol$1.reply(DubboProtocol.java:73) at com.alibaba.dubbo.remoting.exchange.support.header.HeaderExchangeHandler.handleRequest(HeaderExchangeHandler.java:96) at com.alibaba.dubbo.remoting.exchange.support.header.HeaderExchangeHandler.received(HeaderExchangeHandler.java:168) at com.alibaba.dubbo.remoting.transport.DecodeHandler.received(DecodeHandler.java:50) at com.alibaba.dubbo.remoting.transport.dispatcher.ChannelEventRunnable.run(ChannelEventRunnable.java:79) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ] with root cause ``` My provider and its interface: ![image](https://user-images.githubusercontent.com/7279067/38493997-ced8eb52-3c26-11e8-8b45-a1927a9c3743.png) ![image](https://user-images.githubusercontent.com/7279067/38494006-d9b09584-3c26-11e8-8cb3-a216eee9b454.png) Configuration: ``` # Spring boot application spring.application.name = messager-provider-app server.port = 9090 # DemoService service version messager.service.version = 1.0.0 # Base packages to scan Dubbo Components (e.g @Service , @Reference) dubbo.scan.basePackages = com.ont.messager.rpc # Dubbo Config properties ## ApplicationConfig Bean dubbo.application.id = messager-provider dubbo.application.name = messager-provider #dubbo.application.qos.port=2 #dubbo.application.qos.enable=true ## ProtocolConfig Bean dubbo.protocol.id = dubbo dubbo.protocol.name = dubbo dubbo.protocol.port = 12345 dubbo.protocol.status = server ## RegistryConfig Bean dubbo.registry.id = my-registry dubbo.registry.address = N/A ``` My consumer: ![image](https://user-images.githubusercontent.com/7279067/38494034-fa3ba7a8-3c26-11e8-953f-b1f9781e802c.png) ``` # Spring boot application spring.application.name = dubbo-consumer-demo server.port = 8080 management.server.port = 8081 # DemoService service version messager.service.version = 1.0.0 # Dubbo Config properties ## ApplicationConfig Bean dubbo.application.id = dubbo-consumer-demo dubbo.application.name = dubbo-consumer-demo ## Legacy QOS Config dubbo.qos.port = 3 ## ProtocolConfig Bean dubbo.protocol.id = dubbo dubbo.protocol.name = dubbo dubbo.protocol.port = 12345 # Dubbo Endpoint (default status is disable) endpoints.dubbo.enabled = true ``` Any idea? Thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed pull request #1572: remove the method with the same function but the different name in Ne…
beiwei30 closed pull request #1572: remove the method with the same function but the different name in Ne… URL: https://github.com/apache/incubator-dubbo/pull/1572 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/logger/support/FailsafeLogger.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/logger/support/FailsafeLogger.java index 858a4e085f..b964693906 100644 --- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/logger/support/FailsafeLogger.java +++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/logger/support/FailsafeLogger.java @@ -37,7 +37,7 @@ public void setLogger(Logger logger) { } private String appendContextMessage(String msg) { -return " [DUBBO] " + msg + ", dubbo version: " + Version.getVersion() + ", current host: " + NetUtils.getLogHost(); +return " [DUBBO] " + msg + ", dubbo version: " + Version.getVersion() + ", current host: " + NetUtils.getLocalHost(); } public void trace(String msg, Throwable e) { diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/NetUtils.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/NetUtils.java index 5295831632..ee79de4279 100644 --- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/NetUtils.java +++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/NetUtils.java @@ -182,11 +182,6 @@ public static InetAddress getLocalAddress() { return localAddress; } -public static String getLogHost() { -InetAddress address = getLocalAddress(); -return address == null ? LOCALHOST : address.getHostAddress(); -} - private static InetAddress getLocalAddress0() { InetAddress localAddress = null; try { This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kimmking commented on issue #1571: Is there any deadline to release a version?
kimmking commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379726363 @mercyblitz This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -org.codehaus.mojo -cobertura-maven-plugin -${maven_cobertura_version} - - -html -xml - - - +org.jacoco +jacoco-maven-plugin +${maven_jacoco_version} Review comment: 从 cobertura换成了jacoco了? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -org.codehaus.mojo -cobertura-maven-plugin -${maven_cobertura_version} - - -html -xml - - - +org.jacoco +jacoco-maven-plugin +${maven_jacoco_version} Review comment: jacoco instead of cobertura?** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -org.codehaus.mojo -cobertura-maven-plugin -${maven_cobertura_version} - - -html -xml - - - +org.jacoco +jacoco-maven-plugin +${maven_jacoco_version} Review comment: cobertura instead of jacoco? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #1568: Extension: Eager Thread Pool
codecov-io commented on issue #1568: Extension: Eager Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `57.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1568 +/- ## == + Coverage 32.17% 32.25% +0.08% == Files 682 685 +3 Lines 3297233019 +47 Branches 6597 6603 +6 == + Hits1060810650 +42 + Misses 2046820464 -4 - Partials 1896 1905 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...eadpool/support/eager/EagerThreadPoolExecutor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2xFeGVjdXRvci5qYXZh) | `43.47% <43.47%> (ø)` | | | [...bbo/common/threadpool/support/eager/TaskQueue.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9UYXNrUXVldWUuamF2YQ==) | `56.25% <56.25%> (ø)` | | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <90%> (ø)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `73.14% <0%> (-2.78%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `38% <0%> (-0.46%)` | :arrow_down: | | [.../java/com/alibaba/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05ldFV0aWxzLmphdmE=) | `15.9% <0%> (+0.23%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1568/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=footer). Last update [497803c...ec25e88](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitH b] htynkn commented on a change in p ll req est #1575: [d bbo-1521]add java 9 in travis yml
htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180079840 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -org.codehaus.mojo -cobertura-maven-plugin -${maven_cobertura_version} - - -html -xml - - - +org.jacoco +jacoco-maven-plugin +${maven_jacoco_version} Review comment: @kimmking yes, this pr is using `jacoco`. `cobertura` is no longer active since 2015. There is no support for java9 and higher version. so in order to support java9 and even java10, we must try another tool to replace `cobertura` `jacoco` is a good choice here: + jacoco use agent to capture test coverage, it's more quick + jacoco has a active team and also it support java9 and java10 + jacoco has lots of users in community. for example, gradle has built-in support for jacoco This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 When you have tested the program error or the test case doesn't pass, will the CI process terminate? @htynkn This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 Have tested when the program error or the test case doesn't pass, will the CI process terminate? @htynkn This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 Have you tested when the program error or the test case doesn't pass, will the CI process terminate? @htynkn This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed pull request #1568: Extension: Eager Thread Pool
beiwei30 closed pull request #1568: Extension: Eager Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPool.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPool.java new file mode 100644 index 00..eb4e1f3feb --- /dev/null +++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPool.java @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.dubbo.common.threadpool.support.eager; + +import com.alibaba.dubbo.common.Constants; +import com.alibaba.dubbo.common.URL; +import com.alibaba.dubbo.common.threadpool.ThreadPool; +import com.alibaba.dubbo.common.threadpool.support.AbortPolicyWithReport; +import com.alibaba.dubbo.common.utils.NamedThreadFactory; + +import java.util.concurrent.Executor; +import java.util.concurrent.TimeUnit; + +/** + * EagerThreadPool + * When the core threads are all in busy, + * create new thread instead of putting task into blocking queue. + */ +public class EagerThreadPool implements ThreadPool { + +@Override +public Executor getExecutor(URL url) { +String name = url.getParameter(Constants.THREAD_NAME_KEY, Constants.DEFAULT_THREAD_NAME); +int cores = url.getParameter(Constants.CORE_THREADS_KEY, Constants.DEFAULT_CORE_THREADS); +int threads = url.getParameter(Constants.THREADS_KEY, Integer.MAX_VALUE); +int queues = url.getParameter(Constants.QUEUES_KEY, Constants.DEFAULT_QUEUES); +int alive = url.getParameter(Constants.ALIVE_KEY, Constants.DEFAULT_ALIVE); + +// init queue and executor +TaskQueue taskQueue = new TaskQueue(queues <= 0 ? 1 : queues); +EagerThreadPoolExecutor executor = new EagerThreadPoolExecutor(cores, +threads, +alive, +TimeUnit.MILLISECONDS, +taskQueue, +new NamedThreadFactory(name, true), +new AbortPolicyWithReport(name, url)); +taskQueue.setExecutor(executor); +return executor; +} +} diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolExecutor.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolExecutor.java new file mode 100644 index 00..47f84c5279 --- /dev/null +++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolExecutor.java @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.dubbo.common.threadpool.support.eager; + +import java.util.concurrent.RejectedExecutionHandler; +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.RejectedExecutionException; +import java.util.concurrent.atomic.AtomicInteger; + +/** + * EagerThreadPoolExecutor + */ +public class EagerThreadPoolExecutor extends ThreadPoolExecutor { + +/** + * task count + */ +pri
[GitHub] beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters
beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r180152425 ## File path: dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java ## @@ -92,6 +93,7 @@ public void send() { long maxOutput = numbers[7]; long maxElapsed = numbers[8]; long maxConcurrent = numbers[9]; +String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL); Review comment: sounds a reasonable data to collect, let me think about it more. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0?
suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379813389 @neesonqk As far as I can see, maybe you didn't start provider before your try to consume? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type
zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180157548 ## File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extension/SpringExtensionFactory.java ## @@ -47,6 +52,24 @@ public static void removeApplicationContext(ApplicationContext context) { } } } + +if (logger.isDebugEnabled()) { +logger.debug("No spring extension(bean) named:" + name + ", type:" + type.getName() + " found. Will try to get bean by type only."); +} + +for (ApplicationContext context : contexts) { +try { +return context.getBean(type); Review comment: We should consider multiple matching conditions for the same interface type. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379833720 @suclogger I'm very sure that I've started the provider ahead of the consumer. I'll try to reproduce the same problem from your official simples and tweat there, if encountered the same problem, I'll post up here tmr. Thank you and much appreciated! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] htynkn commented on issue #1575: [dubbo-1521]add java 9 in travis yml
htynkn commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379938704 @lovepoem please refer this build: https://travis-ci.org/diamondblack/incubator-dubbo If test fail, CI will fail too. logs here: https://api.travis-ci.org/v3/job/364388877/log.txt This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chickenlj opened a new issue #101: Better use the newest dubbo 2.6.x version and only depend on necessary modules.
chickenlj opened a new issue #101: Better use the newest dubbo 2.6.x version and only depend on necessary modules. URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/101 1. use the newest 2.6.x dubbo version 2. Depend on necessary modules instead of a fat jar. For example: ```xml com.alibaba dubbo-config-api ${project.parent.version} ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379944759 Look good to me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] levin950825 opened a new issue #1576: When to publish the next release
levin950825 opened a new issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed issue #1510: dubbo monitor missing parameters
beiwei30 closed issue #1510: dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/issues/1510 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed pull request #1407: [Dubbo-1510] dubbo monitor missing parameters
beiwei30 closed pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java index 9d51517ca5..835daedabc 100644 --- a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java +++ b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java @@ -41,6 +41,8 @@ private String version; +private String interval; + // customized parameters private Map parameters; @@ -123,4 +125,12 @@ public void setDefault(Boolean isDefault) { this.isDefault = isDefault; } +public void setInterval(String interval){ +this.interval = interval; +} + +public String getInterval(){ +return interval; +} + } \ No newline at end of file diff --git a/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd b/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd index 1ae252a880..e21b1a51db 100644 --- a/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd +++ b/dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd @@ -574,6 +574,11 @@ + + + + + diff --git a/dubbo-monitor/dubbo-monitor-api/src/main/java/com/alibaba/dubbo/monitor/support/MonitorFilter.java b/dubbo-monitor/dubbo-monitor-api/src/main/java/com/alibaba/dubbo/monitor/support/MonitorFilter.java index ebeb4ee8aa..679b25cd51 100644 --- a/dubbo-monitor/dubbo-monitor-api/src/main/java/com/alibaba/dubbo/monitor/support/MonitorFilter.java +++ b/dubbo-monitor/dubbo-monitor-api/src/main/java/com/alibaba/dubbo/monitor/support/MonitorFilter.java @@ -84,6 +84,8 @@ private void collect(Invoker invoker, Invocation invocation, Result result, S String application = invoker.getUrl().getParameter(Constants.APPLICATION_KEY); String service = invoker.getInterface().getName(); // service name String method = RpcUtils.getMethodName(invocation); // method name +String group = invoker.getUrl().getParameter(Constants.GROUP_KEY); +String version = invoker.getUrl().getParameter(Constants.VERSION_KEY); URL url = invoker.getUrl().getUrlParameter(Constants.MONITOR_KEY); Monitor monitor = monitorFactory.getMonitor(url); if (monitor == null) { @@ -121,7 +123,9 @@ private void collect(Invoker invoker, Invocation invocation, Result result, S MonitorService.ELAPSED, String.valueOf(elapsed), MonitorService.CONCURRENT, String.valueOf(concurrent), Constants.INPUT_KEY, input, -Constants.OUTPUT_KEY, output)); +Constants.OUTPUT_KEY, output, +Constants.GROUP_KEY, group, +Constants.VERSION_KEY, version)); } catch (Throwable t) { logger.error("Failed to monitor count service " + invoker.getUrl() + ", cause: " + t.getMessage(), t); } diff --git a/dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java b/dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java index 7393afed1a..b320492bd4 100644 --- a/dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java +++ b/dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java @@ -16,6 +16,7 @@ */ package com.alibaba.dubbo.monitor.dubbo; +import com.alibaba.dubbo.common.Constants; import com.alibaba.dubbo.common.URL; import com.alibaba.dubbo.common.logger.Logger; import com.alibaba.dubbo.common.logger.LoggerFactory; @@ -92,6 +93,7 @@ public void send() { long maxOutput = numbers[7]; long maxElapsed = numbers[8]; long maxConcurrent = numbers[9]; +String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL); // send statistics data URL url = statistics.getUrl() @@ -105,7 +107,8 @@ public void send() { MonitorService.MAX_INPUT, String.valueOf(maxInput), MonitorService.MAX_OUTPUT, String.valueOf(maxOutput), MonitorService.MAX_ELAPSED, String.valueOf(maxElapsed), -M
[GitHub] cnhaicao commented on issue #1523: dubbo多分支api依赖版本管理问题
cnhaicao commented on issue #1523: dubbo多分支api依赖版本管理问题 URL: https://github.com/apache/incubator-dubbo/issues/1523#issuecomment-379956932 Dubbo multi-branch api dependent version management issues According to the official recommendation, the public api project is extracted between the service provider and the service consumer. Both the service consumer and the service provider rely on this api project. When the dubbo-based microservice architecture is used, services are inevitably invoked. The problem that arises is that engineering depends on multiple api projects. We use jenkins to use all the api poll scm detection code changes when the API is automatically packaged to the internal network nexus PW. All service providers and consumers can rely on these api projects. When teams work together, it is inevitable to pull multiple branches for parallel development. At this point how to do API version dependency management? Assuming that there are branch api and rel two branches of the api may be modified, this time if the dev and rel branch api version number should not be distinguished, two branch api set a different version number, then dev / rel are Setting the poll scm to auto-negotiate nexus will inevitably lead to manual maintenance of the version number when the code is merged. Is there any other better way? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Is Spring Optional?
John, If you want to adapt dubbo into other DI framework, then you need to wire dubbo config API into this DI framework. I suggest you look into dubbo-config-api and dubbo-config-spring under https://github.com/apache/incubator-dubbo/tree/master/dubbo-config to understand how we integrate spring framework. Regards, -Ian. On Sun, Apr 8, 2018 at 11:33 PM, shang zonghai wrote: > Great , you are right ! Dubbo follows a similar ServiceLoader mechanism, > By default, the SPI implementation is looked up in the following order: > META-INF/dubbo/internal/ > META-INF/dubbo/ > META-INF/services/ > > Here is SPI com.alibaba.dubbo.container.Container file content: > spring=com.alibaba.dubbo.container.spring.SpringContainer > > You need to specify a name and corresponding implementation class name on > each line. > > yiji > > > > 在 2018年4月8日,23:24,John D. Ament 写道: > > > > Oh ok, so if I wanted a different one, do I just implement the interface, > > or are there other requirements? Many other frameworks leverage a > > META-INF/services ServiceLoader pattern. > > > > John > > > > On Sun, Apr 8, 2018 at 11:22 AM shang zonghai > > wrote: > > > >> The meaning of the SPI default use springContainer, allow custom > >> extensions. > >> > >> yiji > >> > >>> 在 2018年4月8日,23:18,John D. Ament 写道: > >>> > >>> Weird, because even that says spring > >>> > >> https://github.com/apache/incubator-dubbo/blob/master/ > dubbo-container/dubbo-container-api/src/main/java/ > com/alibaba/dubbo/container/Container.java#L24 > >>> > >>> But it's a step, let me play around with it a bit. > >>> > >>> John > >>> > >>> On Sun, Apr 8, 2018 at 10:36 AM shang zonghai > > >>> wrote: > >>> > > SPI: com.alibaba.dubbo.container.Container > > Default SpringContainer extends this API,The dubbo-config-spring > module > supports spring-related functions. > Dubbo design goals are highly scalable, allowing custom extensions to > support more DI containers. > > Kind regards, > yiji > > > > 在 2018年4月8日,22:27,John D. Ament 写道: > > > > Hi, > > > > Looking at dubbo, its very interesting. I was wondering though, is > Spring > > optional in Dubbo, or is it a required part to make Dubbo work? Is > >> there > > any SPI that could be used in Dubbo that would allow other DI > >> containers > to > > be used? > > > > John > > > >> > >> > >
[GitHub] beiwei30 commented on issue #1548: Where can I get the startup script for Dubbo
beiwei30 commented on issue #1548: Where can I get the startup script for Dubbo URL: https://github.com/apache/incubator-dubbo/issues/1548#issuecomment-379959237 There's no start.sh provided for dubbo application since the script varies depending on how you develop and deploy your dubbo provider/consumer. For the [demo](https://github.com/apache/incubator-dubbo/tree/master/dubbo-demo) we provide in dubbo project, you can either start it directly from your IDE or you can write the your own script similar like below if you prefer to start it from command line: ```sh java -classpath ${CLASSPATH} com.alibaba.dubbo.demo.consumer.Consumer ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed issue #1548: Where can I get the startup script for Dubbo
beiwei30 closed issue #1548: Where can I get the startup script for Dubbo URL: https://github.com/apache/incubator-dubbo/issues/1548 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 closed issue #1545: how to disable qos
beiwei30 closed issue #1545: how to disable qos URL: https://github.com/apache/incubator-dubbo/issues/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 commented on issue #1545: how to disable qos
beiwei30 commented on issue #1545: how to disable qos URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379960046 @VanXD https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.1/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ApplicationConfig.java#L224 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1574: circuitBreaker
ralf0131 commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379685516 1. The CI has failed. 2. This is a significant change, you need to sign the SGA[1] before merging. [1] https://www.apache.org/licenses/#grants This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diecui1202 commented on issue #1500: not support java 10
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379962207 @hank-whu I run this two server/client demo on my mac, and it's all ok. ![image](https://user-images.githubusercontent.com/1152291/38534599-889c61ce-3cb1-11e8-8a07-1d6dfa85204d.png) ![image](https://user-images.githubusercontent.com/1152291/38534619-9757e7c4-3cb1-11e8-958c-b76ffa80d937.png) ![image](https://user-images.githubusercontent.com/1152291/38534631-a2c4e008-3cb1-11e8-89e0-bfc2ac25ee7d.png) And my maven version is 3.3.9, my java version is: ``` ➜ ~ java -version java version "10" 2018-03-20 Java(TM) SE Runtime Environment 18.3 (build 10+46) Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10+46, mixed mode) ``` So please check your maven and jdk10 env. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diecui1202 commented on issue #1500: not support java 10
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379962207 @hank-whu I run this two server/client demo with Dubbo 2.6.1 on my mac, and it's all ok. ![image](https://user-images.githubusercontent.com/1152291/38534599-889c61ce-3cb1-11e8-8a07-1d6dfa85204d.png) ![image](https://user-images.githubusercontent.com/1152291/38534619-9757e7c4-3cb1-11e8-958c-b76ffa80d937.png) ![image](https://user-images.githubusercontent.com/1152291/38534631-a2c4e008-3cb1-11e8-89e0-bfc2ac25ee7d.png) And my maven version is 3.3.9, my java version is: ``` ➜ ~ java -version java version "10" 2018-03-20 Java(TM) SE Runtime Environment 18.3 (build 10+46) Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10+46, mixed mode) ``` So please check your maven and jdk10 env. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1576: When to publish the next release
ralf0131 commented on issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576#issuecomment-379962808 Hi, we are going to discuss the release schedule in the mailing list this week. Please [subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and you will get notified. Since this is the first Apache release, it will take some time to follow the Apache release policy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 closed issue #1576: When to publish the next release
ralf0131 closed issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 closed issue #1571: Is there any deadline to release a version?
ralf0131 closed issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1571: Is there any deadline to release a version?
ralf0131 commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379962924 Hi, we are going to discuss the release schedule in the mailing list this week. Please [subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and you will get notified. Since this is the first Apache release, it will take some time to follow the Apache release policy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1500: not support java 10
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379964569 @diecui1202 Please use text instead of pic as much as possible. Text is more search engine friendly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 commented on issue #1500: not support java 10
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379964708 Looks like this issue is not reproducible, I am closing this issue now. Feel free to reopen it if you can reproduce it later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ralf0131 closed issue #1500: not support java 10
ralf0131 closed issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fuyongde opened a new issue #102: Warning of `com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration`
fuyongde opened a new issue #102: Warning of `com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration` URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/102 It warned `Cannot enhance @Configuration bean definition 'com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration' since its singleton instance has been created too early. The typical cause is a non-static @Bean method with a BeanDefinitionRegistryPostProcessor return type: Consider declaring such methods as 'static'.` when I start up the project,it means you should make `com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration#serviceAnnotationBeanPostProcessor` as a static method. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lovepoem closed pull request #1575: [dubbo-1521]add java 9 in travis yml
lovepoem closed pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 101cb297a7..e774ec5681 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,12 +2,12 @@ language: java sudo: false # faster builds jdk: +- oraclejdk9 - oraclejdk8 - openjdk7 script: - travis_wait 30 mvn clean package -- travis_wait 30 mvn cobertura:cobertura after_success: - bash <(curl -s https://codecov.io/bash) diff --git a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java index 88f4516a00..f9a8bba0c0 100644 --- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java +++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, Map, Object> while (cls != null && cls != Object.class) { Field[] fields = cls.getDeclaredFields(); for (Field field : fields) { +if (field.isSynthetic()) { +continue; +} Object property = getEmptyObject(field.getType(), emptyInstances, level + 1); if (property != null) { try { diff --git a/pom.xml b/pom.xml index 066f75a493..f7bc44 100644 --- a/pom.xml +++ b/pom.xml @@ -111,10 +111,10 @@ 2.8.2 3.6.0 3.0.1 -2.7 3.0.0 6.1.26 3.0.0 +0.8.1 @@ -184,7 +184,6 @@ 2.7 3.1 3.0.1 -2.7 2.10.1 @@ -338,7 +337,7 @@ true once -${argline} +${argline} ${jacocoArgLine} @@ -422,16 +421,27 @@ -org.codehaus.mojo -cobertura-maven-plugin -${maven_cobertura_version} - - -html -xml - - - +org.jacoco +jacoco-maven-plugin +${maven_jacoco_version} + + +jacoco-initialize + +prepare-agent + + +jacocoArgLine + + + +jacoco-site +package + +report + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lovepoem closed issue #1521: Add java9 in CI build
lovepoem closed issue #1521: Add java9 in CI build URL: https://github.com/apache/incubator-dubbo/issues/1521 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180290615 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, Map, Object> while (cls != null && cls != Object.class) { Field[] fields = cls.getDeclaredFields(); for (Field field : fields) { +if (field.isSynthetic()) { Review comment: is it necessary to include this change? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lovepoem commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
lovepoem commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180290674 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, Map, Object> while (cls != null && cls != Object.class) { Field[] fields = cls.getDeclaredFields(); for (Field field : fields) { +if (field.isSynthetic()) { Review comment: What's the purpose to add this filter? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fuyongde opened a new pull request #103: fix issues #102
fuyongde opened a new pull request #103: fix issues #102 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180294062 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, Map, Object> while (cls != null && cls != Object.class) { Field[] fields = cls.getDeclaredFields(); for (Field field : fields) { +if (field.isSynthetic()) { Review comment: @lovepoem @beiwei30 please refer to jacoco faq http://www.jacoco.org/jacoco/trunk/doc/faq.html https://user-images.githubusercontent.com/659135/38535943-f615402a-3cb8-11e8-8dd1-6734ca9ca9ac.png";> We need this change to skip $jacocoData, otherwise test will fail. Also skip synthetic field in reflection is also a good practice. Refer to those two links: + https://docs.oracle.com/javase/tutorial/reflect/member/fieldModifiers.html + https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.8 According to the JVM Spec: "A class member that does not appear in the source code must be marked using a Synthetic attribute." Also, "The Synthetic attribute was introduced in JDK release 1.1 to support nested classes and interfaces." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lkj41110 opened a new pull request #1577: a
lkj41110 opened a new pull request #1577: a URL: https://github.com/apache/incubator-dubbo/pull/1577 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hank-whu commented on issue #1500: not support java 10
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379978154 @diecui1202 现在那两个项目 pom.xml 里的 dubbo 版本是 2.6.0,你把里面的版本修改为 2.6.1 了吗? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diecui1202 commented on issue #1500: not support java 10
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379978352 @hank-whu Yeah, I've changed it to 2.6.1 yet. @ralf0131 Ok, I got it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180301153 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, Map, Object> while (cls != null && cls != Object.class) { Field[] fields = cls.getDeclaredFields(); for (Field field : fields) { +if (field.isSynthetic()) { Review comment: sounds reasonable This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mercyblitz closed issue #1536: zookeeper 提供者问题?
mercyblitz closed issue #1536: zookeeper 提供者问题? URL: https://github.com/apache/incubator-dubbo/issues/1536 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diecui1202 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈
diecui1202 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈 URL: https://github.com/apache/incubator-dubbo/issues/1539#issuecomment-379981153 I think it's a mistake. I'll fix it today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hank-whu commented on issue #1500: not support java 10
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379981373 @diecui1202 我试了很多次,还是不行,你的 pom 文件可以贴上来吗? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] diecui1202 commented on issue #1500: not support java 10
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379981687 ``` http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> 4.0.0 benchmark.rpc dubbo-server round-2 jar dubbo-server http://maven.apache.org 1.9 1.9 UTF-8 round-2 2.6.1 0.42 benchmark.rpc benchmark-base ${version.benchmark-base} com.alibaba dubbo ${version.dubbo} de.javakaffee kryo-serializers ${version.javakaffee} junit junit 4.12 test org.apache.maven.plugins maven-compiler-plugin 3.7.0 lib 9 9 UTF-8 org.apache.maven.plugins maven-resources-plugin 3.0.0 UTF-8 maven-assembly-plugin 3.1.0 jar-with-dependencies benchmark.rpc.Server make-assembly package single src/main/resources ``` I just change version.dubbo to 2.6.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Suggestion] PR failing if test coverage went down
hey team, In pull request template(https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md), this is one item to ask all pr to "Write necessary unit-test to verify your logic correction" Codecov has feature to fail PR if test coverage went down. Which means for any pull request, if it add some code without any unit test, the PR will fail This can help to increase test coverage. Any thoughts? Relate links: 1.https://docs.codecov.io/docs/commit-status 2.https://github.com/codecov/support/issues/351
Re: [Suggestion] PR failing if test coverage went down
Hi, Thanks for the suggestion. I generally agree with the idea that we should prevent a pull request to be merged if the code coverage gets lower. But my concern is the code coverage might have a minor drop even when just fixing typo[1], which makes confused. Unless we can figure it out, or I think it will be better if we can set a threshold. For example, if the code coverage drops >=0.1%, prevent the PR to be merged. [1] https://github.com/apache/incubator-dubbo/pull/1562 On Tue, Apr 10, 2018 at 10:21 AM, htynkn wrote: > hey team, > > > In pull request > template(https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md), > this is one item to ask all pr to > > >"Write necessary unit-test to verify your logic correction" > > > Codecov has feature to fail PR if test coverage went down. Which means for > any pull request, if it add some code without any unit test, the PR will fail > This can help to increase test coverage. > > > Any thoughts? > > > Relate links: > 1.https://docs.codecov.io/docs/commit-status > 2.https://github.com/codecov/support/issues/351 > -- Best Regards! Huxing