[DISCUSS] Provide official docker image for dubbo-admin

2019-03-12 Thread Huxing Zhang
Hi community,

I've see a dubbo-admin docker image[1], which is maintained by one of
the Dubbo PPMC. To some extend this might be a violation of ASF
distribution policy - we should always distribute the source/binary
with the approval of Dubbo PPMC.

It looks like there is quite a lot of downloads, I think it is better
to publish the official docker image instead.

How do you think?

[1] https://hub.docker.com/r/htynkn/dubbo-admin

-- 
Best Regards!
Huxing


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-12 Thread YunKun Huang
+1 to provide official docker image.

With official docker image and Play With Docker[1] website, people can easily 
try dubbo admin online[2]

I'm the owner of https://hub.docker.com/r/htynkn/dubbo-admin. not sure if I can 
transfer for this image so we can keep download history data?

[1] http://play-with-docker.com/
[2] 
http://play-with-docker.com/?stack=https://raw.githubusercontent.com/htynkn/dockerfiles/master/dubbo-admin/stack.yml

On 2019/03/12 15:41:52, Huxing Zhang  wrote: 
> Hi community,
> 
> I've see a dubbo-admin docker image[1], which is maintained by one of
> the Dubbo PPMC. To some extend this might be a violation of ASF
> distribution policy - we should always distribute the source/binary
> with the approval of Dubbo PPMC.
> 
> It looks like there is quite a lot of downloads, I think it is better
> to publish the official docker image instead.
> 
> How do you think?
> 
> [1] https://hub.docker.com/r/htynkn/dubbo-admin
> 
> -- 
> Best Regards!
> Huxing
> 


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-12 Thread Justin Mclean
Hi,

> I've see a dubbo-admin docker image[1], which is maintained by one of
> the Dubbo PPMC. To some extend this might be a violation of ASF
> distribution policy - we should always distribute the source/binary
> with the approval of Dubbo PPMC.

I can see that this docker image is providing unreleased code the general 
public that’s probably not the best idea. I think it would be better if this 
docker image only pointed to the latest official release. There are some 
branding and trademark issues here as well.

Thanks,
Justin

Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-14 Thread Ian Luo
or at least we can bundle a docker-compose.yaml in dubbo admin project.

-Ian.

On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean 
wrote:

> Hi,
>
> > I've see a dubbo-admin docker image[1], which is maintained by one of
> > the Dubbo PPMC. To some extend this might be a violation of ASF
> > distribution policy - we should always distribute the source/binary
> > with the approval of Dubbo PPMC.
>
> I can see that this docker image is providing unreleased code the general
> public that’s probably not the best idea. I think it would be better if
> this docker image only pointed to the latest official release. There are
> some branding and trademark issues here as well.
>
> Thanks,
> Justin


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-14 Thread YunKun Huang
I think only provide a docker-compose file in project is not a good idea, this 
still require user to compile and build image in their local. It will spend 
many time since it require npm dependencies and maven dependencies.

As Justin's suggestion, we can provide official docker image in docker-hub with 
release version only, if user want to latest code, their can use dockerfile to 
build by themselves.

On 2019/03/14 07:48:08, Ian Luo  wrote: 
> or at least we can bundle a docker-compose.yaml in dubbo admin project.
> 
> -Ian.
> 
> On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean 
> wrote:
> 
> > Hi,
> >
> > > I've see a dubbo-admin docker image[1], which is maintained by one of
> > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > distribution policy - we should always distribute the source/binary
> > > with the approval of Dubbo PPMC.
> >
> > I can see that this docker image is providing unreleased code the general
> > public that’s probably not the best idea. I think it would be better if
> > this docker image only pointed to the latest official release. There are
> > some branding and trademark issues here as well.
> >
> > Thanks,
> > Justin
> 


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-14 Thread Minxuan Zhuang
there's a pull request with some discussions:
https://github.com/apache/incubator-dubbo-admin/pull/51

On Fri, Mar 15, 2019 at 2:07 PM YunKun Huang  wrote:

> I think only provide a docker-compose file in project is not a good idea,
> this still require user to compile and build image in their local. It will
> spend many time since it require npm dependencies and maven dependencies.
>
> As Justin's suggestion, we can provide official docker image in docker-hub
> with release version only, if user want to latest code, their can use
> dockerfile to build by themselves.
>
> On 2019/03/14 07:48:08, Ian Luo  wrote:
> > or at least we can bundle a docker-compose.yaml in dubbo admin project.
> >
> > -Ian.
> >
> > On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean  >
> > wrote:
> >
> > > Hi,
> > >
> > > > I've see a dubbo-admin docker image[1], which is maintained by one of
> > > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > > distribution policy - we should always distribute the source/binary
> > > > with the approval of Dubbo PPMC.
> > >
> > > I can see that this docker image is providing unreleased code the
> general
> > > public that’s probably not the best idea. I think it would be better if
> > > this docker image only pointed to the latest official release. There
> are
> > > some branding and trademark issues here as well.
> > >
> > > Thanks,
> > > Justin
> >
>


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-14 Thread Justin Mclean
Hi,

There is also an infra supported docker user [1] you might consider moving the 
container to that?

Thanks,
Justin

1. https://hub.docker.com/u/apache




Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-15 Thread Huxing Zhang
Hi Justin,

I always got your email in the gmail spam folder... Not sure how.

On Fri, Mar 15, 2019 at 2:24 PM Justin Mclean  wrote:
>
> Hi,
>
> There is also an infra supported docker user [1] you might consider moving 
> the container to that?

+1 to publish the docker image with Apache account.

Is there any guide of how to achieve that? Shall I need to file a JIRA
ticket for that?

>
> Thanks,
> Justin
>
> 1. https://hub.docker.com/u/apache
>
>


-- 
Best Regards!
Huxing


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-03-18 Thread Ian Luo
Then let's provider the official image. The request from the users is
always priority one we should consider.

-Ian.

On Fri, Mar 15, 2019 at 2:07 PM YunKun Huang  wrote:

> I think only provide a docker-compose file in project is not a good idea,
> this still require user to compile and build image in their local. It will
> spend many time since it require npm dependencies and maven dependencies.
>
> As Justin's suggestion, we can provide official docker image in docker-hub
> with release version only, if user want to latest code, their can use
> dockerfile to build by themselves.
>
> On 2019/03/14 07:48:08, Ian Luo  wrote:
> > or at least we can bundle a docker-compose.yaml in dubbo admin project.
> >
> > -Ian.
> >
> > On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean  >
> > wrote:
> >
> > > Hi,
> > >
> > > > I've see a dubbo-admin docker image[1], which is maintained by one of
> > > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > > distribution policy - we should always distribute the source/binary
> > > > with the approval of Dubbo PPMC.
> > >
> > > I can see that this docker image is providing unreleased code the
> general
> > > public that’s probably not the best idea. I think it would be better if
> > > this docker image only pointed to the latest official release. There
> are
> > > some branding and trademark issues here as well.
> > >
> > > Thanks,
> > > Justin
> >
>


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-04-04 Thread YunKun Huang
I would like to work on this stuff and I already did some research at 
https://issues.apache.org/

Looks like there are two way to do this.
 1. ask push permission and push image to dockerhub
 2. ask infra team to add auto build rule to create image in dockerhub

But as first step, we need a dubbo repo in dockerhub. I already raised a ticket 
for infra team to request dubbo dockerhub repo. 
https://issues.apache.org/jira/browse/INFRA-18167

After I figure out whole process to do this, I will summary a document in blog 
or wiki.

Regards,
Yunkun Huang

On 2019/03/18 13:28:28, Ian Luo  wrote: 
> Then let's provider the official image. The request from the users is
> always priority one we should consider.
> 
> -Ian.
> 
> On Fri, Mar 15, 2019 at 2:07 PM YunKun Huang  wrote:
> 
> > I think only provide a docker-compose file in project is not a good idea,
> > this still require user to compile and build image in their local. It will
> > spend many time since it require npm dependencies and maven dependencies.
> >
> > As Justin's suggestion, we can provide official docker image in docker-hub
> > with release version only, if user want to latest code, their can use
> > dockerfile to build by themselves.
> >
> > On 2019/03/14 07:48:08, Ian Luo  wrote:
> > > or at least we can bundle a docker-compose.yaml in dubbo admin project.
> > >
> > > -Ian.
> > >
> > > On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean  > >
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > > I've see a dubbo-admin docker image[1], which is maintained by one of
> > > > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > > > distribution policy - we should always distribute the source/binary
> > > > > with the approval of Dubbo PPMC.
> > > >
> > > > I can see that this docker image is providing unreleased code the
> > general
> > > > public that’s probably not the best idea. I think it would be better if
> > > > this docker image only pointed to the latest official release. There
> > are
> > > > some branding and trademark issues here as well.
> > > >
> > > > Thanks,
> > > > Justin
> > >
> >
> 


Re: [DISCUSS] Provide official docker image for dubbo-admin

2019-04-07 Thread Huxing Zhang
Nice to hear that!

On Fri, Apr 5, 2019 at 2:30 PM YunKun Huang  wrote:
>
> I would like to work on this stuff and I already did some research at 
> https://issues.apache.org/
>
> Looks like there are two way to do this.
>  1. ask push permission and push image to dockerhub
>  2. ask infra team to add auto build rule to create image in dockerhub
>
> But as first step, we need a dubbo repo in dockerhub. I already raised a 
> ticket for infra team to request dubbo dockerhub repo. 
> https://issues.apache.org/jira/browse/INFRA-18167
>
> After I figure out whole process to do this, I will summary a document in 
> blog or wiki.
>
> Regards,
> Yunkun Huang
>
> On 2019/03/18 13:28:28, Ian Luo  wrote:
> > Then let's provider the official image. The request from the users is
> > always priority one we should consider.
> >
> > -Ian.
> >
> > On Fri, Mar 15, 2019 at 2:07 PM YunKun Huang  wrote:
> >
> > > I think only provide a docker-compose file in project is not a good idea,
> > > this still require user to compile and build image in their local. It will
> > > spend many time since it require npm dependencies and maven dependencies.
> > >
> > > As Justin's suggestion, we can provide official docker image in docker-hub
> > > with release version only, if user want to latest code, their can use
> > > dockerfile to build by themselves.
> > >
> > > On 2019/03/14 07:48:08, Ian Luo  wrote:
> > > > or at least we can bundle a docker-compose.yaml in dubbo admin project.
> > > >
> > > > -Ian.
> > > >
> > > > On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean  > > >
> > > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > > I've see a dubbo-admin docker image[1], which is maintained by one 
> > > > > > of
> > > > > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > > > > distribution policy - we should always distribute the source/binary
> > > > > > with the approval of Dubbo PPMC.
> > > > >
> > > > > I can see that this docker image is providing unreleased code the
> > > general
> > > > > public that’s probably not the best idea. I think it would be better 
> > > > > if
> > > > > this docker image only pointed to the latest official release. There
> > > are
> > > > > some branding and trademark issues here as well.
> > > > >
> > > > > Thanks,
> > > > > Justin
> > > >
> > >
> >



-- 
Best Regards!
Huxing