htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180079840
##########
File path: pom.xml
##########
@@ -422,16 +421,27 @@
</configuration>
</plugin>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>cobertura-maven-plugin</artifactId>
- <version>${maven_cobertura_version}</version>
- <configuration>
- <formats>
- <format>html</format>
- <format>xml</format>
- </formats>
- <check/>
- </configuration>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <version>${maven_jacoco_version}</version>
Review comment:
@kimmking yes, this pr is using `jacoco`.
`cobertura` is no longer active since 2015. There is no support for java9
and higher version.
so in order to support java9 and even java10, we must try another tool to
replace `cobertura`
`jacoco` is a good choice here:
+ jacoco use agent to capture test coverage, it's more quick
+ jacoco has a active team and also it support java9 and java10
+ jacoco has lots of users in community. for example, gradle has built-in
support for jacoco
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
