[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-10 Thread GitBox 
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in 
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180315284
 
 

 ##
 File path: 
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java
 ##
 @@ -910,6 +910,9 @@ private static Object getEmptyObject(Class returnType, 
Map, Object>
 while (cls != null && cls != Object.class) {
 Field[] fields = cls.getDeclaredFields();
 for (Field field : fields) {
+if (field.isSynthetic()) {
 
 Review comment:
   class is also added synthetic checking?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox 
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in 
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273
 
 

 ##
 File path: pom.xml
 ##
 @@ -422,16 +421,27 @@
 
 
 
-org.codehaus.mojo
-cobertura-maven-plugin
-${maven_cobertura_version}
-
-
-html
-xml
-
-
-
+org.jacoco
+jacoco-maven-plugin
+${maven_jacoco_version}
 
 Review comment:
   cobertura instead of jacoco？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox 
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in 
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273
 
 

 ##
 File path: pom.xml
 ##
 @@ -422,16 +421,27 @@
 
 
 
-org.codehaus.mojo
-cobertura-maven-plugin
-${maven_cobertura_version}
-
-
-html
-xml
-
-
-
+org.jacoco
+jacoco-maven-plugin
+${maven_jacoco_version}
 
 Review comment:
   jacoco instead of cobertura？**


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox 
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in 
travis yml
URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273
 
 

 ##
 File path: pom.xml
 ##
 @@ -422,16 +421,27 @@
 
 
 
-org.codehaus.mojo
-cobertura-maven-plugin
-${maven_cobertura_version}
-
-
-html
-xml
-
-
-
+org.jacoco
+jacoco-maven-plugin
+${maven_jacoco_version}
 
 Review comment:
   从 cobertura换成了jacoco了？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services