[GitHub] takeseem commented on issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232)

2018-04-18 Thread GitBox
takeseem commented on issue #1609: incomplete: Fix hessian2 serialized short, 
byte is converted to int bug (#1232)
URL: 
https://github.com/apache/incubator-dubbo/issues/1609#issuecomment-382290066
 
 
   今天仔细看下代码,hessian1确实没有用了,建议从hessian-lite中移除。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] takeseem commented on issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232)

2018-04-16 Thread GitBox
takeseem commented on issue #1609: incomplete: Fix hessian2 serialized short, 
byte is converted to int bug (#1232)
URL: 
https://github.com/apache/incubator-dubbo/issues/1609#issuecomment-381493197
 
 
   dubbo作为一个严谨的框架,既然hessian1未废弃,就应当保持一致性,因为其他人可能在使用。
   
   这是我第3次看到dubbo的master,合并到主干时未考虑兼容性。
   
   建议先完成:功能性审核,再讨论代码样式和规范。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services