[jira] [Commented] (EAGLE-355) UI advanced policy expression can't parse

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365646#comment-15365646
 ] 

ASF GitHub Bot commented on EAGLE-355:
--

GitHub user zombieJ opened a pull request:

https://github.com/apache/incubator-eagle/pull/251

EAGLE-355 fix advanced sql parse logic

Adjust the logic of expression parse

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zombieJ/incubator-eagle branch-0.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #251


commit 89bd717e53bd5f06b021ada36d7a00ce46a736ba
Author: jiljiang 
Date:   2016-07-07T05:22:24Z

fix advanced sql parse logic




> UI advanced policy expression can't parse
> -
>
> Key: EAGLE-355
> URL: https://issues.apache.org/jira/browse/EAGLE-355
> Project: Eagle
>  Issue Type: Bug
>Reporter: Jilin, Jiang
>Assignee: Jilin, Jiang
>Priority: Critical
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle pull request #251: EAGLE-355 fix advanced sql parse logic

[zombieJ]

GitHub user zombieJ opened a pull request:

https://github.com/apache/incubator-eagle/pull/251

EAGLE-355 fix advanced sql parse logic

Adjust the logic of expression parse

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zombieJ/incubator-eagle branch-0.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #251


commit 89bd717e53bd5f06b021ada36d7a00ce46a736ba
Author: jiljiang 
Date:   2016-07-07T05:22:24Z

fix advanced sql parse logic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (EAGLE-355) UI advanced policy expression can't parse

[Jilin, Jiang (JIRA)]

Jilin, Jiang created EAGLE-355:
--

 Summary: UI advanced policy expression can't parse
 Key: EAGLE-355
 URL: https://issues.apache.org/jira/browse/EAGLE-355
 Project: Eagle
  Issue Type: Bug
Reporter: Jilin, Jiang
Assignee: Jilin, Jiang
Priority: Critical






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release: Apache Eagle 0.4.0-incubating (Release Candidate 2)

[Liangfei.Su]

+1 (not-binding)

* Downloaded & built successfully with Hotspot JDK1.7 on OSX
* Signature checked
* Apache rat:check passed


Ralph


On Thu, Jul 7, 2016 at 2:23 AM, Julian Hyde  wrote:

> +1 (binding)
>
> * Downloaded & built successfully on JDK 1.7 OS X
> * Checked license, notice, signatures
> * Ran apache-rat:check, and it passed
> * Checked that release matches tag at github
>
> * I saw you added ‘brew install node’ to README.md - thanks!
> * I saw that CHANGELOG.txt now contains previous releases — good idea
> * I saw that you fixed the branding in CHANGELOG.txt - thanks!
> * I noticed that you renamed the directory to
> apache-eagle-0.4.0-incubating — thanks!
>
> Nice work.
>
> Julian
>
>
>
> > On Jul 5, 2016, at 11:04 PM, Michael Wu  wrote:
> >
> > Hi all,
> >
> > This is a release vote for Apache Eagle, version 0.4.0-incubating,
> release
> > candidate 2.
> >
> > Highlighted changes in this release are as the following:
> >  * JBDC Metadata Storage Extension
> >  * Topology management in remote mode including start/stop/status
> > operations
> >  * Auditlogparser for MapR's audit log
> >  * Oozie auditlog integration for Oozie security monitoring
> >  * Add applicaiton "maprFSAuditLog"
> >  * Refactor bin/eagle-sandbox-starter.sh to make it easier to use
> >
> > Thanks to everyone who has contributed to this release.
> >
> > Here's the release note:
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.4
> >
> > The artifacts to be voted on are located at:
> >
> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.4.0-incubating-rc2/
> >
> > The commit to be voted upon:
> > *
> https://github.com/apache/incubator-eagle/commit/23d3ca604a37ccb89d7a95e5c75cfba651673b2a
> > <
> https://github.com/apache/incubator-eagle/commit/23d3ca604a37ccb89d7a95e5c75cfba651673b2a
> >*
> >
> > Release tag is:
> > *
> https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc2
> > <
> https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc2
> >*
> >
> > Release artifacts are signed with the following key:
> > http://people.apache.org/keys/committer/mw.asc
> >
> > The hashes of the artifacts are as follows:
> > apache-eagle-0.4.0-incubating-src-rc2.tar.gz.md5:
> > 0a78ed6c36ba57194f6721a8d6bae6f4
> > apache-eagle-0.4.0-incubating-src-rc2.tar.gz.sha1:
> > f59b3d7d894181eb2019bb55f4cf6079a47339eb
> >
> > Please vote on releasing this package as: Apache Eagle 0.4.0-incubating.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> least
> > three +1 PPMC votes are cast.
> >
> > [ ] +1 Release this Apache Eagle 0.4.0-incubating Release Candidate 2.
> >
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> >
> > [ ] -1 Do not release this package because...
> >
> >
> > Thanks.
> >
> > Michael
>
>

[GitHub] incubator-eagle pull request #250: Rebase code base

[RalphSu]

Github user RalphSu closed the pull request at:

https://github.com/apache/incubator-eagle/pull/250


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #248: a testing PR, don't delete it

[anyway1021]

Github user anyway1021 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #248: a testing PR, don't delete it

[anyway1021]

Github user anyway1021 commented on the issue:

https://github.com/apache/incubator-eagle/pull/248
  
Sure, I'll close it now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #250: Rebase code base

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/250
  
Please close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #250: Rebase code base

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/250
  
Merged into `develop` branch. As to following problems caused by the PR, 
will refactor on apache repo directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (EAGLE-354) links in alert email don't work

[Jing Ge (JIRA)]

Jing Ge created EAGLE-354:
-

 Summary: links in alert email don't work
 Key: EAGLE-354
 URL: https://issues.apache.org/jira/browse/EAGLE-354
 Project: Eagle
  Issue Type: Bug
Reporter: Jing Ge
Assignee: Hao Chen


clicking View Alert/Policy Details on Eagle Web don't show the correct pages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (EAGLE-353) Alert Email should contain the definition and description of the policy

[Jing Ge (JIRA)]

Jing Ge created EAGLE-353:
-

 Summary: Alert Email should contain the definition and description 
of the policy
 Key: EAGLE-353
 URL: https://issues.apache.org/jira/browse/EAGLE-353
 Project: Eagle
  Issue Type: Improvement
Reporter: Jing Ge
Assignee: Hao Chen


As  a customer of Eagle, when I got an alert email, I want to understand the 
purpose of the alert policy without visiting the eagle web page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release: Apache Eagle 0.4.0-incubating (Release Candidate 2)

[Julian Hyde]

+1 (binding)

* Downloaded & built successfully on JDK 1.7 OS X
* Checked license, notice, signatures
* Ran apache-rat:check, and it passed
* Checked that release matches tag at github

* I saw you added ‘brew install node’ to README.md - thanks!
* I saw that CHANGELOG.txt now contains previous releases — good idea
* I saw that you fixed the branding in CHANGELOG.txt - thanks!
* I noticed that you renamed the directory to apache-eagle-0.4.0-incubating — 
thanks!

Nice work.

Julian



> On Jul 5, 2016, at 11:04 PM, Michael Wu  wrote:
> 
> Hi all,
> 
> This is a release vote for Apache Eagle, version 0.4.0-incubating, release
> candidate 2.
> 
> Highlighted changes in this release are as the following:
>  * JBDC Metadata Storage Extension
>  * Topology management in remote mode including start/stop/status
> operations
>  * Auditlogparser for MapR's audit log
>  * Oozie auditlog integration for Oozie security monitoring
>  * Add applicaiton "maprFSAuditLog"
>  * Refactor bin/eagle-sandbox-starter.sh to make it easier to use
> 
> Thanks to everyone who has contributed to this release.
> 
> Here's the release note:
> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.4
> 
> The artifacts to be voted on are located at:
> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.4.0-incubating-rc2/
> 
> The commit to be voted upon:
> *https://github.com/apache/incubator-eagle/commit/23d3ca604a37ccb89d7a95e5c75cfba651673b2a
> *
> 
> Release tag is:
> *https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc2
> *
> 
> Release artifacts are signed with the following key:
> http://people.apache.org/keys/committer/mw.asc
> 
> The hashes of the artifacts are as follows:
> apache-eagle-0.4.0-incubating-src-rc2.tar.gz.md5:
> 0a78ed6c36ba57194f6721a8d6bae6f4
> apache-eagle-0.4.0-incubating-src-rc2.tar.gz.sha1:
> f59b3d7d894181eb2019bb55f4cf6079a47339eb
> 
> Please vote on releasing this package as: Apache Eagle 0.4.0-incubating.
> 
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PPMC votes are cast.
> 
> [ ] +1 Release this Apache Eagle 0.4.0-incubating Release Candidate 2.
> 
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> 
> [ ] -1 Do not release this package because...
> 
> 
> Thanks.
> 
> Michael

[GitHub] incubator-eagle issue #250: Rebase code base

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/250
  
@zombieJ we could start to refactor the service after merging this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #250: Rebase code base

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/250
  
LGTM

@yonzhang @qingwen220 please help review as well. If no more problem, we 
could merge the PR tomorrow, it will be a milestone where we start to develop 
completely independently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69705994
  
--- Diff: pom.xml ---
@@ -292,8 +293,17 @@
 1.10.19
 2.2
 
2.2.0
+
+1.3.1
+
+
+0.7.1
--- End diff --

It should be ok. As dropwizard is a more full stack framework than jersey. 
As already included, we we may directly use some other features of dropwizard 
as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69704458
  
--- Diff: pom.xml ---
@@ -292,8 +293,17 @@
 1.10.19
 2.2
 
2.2.0
+
+1.3.1
+
+
+0.7.1
--- End diff --

Alert -service is able to be packaged as dropwizard jar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EAGLE-325) Initialize next-gen alert engine code on branch-0.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364065#comment-15364065
 ] 

ASF GitHub Bot commented on EAGLE-325:
--

Github user haoch closed the pull request at:

https://github.com/apache/incubator-eagle/pull/219


> Initialize next-gen alert engine code on branch-0.5
> ---
>
> Key: EAGLE-325
> URL: https://issues.apache.org/jira/browse/EAGLE-325
> Project: Eagle
>  Issue Type: New Feature
>Affects Versions: v0.4.0
>Reporter: Hao Chen
>Assignee: Hao Chen
> Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-eagle issue #248: a testing PR, don't delete it

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/248
  
@anyway1021 could it be closed now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #219: EAGLE-325 Combine multiple web resource i...

[haoch]

Github user haoch closed the pull request at:

https://github.com/apache/incubator-eagle/pull/219


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #250: Rebase code base

[haoch]

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/250
  
@RalphSu Please clean sensitive information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69697025
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/e2e/application-e2e.conf
 ---
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+{
+  "topology" : {
+"name" : "alertUnitTopology_2",
+"numOfSpoutTasks" : 1,
+"numOfRouterBolts" : 4,
+"numOfAlertBolts" : 10,
+"numOfPublishTasks" : 1,
+"numOfTotalWorkers": 20,
+"localMode" : "true"
+  },
+  "spout" : {
+"kafkaBrokerZkQuorum": 
"eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:2181",
+"kafkaBrokerZkBasePath": "/brokers",
+"stormKafkaUseSameZkQuorumWithKafkaBroker": true,
+"stormKafkaTransactionZkQuorum": "",
+"stormKafkaTransactionZkPath": "/consumers",
+"stormKafkaEagleConsumer": "eagle_consumer",
+"stormKafkaStateUpdateIntervalMs": 2000,
+"stormKafkaFetchSizeBytes": 1048586,
+  },
+  "zkConfig" : {
+"zkQuorum" : "eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:2181",
+"zkRoot" : "/alert",
+"zkSessionTimeoutMs" : 1,
+"connectionTimeoutMs" : 1,
+"zkRetryTimes" : 3,
+"zkRetryInterval" : 3000
+  },
+  "dynamicConfigSource" : {
+"initDelayMillis": 3000,
+"delayMillis" : 1
+  },
+  "metadataService": {
+   "context" : "/rest",
+   "host" : "localhost",
+   "port" : 8080
+  },
+  "coordinatorService": {
+   "host": "localhost",
+   "port": "8080",
+   "context" : "/rest"
+  },
+  "kafkaProducer": {
+   "bootstrapServers": "eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:9092"
--- End diff --

Sensitive information


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69696886
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/simple/application-integration.conf
 ---
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+{
+  "topology" : {
+"name" : "alertUnitTopology_1",
+"numOfTotalWorkers": 20,
+"numOfSpoutTasks" : 1,
+"numOfRouterBolts" : 4,
+"numOfAlertBolts" : 10,
+"numOfPublishTasks" : 1,
+"localMode" : "true"
+  },
+  "spout" : {
+"kafkaBrokerZkQuorum": 
"eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:2181",
+"kafkaBrokerZkBasePath": "/brokers",
+"stormKafkaUseSameZkQuorumWithKafkaBroker": true,
+"stormKafkaTransactionZkQuorum": "",
+"stormKafkaTransactionZkPath": "/consumers",
+"stormKafkaEagleConsumer": "eagle_consumer",
+"stormKafkaStateUpdateIntervalMs": 2000,
+"stormKafkaFetchSizeBytes": 1048586,
+  },
+  "zkConfig" : {
+"zkQuorum" : "eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:2181",
+"zkRoot" : "/alert",
+"zkSessionTimeoutMs" : 1,
+"connectionTimeoutMs" : 1,
+"zkRetryTimes" : 3,
+"zkRetryInterval" : 3000
+  },
+  "dynamicConfigSource" : {
+"initDelayMillis": 3000,
+"delayMillis" : 1
+  },
+  "metadataService": {
+   "context" : "/rest",
+   "host" : "localhost",
+   "port" : 8080
+  },
+  "coordinatorService": {
+   "host": "localhost",
+   "port": "8080",
+   "context" : "/rest"
+  },
+  "kafkaProducer": {
+   "bootstrapServers": "eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:9092"
--- End diff --

Sensitive information


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69696905
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/publishments1.json
 ---
@@ -0,0 +1,20 @@
+[
--- End diff --

Sensitive information


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69696871
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/simple/publishments.json
 ---
@@ -9,21 +9,23 @@
  "subject":"UMP Test Alert",
  "template":"",
  "sender": "sen...@corp.com",
- "recipients": "recei...@corp.com",
- "smtp.server":"mailhost.com",
+ "recipients": "li...@ebay.com",
+ "smtp.server":"atom.corp.ebay.com",
  "connection": "plaintext",
  "smtp.port": "25"
},
-   "dedupIntervalMin" : "PT0M"
+   "dedupIntervalMin" : "PT1M",
+   "serializer" : 
"org.apache.eagle.alert.engine.publisher.impl.StringEventSerializer"
 },
 {
   "type": 
"org.apache.eagle.alert.engine.publisher.impl.AlertKafkaPublisher",
   "name":"kafka-testAlertStream",
   "policyIds": ["perfmon_cpu_host_check"],
   "dedupIntervalMin": "PT1M",
   "properties":{
-"kafka_broker":"sandbox.hortonworks.com:6667",
+"kafka_broker":"eagle-c3-lvs01-3-7965.lvs01.dev.ebayc3.com:9092",
--- End diff --

Sensitive information!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69696449
  
--- Diff: pom.xml ---
@@ -292,8 +293,17 @@
 1.10.19
 2.2
 
2.2.0
+
+1.3.1
+
+
+0.7.1
--- End diff --

Why include dropwizard into eagle?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #250: Rebase code base

[haoch]

Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/250#discussion_r69696331
  
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/pom.xml ---
@@ -277,13 +286,92 @@

metrics-elasticsearch-reporter

${metrics-elasticsearch-reporter.version}

+   
+   commons-cli
+   commons-cli
+   ${common.cli.version}
--- End diff --

Maybe a bad practice, referring to version properties in nested module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---