[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert
[
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418085#comment-15418085
]
Julian Hyde commented on EAGLE-331:
---
And instead, I presume, use {{org.junit.Assert}}?
> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
> Issue Type: Bug
>Reporter: Edward Zhang
>Assignee: Lingang Deng
>Priority: Trivial
>
> all eagle code should not use deprecated Assert
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (EAGLE-380) fix eagle site/doc branding issue
[ https://issues.apache.org/jira/browse/EAGLE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384698#comment-15384698 ] Julian Hyde commented on EAGLE-380: --- 1. Yes, something like blur. Or, since there is already the line "Eagle has been accepted as an Apache Incubator Project on Oct 26, 2015", the disclaimer could replace that line. 2a. Sounds good. 2b. Yes, if you use Hadoop you should add "Hadoop" to the list "Apache Eagle, Eagle, Apache, the Apache feather logo, and the Apache Incubator project logo are trademarks of The Apache Software Foundation". Maybe you no longer mention Hadoop. But currently you mention several Apache projects, including Storm, Spark, Ambari, Hive, so you should qualify them with "Apache" and add them to the list. 3. It's not appropriate for an Apache project to be saying "Fork me on Github". Sure, you want people to get the source code, but you also want them to know about mailing lists, JIRA etc. Let's suppose I want to know how to get started as a developer. I'd probably click on "Community" then click "How to contribute", which takes me to... https://github.com/eBay/Eagle/wiki/How-to-Contribute. Oops, let's fix that! Or, if I was starting at https://eagle.incubator.apache.org/docs/ I'd click "Development Quick Guide". Put a paragraph there, showing them how to "git clone ...; mvn install ...". The information in https://github.com/apache/incubator-eagle/blob/master/README.md is great; maybe it should be in the Development Quick Guide. > fix eagle site/doc branding issue > - > > Key: EAGLE-380 > URL: https://issues.apache.org/jira/browse/EAGLE-380 > Project: Eagle > Issue Type: Task >Reporter: Michael Wu >Assignee: Michael Wu > > We may solve this issue in the following way: > 1. if "eagle" is in doc page title, change it to "Apache Eagle (incubating)". > 2. if there are many "eagle"s appear in the doc page content, change the > first mention of it to "Apache Eagle (incubating, called Eagle in the > following)". > 3. change logo size or position. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-380) fix eagle site/doc branding issue
[ https://issues.apache.org/jira/browse/EAGLE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381860#comment-15381860 ] Julian Hyde commented on EAGLE-380: --- Also, make the disclaimer more prominent on the front page. It is buried at the bottom of a very long page. I think it should appear in the first screen-full. Apply these guidelines throughout the site, in particular to the docs, https://eagle.incubator.apache.org/docs/. In the docs, qualify all Apache projects with Apache. I think you can skip "Apache" in the tag line "Secure Hadoop in real time" but you must acknowledge trademarks. In the docs, remove "fork me on github" from the top right corner. The call to action is to join the Apache community. > fix eagle site/doc branding issue > - > > Key: EAGLE-380 > URL: https://issues.apache.org/jira/browse/EAGLE-380 > Project: Eagle > Issue Type: Task >Reporter: Michael Wu >Assignee: Michael Wu > > We may solve this issue in the following way: > 1. if "eagle" is in doc page title, change it to "Apache Eagle (incubating)". > 2. if there are many "eagle"s appear in the doc page content, change the > first mention of it to "Apache Eagle (incubating, called Eagle in the > following)". > 3. change logo size or position. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-373) Move Eagle document to Eagle source code control
[ https://issues.apache.org/jira/browse/EAGLE-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374076#comment-15374076 ] Julian Hyde commented on EAGLE-373: --- In my experience keeping docs on a branch is tricky. (It is impossible to fix the code AND update the doc in a single patch.) I find it easier to put them in a sub-directory of the source code. Or you could create a separate git repo. This issue must be fixed before Eagle graduates. > Move Eagle document to Eagle source code control > > > Key: EAGLE-373 > URL: https://issues.apache.org/jira/browse/EAGLE-373 > Project: Eagle > Issue Type: Improvement >Affects Versions: 0.5 >Reporter: Edward Zhang >Assignee: Edward Zhang >Priority: Minor > Fix For: 0.5 > > > Today Eagle's document is maintained in > https://github.com/eaglemonitoring/eaglemonitoring.github.io, it does not > conform to Apache policy. We should move this into Apache git source control. > The approach is to create a branch called document in > https://github.com/apache/incubator-eagle/tree/document and put document into > it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-371) remove eagle-docs from develop branch
[ https://issues.apache.org/jira/browse/EAGLE-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374066#comment-15374066 ] Julian Hyde commented on EAGLE-371: --- Thanks for logging this case, [~yonzhang2012]. Have you considered combining the web site with the documentation? You could put this into a directory of your source code (not a branch), or you could create a new git repo (hosted under apache.org, and mirrored under github.com/apache). > remove eagle-docs from develop branch > - > > Key: EAGLE-371 > URL: https://issues.apache.org/jira/browse/EAGLE-371 > Project: Eagle > Issue Type: Improvement >Affects Versions: 0.5 >Reporter: Edward Zhang >Assignee: Edward Zhang >Priority: Trivial > Fix For: 0.5 > > > eagle-docs will be maintained in > https://github.com/eaglemonitoring/eaglemonitoring.github.io, so we don't > need maintain duplicated documentation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-371) remove eagle-docs from develop branch
[ https://issues.apache.org/jira/browse/EAGLE-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372034#comment-15372034 ] Julian Hyde commented on EAGLE-371: --- The ASF cannot guarantee the hygiene of Eagle's IP (and yes, documentation is part of the IP) if it is not managed on ASF hardware. A github MIRROR of the ASF git under github.com/apache/incubator-eagle is OK, but Eagle should be moving away from https://github.com/eaglemonitoring as fast as possible. Also, maybe I missed the discussion, but it sounds as if this decision was made off-list. If it's not possible to move off of https://github.com/eaglemonitoring immediately, let's at least create some JIRA cases so that we know where we are heading. > remove eagle-docs from develop branch > - > > Key: EAGLE-371 > URL: https://issues.apache.org/jira/browse/EAGLE-371 > Project: Eagle > Issue Type: Improvement >Affects Versions: 0.5 >Reporter: Edward Zhang >Assignee: Edward Zhang >Priority: Trivial > Fix For: 0.5 > > > eagle-docs will be maintained in > https://github.com/eaglemonitoring/eaglemonitoring.github.io, so we don't > need maintain duplicated documentation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-371) remove eagle-docs from develop branch
[ https://issues.apache.org/jira/browse/EAGLE-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372004#comment-15372004 ] Julian Hyde commented on EAGLE-371: --- Does this mean that eagle-docs are being removed from Apache git? That doesn't sound good. Also, what is the URL where the documents are being published? Does that remain http://eagle.incubator.apache.org/docs? > remove eagle-docs from develop branch > - > > Key: EAGLE-371 > URL: https://issues.apache.org/jira/browse/EAGLE-371 > Project: Eagle > Issue Type: Improvement >Affects Versions: 0.5 >Reporter: Edward Zhang >Assignee: Edward Zhang >Priority: Trivial > Fix For: 0.5 > > > eagle-docs will be maintained in > https://github.com/eaglemonitoring/eaglemonitoring.github.io, so we don't > need maintain duplicated documentation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-46) track the work before moving code to apache site
[ https://issues.apache.org/jira/browse/EAGLE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015023#comment-15015023 ] Julian Hyde commented on EAGLE-46: -- I haven't reviewed your changes. If you've addressed the issues I raised (or logged tickets for anything not yet addressed), go ahead and close. > track the work before moving code to apache site > > > Key: EAGLE-46 > URL: https://issues.apache.org/jira/browse/EAGLE-46 > Project: Eagle > Issue Type: New Feature >Reporter: Edward Zhang >Assignee: Hao Chen > > 1. resolve all existing pull requests > 2. change version to 0.3.0 > 3. change all package name to prefixed by "org.apache" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-46) track the work before moving code to apache site
[ https://issues.apache.org/jira/browse/EAGLE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011907#comment-15011907 ] Julian Hyde commented on EAGLE-46: -- I'll add: 4. remove files that are not part of the code donation. (For example, font files that are part of your web site and are MIT licensed.) You should add these files directly to Apache Eagle, with appropriate changes to LICENSE/NOTICE file. Very soon after moving to apache I encourage you enable apache-rat (add apache-rat-plugin to your pom.xml if you are using maven) and run it regularly. It will force you to fix things (e.g. license headers at the top of files) that you will need to fix before your first release. > track the work before moving code to apache site > > > Key: EAGLE-46 > URL: https://issues.apache.org/jira/browse/EAGLE-46 > Project: Eagle > Issue Type: New Feature >Reporter: Edward Zhang > > 1. resolve all existing pull requests > 2. change version to 0.3.0 > 3. change all package name to prefixed by "org.apache" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
