[GitHub] incubator-eagle issue #428: EAGLE-531: Dedup alerts according to state chang...

[yonzhang]

Github user yonzhang commented on the issue:

https://github.com/apache/incubator-eagle/pull/428
  
@garrettlish is this a duplicated PR? or do we need input more valuable 
description here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #428: EAGLE-531: Dedup alerts according to state chang...

[RalphSu]

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/428
  
ut failed.



org.apache.eagle.alert.engine.publisher.dedup.DefaultDeduplicatorTest.testNormal
   - Please make sure correctly load config before test, call 
ConfigFactory.invalidateCaches()

org.apache.eagle.alert.engine.router.TestAlertPublisherBolt.testCustomFieldDedupEvent
 - changed interface of dedup interface, the assert null failed, please revise

org.apache.eagle.alert.engine.router.TestAlertPublisherBolt.testEmptyCustomFieldDedupEvent
 - changed interface of dedup interface, the assert null failed, please revise



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---