[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user yonzhang commented on the pull request: https://github.com/apache/incubator-eagle/pull/68#issuecomment-173654111 Nice and complete feature --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/68#issuecomment-173617368 @RalphSu Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/68#issuecomment-173529965 LGTM The PR builds successfully and works fine for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/68#discussion_r50380417
--- Diff:
eagle-hadoop-metric/src/main/java/org/apache/eagle/hadoop/metric/HadoopJmxMetricDeserializer.java
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.hadoop.metric;
+
+import org.apache.eagle.dataproc.core.JsonSerDeserUtils;
+import
org.apache.eagle.dataproc.impl.storm.kafka.SpoutKafkaMessageDeserializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.nio.charset.Charset;
+import java.util.Map;
+import java.util.Properties;
+import java.util.SortedMap;
+
+/**
+ * Created on 1/19/16.
+ */
+public class HadoopJmxMetricDeserializer implements
SpoutKafkaMessageDeserializer {
--- End diff --
Duplicated implementation of
org.apache.eagle.datastream.storm.JsonMessageDeserializer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/68#issuecomment-173504214 @sunlibin @haoch @yonzhang Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/68 EAGLE-136 : Setup hadoop metric application https://issues.apache.org/jira/browse/EAGLE-136 1. Add eagle-hadoopo-metrics project 2. Add NameNodeLagMonitor app 3. Fix eagle core to remove eagleAlertContext injection 4. Fix the failed JDBC unit test (by comment out) You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle hadoop-metric Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit 22b29565b087fb39d9f403ac86eeaea4debac6b7 Author: Ralph, Su Date: 2016-01-13T02:24:52Z init commit for hadoop-metric commit aa3a4cfa56365849a83b4fc6169b139219949b9e Author: Ralph, Su Date: 2016-01-17T11:33:47Z second metric commit commit 6c7c75e8ff06b86f19a4550b81c0ebba7e06f9ae Author: Ralph, Su Date: 2016-01-17T11:33:54Z Merge branch 'master' of https://github.com/apache/incubator-eagle into hadoop-metric commit d12e7629526174dc6f7d08fb08ecd6b48384d314 Author: Ralph, Su Date: 2016-01-17T14:51:02Z add NameNodeLag sql case commit 17a62a03788a2a4f3ffa27697bddd7c8c73c8a10 Author: Ralph, Su Date: 2016-01-17T14:55:40Z use query call back that used in the alert executor commit 16750d16907b79b7b8e4e4faabdc6cf4071f1eea Author: Ralph, Su Date: 2016-01-18T08:48:30Z add more case commit 31a9e8c926efefd8646185e6ab31a0bb519b4589 Author: Ralph, Su Date: 2016-01-19T11:40:21Z add topology init shell commit 9ffecf064964e71dee7e06ddb24eaf87b2082a1d Author: Ralph, Su Date: 2016-01-19T14:40:31Z Make #1 case alert commit a462cb40452406a73403881b9904be2e5e78ecb0 Author: Ralph, Su Date: 2016-01-20T07:40:32Z add test for simple aggregate executor commit 659ab4987528863e862b01b911716e43bc298f87 Author: Ralph, Su Date: 2016-01-21T08:09:20Z Fix to avoid inject eagleAlertContext into cep ql commit 7e1151b362edf53e7541049c3fde9f2be5ac463c Author: Ralph, Su Date: 2016-01-21T08:44:28Z merge with latest master and pass all UTs commit 911f493e9ffe5a5db6442a00ccb30eb41e409b32 Author: Ralph, Su Date: 2016-01-21T08:53:12Z Fix to remove sensitive information commit 13071e2a7671e829b58f65f186599a41133c6bbd Author: Ralph, Su Date: 2016-01-21T08:55:56Z correct mail host --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
