[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[yonzhang]

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/195#issuecomment-221773347
  
@r7raul1984 why this is re-opened please manually close this pull request, 
this has been merged in another PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[qingwen220]

Github user qingwen220 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/195#issuecomment-221773080
  
have conflicts. Maybe rebase is needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[r7raul1984]

GitHub user r7raul1984 reopened a pull request:

https://github.com/apache/incubator-eagle/pull/195

EAGLE-296 Test unit for JobConfParserImpl

- TestJobConfParserImpl and jobconf.html to test jobconf parse.

Jira: https://issues.apache.org/jira/browse/EAGLE-296

 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r7raul1984/incubator-eagle dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit da224c287ed9903bd5a57145b7cb77e4be1f0d7f
Author: r7raul1984 
Date:   2016-05-23T04:36:28Z

Add TestJobConfParserImpl and jobconf.html to test jobconf parse.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[r7raul1984]

Github user r7raul1984 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/188


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[r7raul1984]

Github user r7raul1984 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/195


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[yonzhang]

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/195#issuecomment-221164014
  
fixed and merged 
https://github.com/apache/incubator-eagle/commit/5578cfd912d70ebc0bb52a754f145996c6e5efd8.
 Please allow 2 weeks for merging into master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[yonzhang]

Github user yonzhang commented on the pull request:

https://github.com/apache/incubator-eagle/pull/195#issuecomment-221126481
  
This looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[qingwen220]

Github user qingwen220 commented on the pull request:

https://github.com/apache/incubator-eagle/pull/188#issuecomment-220875874
  
If this is an improvement, please resend it to dev branch. 

We will use the dev branch as the next release version 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-296 Test unit for JobConfParse...

[r7raul1984]

GitHub user r7raul1984 opened a pull request:

https://github.com/apache/incubator-eagle/pull/188

EAGLE-296 Test unit for JobConfParserImpl

https://issues.apache.org/jira/browse/EAGLE-296

-  Add simple test unit for JobConfParserImpl.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r7raul1984/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #188


commit d65032cb25ca5d8d667229f4cbf123b852699843
Author: r7raul1984 
Date:   2016-05-13T05:06:51Z

test unit for JobConfParserImpl




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---