[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...

2016-08-09 Thread yonzhang
Github user yonzhang closed the pull request at:

https://github.com/apache/incubator-eagle/pull/312


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...

2016-08-09 Thread haoch
Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/312#discussion_r74025706
  
--- Diff: eagle-server/src/main/resources/application.conf ---
@@ -42,6 +42,7 @@
"metadata":{
"store": 
"org.apache.eagle.metadata.service.memory.MemoryMetadataStore"
},
+   "connection":"jdbc:mysql://server.eagle.apache.org:3306/eagle",
--- End diff --

Yes, I meant

```
metadata{
   connection: "jdbc:mysql://server.eagle.apache.org:3306/eagle"
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...

2016-08-09 Thread RalphSu
Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/312#discussion_r74022788
  
--- Diff: eagle-server/src/main/resources/application.conf ---
@@ -42,6 +42,7 @@
"metadata":{
"store": 
"org.apache.eagle.metadata.service.memory.MemoryMetadataStore"
},
+   "connection":"jdbc:mysql://server.eagle.apache.org:3306/eagle",
--- End diff --

Suggest use nest {}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...

2016-08-09 Thread haoch
Github user haoch commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/312#discussion_r74021223
  
--- Diff: eagle-server/src/main/resources/application.conf ---
@@ -42,6 +42,7 @@
"metadata":{
"store": 
"org.apache.eagle.metadata.service.memory.MemoryMetadataStore"
},
+   "connection":"jdbc:mysql://server.eagle.apache.org:3306/eagle",
--- End diff --

Could we move the `connection` into `metadata.connection`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...

2016-08-08 Thread yonzhang
GitHub user yonzhang opened a pull request:

https://github.com/apache/incubator-eagle/pull/312

Hbase monitoring metadata browse API in new app framework

https://issues.apache.org/jira/browse/EAGLE-428

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yonzhang/incubator-eagle develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #312






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---