[GitHub] incubator-eagle pull request #316: [EAGLE-438] Multiple Inputs for Hadoop JM...

2016-08-12 Thread peterkim95
Github user peterkim95 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/316


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #316: [EAGLE-438] Multiple Inputs for Hadoop JM...

2016-08-09 Thread RalphSu
Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/316#discussion_r74164639
  
--- Diff: eagle-external/hadoop_jmx_collector/config-sample.json ---
@@ -12,18 +12,35 @@
"https":false
  }
},
-   "input": {
-"component": "namenode",
-"port": "50070",
-"https": false
-   },
+   "inputs": [
+  {
+"component": "namenode",
+"host": "127.0.0.1",
+"port": "50070",
+"https": false,
+"kafka_topic": "nn_jmx_metric_sandbox"
+  },
+  {
+"component": "resourcemanager",
+"host": "127.0.0.1",
+"port": "8088",
+"https": false,
+"kafka_topic": "rm_jmx_metric_sandbox"
+  },
+  {
+"component": "datanode",
+"host": "127.0.0.1",
--- End diff --

let's use place holder like what we do in PR312, use 
server.eagle.apache.org. So that developer could simply use /etc/resolv.conf 
when there is different endpoint he want to change (etc, hdp sandbox)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #316: [EAGLE-438] Multiple Inputs for Hadoop JM...

2016-08-09 Thread peterkim95
GitHub user peterkim95 opened a pull request:

https://github.com/apache/incubator-eagle/pull/316

[EAGLE-438] Multiple Inputs for Hadoop JMX Collector Python Script

https://issues.apache.org/jira/browse/EAGLE-438

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/peterkim95/incubator-eagle jmx

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #316


commit 8db6fa2705f7890091951f357aff888061ede1d6
Author: Peter Kim 
Date:   2016-08-09T22:57:39Z

add support for multiple jmx inputs and kafka topics




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---