[GitHub] incubator-eagle pull request #443: Fixed wrongly aggregateCondition.getInter...

2016-09-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/443


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-eagle pull request #443: Fixed wrongly aggregateCondition.getInter...

2016-09-19 Thread haoch
GitHub user haoch opened a pull request:

https://github.com/apache/incubator-eagle/pull/443

Fixed wrongly aggregateCondition.getIntervalMS()

## Problem
When querying eagle storage like: 
~~~

http://localhost:9090/rest/entities?query=GenericMetricService[@site=%22sample%22]%3C@site%3E%7Bmax(value)%7D=hadoop.cluster.totalmemory=10=2016-09-19%2006:25:00=2016-09-19%2008:25:00=5=true
~~~
, the expected result should look like:

~~~
{
meta: {
firstTimestamp: 147427344,
totalResults: 1,
lastTimestamp: 147426630,
elapsedms: 1358
},
success: true,
obj: [
{
key: [
"apollo"
],
value: [
[
203633792,
205067904,
205115648,
205830912,
205980160,
205739392,
205809792,
204790400,
202791040,
202848768,
201649152,
198402176,
198410496,
201081088,
202256128,
203858304,
202554624,
200818304,
203813248,
203441536,
205401472,
206122368,
205884416,
206158976
]
]
}
],
type: "java.util.Map"
}
~~~

,

but actual is:

~~~
{
meta: {
firstTimestamp: 147427344,
totalResults: 1,
lastTimestamp: 147426630,
elapsedms: 9
},
success: true,
obj: [
{
key: [
"apollo"
],
value: [
[
206158976
]
]
}
],
type: "java.util.Map"
~~~

## Root Cause

Wrongly calculated milliseconds by
~~~
aggregateCondition.getIntervalMS() * 60 * 1000
~~~
should be
~~~
aggregateCondition.getIntervalMS()
~~~

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haoch/incubator-eagle EAGLE-553

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #443


commit 7f1bbcea32f7c45af6f08a9977dab16aad39ebcc
Author: Hao Chen 
Date:   2016-09-20T05:37:25Z

Fixed wrongly aggregateCondition.getIntervalMS()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---