[jira] [Commented] (EAGLE-416) Add check style support

2016-08-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420156#comment-15420156
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user r7raul1984 closed the pull request at:

https://github.com/apache/incubator-eagle/pull/303


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>  Labels: engineering, pull-request-available
> Fix For: v0.5.0
>
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418375#comment-15418375
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/303
  
LGTM


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>  Labels: engineering, pull-request-available
> Fix For: v0.5.0
>
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416633#comment-15416633
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/303
  
Jenkins building failed.


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>  Labels: engineering, pull-request-available
> Fix For: v0.5.0
>
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416519#comment-15416519
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/303
  
@r7raul1984 I am planing to merge this PR, but have little conflicts, could 
you please help resole it firstly?


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>  Labels: engineering, pull-request-available
> Fix For: v0.5.0
>
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411316#comment-15411316
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/303
  
@r7raul1984 thanks for the update, looks very good now. Would you please 
raise a discussion in dev list about main specification defined in the check 
style configuration? For example, titled "[Discuss] Check Style Specification", 
so that the community could leave comments about it.


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>  Labels: engineering, pull-request-available
> Fix For: v0.5.0
>
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-05 Thread JiJun Tang (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408938#comment-15408938
 ] 

JiJun Tang commented on EAGLE-416:
--

ok

> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-05 Thread Hao Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408940#comment-15408940
 ] 

Hao Chen commented on EAGLE-416:


Pls. update *Fix version* and *Start Progress* when patch is available.

> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408937#comment-15408937
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

Github user haoch commented on the issue:

https://github.com/apache/incubator-eagle/pull/303
  
It seems that the PR created as new directory 
[`build`](/r7raul1984/incubator-eagle/tree/checkstyle-EAGLE416/build) under 
project root, would you please just put the checkstyle files under 
[`eagle-dev`](/apache/incubator-eagle/tree/master/eagle-dev) directly?


> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-416) Add check style support

2016-08-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/EAGLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408933#comment-15408933
 ] 

ASF GitHub Bot commented on EAGLE-416:
--

GitHub user r7raul1984 opened a pull request:

https://github.com/apache/incubator-eagle/pull/303

[EAGLE-416] Add check style support

- Add checkstyle plugin config in pom file.
- Add eagle_checks and suppressions file.

https://issues.apache.org/jira/browse/EAGLE-416

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r7raul1984/incubator-eagle checkstyle-EAGLE416

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #303


commit edfa70cdffa9fa362f16bc6b5db575b2ed0d937c
Author: r7raul1984 
Date:   2016-08-05T05:18:28Z

[EAGLE-416] Add check style support
- Add checkstyle plugin config in pom file.
- Add eagle_checks and suppressions file.

https://issues.apache.org/jira/browse/EAGLE-416




> Add check style support
> ---
>
> Key: EAGLE-416
> URL: https://issues.apache.org/jira/browse/EAGLE-416
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: JiJun Tang
>Priority: Trivial
>
> Add check style when build the project. Just print warning in console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)