[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1128407366 > `eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker`, @HoffmanZheng hi, you need add the apache license header for this file. Once I add the license head, the Mockito test failed. As I mentioned above, this file might be single line to enable the incubating feature of Mockito (for our situation, to mock the final class).  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on issue #859: [Enhancement] Add test code for this module [eventmesh-sdk-java]
HoffmanZheng commented on issue #859: URL: https://github.com/apache/incubator-eventmesh/issues/859#issuecomment-1128403421 > @HoffmanZheng Hello, the issue of good first issue is specially provided for the contributors who submit pr for the first time. One person can only receive it once. If you want to continue to contribute to the community, please continue to pay attention. Gotcha that, will choose another issue to contribute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #859: [Enhancement] Add test code for this module [eventmesh-sdk-java]
Alonexc commented on issue #859: URL: https://github.com/apache/incubator-eventmesh/issues/859#issuecomment-1128376842 @HoffmanZheng Hello, the issue of good first issue is specially provided for the contributors who submit pr for the first time. One person can only receive it once. If you want to continue to contribute to the community, please continue to pay attention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]
xwm1992 commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1128342575 `eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker`, @HoffmanZheng hi, you need add the apache license header for this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]
codecov[bot] commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1128334913 # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/867?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#867](https://codecov.io/gh/apache/incubator-eventmesh/pull/867?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9919771) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/836e3a5bd6a25c9831b0c6a8db30c997c68f0e91?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (836e3a5) will **increase** coverage by `0.20%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master#867 +/- ## === + Coverage 6.85% 7.05% +0.20% - Complexity 433 441 +8 === Files 345 349 +4 Lines 21619 21723 +104 Branches 24042413 +9 === + Hits 14811532 +51 - Misses20025 20073 +48 - Partials113 118 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/867?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...che/eventmesh/trace/zipkin/ZipkinTraceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL1ppcGtpblRyYWNlU2VydmljZS5qYXZh) | `93.93% <100.00%> (ø)` | | | [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: | | [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...che/eventmesh/runtime/boot/EventMeshTCPServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoVENQU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...sh/client/http/producer/EventMeshHttpProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvcHJvZHVjZXIvRXZlbnRNZXNoSHR0cFByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...core/protocol/http/consumer/EventMeshConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | | | [.../protocol/tcp/client/group/ClientGroupWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/867/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRHcm91cFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | |
Re: Biweekly Meeting of EventMesh Developers on May 12th, 2022
Thanks Jeff, nice work~ On Mon, May 16, 2022 at 7:47 PM 林** wrote: > > Biweekly Meeting of EventMesh Developers on May 12th, 2022 > > > Introduction to the content of this regular meeting > > Video recording： > > https://meeting.tencent.com/user-center/shared-record-info?id=101ae371-2d58-4c34-b6f7-4cc1b6e07506=3 > > documents： > > https://docs.qq.com/doc/DQkdlV0ZhdWZGRXFB?u=fcd8162f05b9453190f79945ab2d66ea&&_t=1652408301536 > > topic & summary： > > 1、Dashboard feature——xiaoyang liu > > The first-stage tasks have been listed, and the function points have been > split. > > 2、WebHook feature——laohu > > The detailed design scheme is discussed. As a result, it is necessary to > support the default configuration storage and not rely on nacos. > > 3、Route feature——mikexue > > Conduct scheme research and discussion. > > 4、Transformation of Http request for EventMesh——mikexue、laohu > > Compatible with requests from em sdk and external http requests such as > webhook, and discuss the unified transformation scheme. > > > Apache Eventmesh > > 2022.05.16 > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
Biweekly Meeting of EventMesh Developers on May 12th, 2022
Biweekly Meeting of EventMesh Developers on May 12th, 2022 Introduction to the content of this regular meeting Video recording： https://meeting.tencent.com/user-center/shared-record-info?id=101ae371-2d58-4c34-b6f7-4cc1b6e07506=3 documents： https://docs.qq.com/doc/DQkdlV0ZhdWZGRXFB?u=fcd8162f05b9453190f79945ab2d66ea&&_t=1652408301536 topic & summary： 1、Dashboard feature——xiaoyang liu The first-stage tasks have been listed, and the function points have been split. 2、WebHook feature——laohu The detailed design scheme is discussed. As a result, it is necessary to support the default configuration storage and not rely on nacos. 3、Route feature——mikexue Conduct scheme research and discussion. 4、Transformation of Http request for EventMesh——mikexue、laohu Compatible with requests from em sdk and external http requests such as webhook, and discuss the unified transformation scheme. Apache Eventmesh 2022.05.16
[GitHub] [incubator-eventmesh] framctr closed issue #857: [Bug] AsyncSubscribe not found
framctr closed issue #857: [Bug] AsyncSubscribe not found URL: https://github.com/apache/incubator-eventmesh/issues/857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] framctr commented on issue #857: [Bug] AsyncSubscribe not found
framctr commented on issue #857: URL: https://github.com/apache/incubator-eventmesh/issues/857#issuecomment-1127519607 Seems to work with the following procedure: 1. `sh gradlew clean jar dist && sh gradlew installPlugin `` 2. `mv eventmesh-examples/build/classes/java/main/org dist` 3. Add to the classpath `:.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on issue #859: [Enhancement] Add test code for this module [eventmesh-sdk-java]
HoffmanZheng commented on issue #859: URL: https://github.com/apache/incubator-eventmesh/issues/859#issuecomment-1127457809 Would you mind assign this to me ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1127442988 It seems that mocking a final class is [still a incubating feature](https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2#mock-the-unmockable-opt-in-mocking-of-final-classesmethods) of Mockito, which need a [extra file with single line](https://github.com/apache/incubator-eventmesh/blob/f7c49017a349d8d4453e3fab3b1419efa84f55f8/eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker) to enable this feature. However the additional file violate the [ci license check](https://github.com/apache/incubator-eventmesh/runs/6444747775?check_suite_focus=true), any possible to skip license check on this file ? Otherwise i may remove the unit test for [zipkinTrackService.shutdown()](https://github.com/apache/incubator-eventmesh/blob/f7c49017a349d8d4453e3fab3b1419efa84f55f8/eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/java/org/apache/eventmesh/trace/zipkin/ZipkinTraceServiceTest.java#L62-L73). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
