[GitHub] [eventmesh-site] MajorHe1 merged pull request #78: Update the-apache-software-foundation-announces-new-top-level-project…
MajorHe1 merged PR #78: URL: https://github.com/apache/eventmesh-site/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] qqeasonchen opened a new pull request, #78: Update the-apache-software-foundation-announces-new-top-level-project…
qqeasonchen opened a new pull request, #78: URL: https://github.com/apache/eventmesh-site/pull/78 …-apache-eventmesh.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] dipankr opened a new pull request, #3712: [ISSUE #3652] refactored the code, extracted a new method and used switch
dipankr opened a new pull request, #3712: URL: https://github.com/apache/eventmesh/pull/3712 Fixes #3652. ### Motivation *there were duplicate code in the file, refactored the duplicate code to a method and refactored further to make the code more readable* ### Modifications *refactored the code, extracted a new method and used switch to make code more readable* ### Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] xwm1992 merged pull request #77: fix error
xwm1992 merged PR #77: URL: https://github.com/apache/eventmesh-site/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] xwm1992 merged pull request #73: Update roadmap.md
xwm1992 merged PR #73: URL: https://github.com/apache/eventmesh-site/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] xwm1992 merged pull request #76: fix error
xwm1992 merged PR #76: URL: https://github.com/apache/eventmesh-site/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] dipankr closed pull request #3711: [ ISSUE #3652] refactored code
dipankr closed pull request #3711: [ ISSUE #3652] refactored code URL: https://github.com/apache/eventmesh/pull/3711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] dipankr opened a new pull request, #3711: [ ISSUE #3652] refactored code
dipankr opened a new pull request, #3711: URL: https://github.com/apache/eventmesh/pull/3711 Fixes #3652. ### Motivation *Explain the content here.* *Explain why you want to make the changes and what problem you're trying to solve.* there were duplicate code in the file, refactored the duplicate code to a method and refactored further to make the code more readable ### Modifications refactored the code, extracted a new method and used switch to make code more readable ### Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java
akashsawan1 opened a new pull request, #3710: URL: https://github.com/apache/eventmesh/pull/3710 Closes#<3408> Motivation Explain why you want to make the changes and what problem you're trying to solve. I am contributing for the first time, it will help to keep me motivated to learn and help the community Modifications Describe the modifications you've done. Did some code optimization in line 246,336 Documentation Does this pull request introduce a new feature? no If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 closed pull request #3706: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java #3408
akashsawan1 closed pull request #3706: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java #3408 URL: https://github.com/apache/eventmesh/pull/3706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
Re: Request for Consideration of Squash Commits in Merge Requests
+1 On 12/04/2023 10:16, Eason Chen wrote: Seems ok to me. On Wed, Apr 12, 2023 at 3:58 PM ZhangJian He wrote: Hello community members, would you like to share any thoughts, ideas, or feedback? Thanks ZhangJian He On 2023/03/29 12:39:16 ZhangJian He wrote: Hello, community! I would like to bring up a topic for discussion regarding our git commits. I noticed that we have not been using the "squash commit" feature when merging pull requests. For those who may be unfamiliar, "squash commit" is a feature that allows us to combine multiple commits into a single commit before merging into the main branch. This can be helpful in keeping our commit history clean and organized. I would like to suggest that we start using the "squash commit" feature moving forward. This will help us to maintain a clear and concise commit history, making it easier to review and understand changes in the codebase. Please feel free to share your thoughts on this topic. Thanks ZhangJian He - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] dipankr opened a new pull request, #3709: [ISSUE #3653] refactored code and extracted method
dipankr opened a new pull request, #3709: URL: https://github.com/apache/eventmesh/pull/3709 …umber of line of duplicate code Fixes #3653. ### Motivation we have a few lines of duplicate code and the suggestion was to extract it to a method ### Modifications refactored code to make it more readable and extracted a method ### Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] willimpo opened a new pull request, #3708: [ISSUE #3707]fix thread leak with rocketmq consumer start and shutdown frequently
willimpo opened a new pull request, #3708:
URL: https://github.com/apache/eventmesh/pull/3708
Fixes #<3707>.
### Motivation
when using rocketmq as eventmesh storage，and consumer groups are frequently
started and shutdown.
The number of threads in the process continues to increase，and eventually
led to Full GC
### Modifications
In the rocketmq eventmesh storage, we overwrite the
ConsumeMessageConcurrentlyService.java of rocketmq
but in the shutdown(long) method, we didn't do anything, this led to some
consumer threads are not recycled when consumer was shutdown
**the shutdown(long) method in ConsumeMessageConcurrentlyService.java**
```
public void shutdown(long awaitTerminateMillis) {
}
```
**where the ConsumeMessageConcurrentlyService.shutdown(long) method was
invoked**
```
DefaultMQPushConsumerImpl.java:
public synchronized void shutdown(long awaitTerminateMillis) {
switch (this.serviceState) {
case CREATE_JUST:
break;
case RUNNING:
// here invokes the shutdown method
this.consumeMessageService.shutdown(awaitTerminateMillis);
this.persistConsumerOffset();
this.mQClientFactory.unregisterConsumer(this.defaultMQPushConsumer.getConsumerGroup());
this.mQClientFactory.shutdown();
log.info("the consumer [{}] shutdown OK",
this.defaultMQPushConsumer.getConsumerGroup());
this.rebalanceImpl.destroy();
this.serviceState = ServiceState.SHUTDOWN_ALREADY;
break;
case SHUTDOWN_ALREADY:
break;
default:
break;
}
}
```
Therefore, my modification is to supplement the logic of shutdown (long) .
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3706: Update SendAsyncRemoteEventProcessor.java #3408
akashsawan1 opened a new pull request, #3706: URL: https://github.com/apache/eventmesh/pull/3706 Closes#<3408> Motivation Explain why you want to make the changes and what problem you're trying to solve. I am contributing for the first time, it will help to keep me motivated to learn and help the community Modifications Describe the modifications you've done. Did some code optimization in line 246,336 Documentation Does this pull request introduce a new feature? no If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] monish-byte opened a new pull request, #3705: [Enhancement] Code reuse is extracted as a method.[GrpcMessageProtocolResolver].
monish-byte opened a new pull request, #3705: URL: https://github.com/apache/eventmesh/pull/3705 Fixes #3651. ### Motivation *Explain the content here.* *Explain why you want to make the changes and what problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] MajorHe1 merged pull request #75: add asf annoucne
MajorHe1 merged PR #75: URL: https://github.com/apache/eventmesh-site/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] nikam14 opened a new pull request, #3704: fixes #3246
nikam14 opened a new pull request, #3704: URL: https://github.com/apache/eventmesh/pull/3704 made the changes mentioned in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] qqeasonchen merged pull request #74: [doc](01-contribute)fixed broken link.
qqeasonchen merged PR #74: URL: https://github.com/apache/eventmesh-site/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh-site] nikam14 opened a new pull request, #74: [doc](01-contribute)fixed broken link.
nikam14 opened a new pull request, #74: URL: https://github.com/apache/eventmesh-site/pull/74 In the section of Documentation improvement a hyperlink was broken . improved that hyperlink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
Re: Request for Consideration of Squash Commits in Merge Requests
Seems ok to me. On Wed, Apr 12, 2023 at 3:58 PM ZhangJian He wrote: > > Hello community members, would you like to share any thoughts, ideas, or > feedback? > > Thanks > ZhangJian He > > > On 2023/03/29 12:39:16 ZhangJian He wrote: > > Hello, community! > > I would like to bring up a topic for discussion regarding our git commits. > > I noticed that we have not been using the "squash commit" feature when > > merging pull requests. > > > > For those who may be unfamiliar, "squash commit" is a feature that allows > > us to combine multiple commits into a single commit before merging into > the > > main branch. This can be helpful in keeping our commit history clean and > > organized. > > > > I would like to suggest that we start using the "squash commit" feature > > moving forward. This will help us to maintain a clear and concise commit > > history, making it easier to review and understand changes in the > codebase. > > > > Please feel free to share your thoughts on this topic. > > > > Thanks > > ZhangJian He > > - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
RE: Request for Consideration of Squash Commits in Merge Requests
Hello community members, would you like to share any thoughts, ideas, or feedback? Thanks ZhangJian He On 2023/03/29 12:39:16 ZhangJian He wrote: > Hello, community! > I would like to bring up a topic for discussion regarding our git commits. > I noticed that we have not been using the "squash commit" feature when > merging pull requests. > > For those who may be unfamiliar, "squash commit" is a feature that allows > us to combine multiple commits into a single commit before merging into the > main branch. This can be helpful in keeping our commit history clean and > organized. > > I would like to suggest that we start using the "squash commit" feature > moving forward. This will help us to maintain a clear and concise commit > history, making it easier to review and understand changes in the codebase. > > Please feel free to share your thoughts on this topic. > > Thanks > ZhangJian He >
[GitHub] [eventmesh] nikam14 opened a new pull request, #3703: [MINOR] made some optimisation
nikam14 opened a new pull request, #3703: URL: https://github.com/apache/eventmesh/pull/3703 ### Motivation Made some optimization in file. ### Modifications removed the repetition of function call. ### Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3697: [ISSUE #3513] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
xwm1992 merged PR #3697: URL: https://github.com/apache/eventmesh/pull/3697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3698: [ISSUE #2975] removed String.format()
xwm1992 merged PR #3698: URL: https://github.com/apache/eventmesh/pull/3698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
