[jira] Closed: (FELIX-1873) Wrong default HttpContext in Whiteboard

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik closed FELIX-1873.
-

Resolution: Fixed

> Wrong default HttpContext in Whiteboard
> ---
>
> Key: FELIX-1873
> URL: https://issues.apache.org/jira/browse/FELIX-1873
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Sten Roger Sandvik
>Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> When a whiteboard registration is used with no httpcontext it should be using 
> a default. This default should be associated with the right bundle (bundle 
> which registered the service) so that ServletContext.getResource(..) methods 
> will work correctly. Right now it is not using the right bundle - it's using 
> the whiteboard extender itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1872) NPE while setting attribute on ServletContext

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik closed FELIX-1872.
-

Resolution: Fixed

> NPE while setting attribute on ServletContext
> -
>
> Key: FELIX-1872
> URL: https://issues.apache.org/jira/browse/FELIX-1872
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Sten Roger Sandvik
>Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> NPE inside ServletContextImpl.setAttribute(..) when setting with null key 
> and/or null value. Should be failsafe.
> java.lang.NullPointerException
>   at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:881)
>   at 
> org.apache.felix.http.base.internal.context.ServletContextImpl.setAttribute(ServletContextImpl.java:152)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1873) Wrong default HttpContext in Whiteboard

2009-11-16 Thread Sten Roger Sandvik (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778655#action_12778655
 ] 

Sten Roger Sandvik commented on FELIX-1873:
---

Fixed the code, but need to test with my apps before closing. 

> Wrong default HttpContext in Whiteboard
> ---
>
> Key: FELIX-1873
> URL: https://issues.apache.org/jira/browse/FELIX-1873
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Sten Roger Sandvik
>Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
>
> When a whiteboard registration is used with no httpcontext it should be using 
> a default. This default should be associated with the right bundle (bundle 
> which registered the service) so that ServletContext.getResource(..) methods 
> will work correctly. Right now it is not using the right bundle - it's using 
> the whiteboard extender itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1860) HttpServletRequest objects passed through HttpService don't respond to getAuthType() and getRemoteUser() properly

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik closed FELIX-1860.
-

Resolution: Fixed
  Assignee: Sten Roger Sandvik

Applied the patch.

> HttpServletRequest objects passed through HttpService don't respond to 
> getAuthType() and getRemoteUser() properly
> -
>
> Key: FELIX-1860
> URL: https://issues.apache.org/jira/browse/FELIX-1860
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Justin Edelson
>Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
> Attachments: FELIX-1860.patch
>
>
> According to the JavaDoc for org.osgi.service.http.HttpContext, the 
> authentication type and remote user should be accessible via the standard 
> getAuthType() and getRemoteUser() methods of HttpServletRequest. However, 
> Felix HttpService's ServletHandlerRequest class does *not* do this.
> patch to follow shortly...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1863) getServletPath() should return "" when alias is /

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik closed FELIX-1863.
-

Resolution: Fixed
  Assignee: Sten Roger Sandvik

Applied the patch. 

> getServletPath() should return "" when alias is /
> -
>
> Key: FELIX-1863
> URL: https://issues.apache.org/jira/browse/FELIX-1863
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Justin Edelson
>Assignee: Sten Roger Sandvik
> Fix For: http-2.0.4
>
> Attachments: FELIX-1863.patch
>
>
> When a servlet is registered with HttpService with an alias of "/", 
> getServletPath() should return "". Currently it returns "/".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1863) getServletPath() should return "" when alias is /

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik updated FELIX-1863:
--

Fix Version/s: http-2.0.4

Thanks for the patch. Will apply it shortly and get it included in 2.0.4.

> getServletPath() should return "" when alias is /
> -
>
> Key: FELIX-1863
> URL: https://issues.apache.org/jira/browse/FELIX-1863
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Justin Edelson
> Fix For: http-2.0.4
>
> Attachments: FELIX-1863.patch
>
>
> When a servlet is registered with HttpService with an alias of "/", 
> getServletPath() should return "". Currently it returns "/".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1860) HttpServletRequest objects passed through HttpService don't respond to getAuthType() and getRemoteUser() properly

2009-11-16 Thread Sten Roger Sandvik (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778644#action_12778644
 ] 

Sten Roger Sandvik commented on FELIX-1860:
---

Thanks for the patch. Will apply it shortly and test it locally.

> HttpServletRequest objects passed through HttpService don't respond to 
> getAuthType() and getRemoteUser() properly
> -
>
> Key: FELIX-1860
> URL: https://issues.apache.org/jira/browse/FELIX-1860
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Justin Edelson
> Fix For: http-2.0.4
>
> Attachments: FELIX-1860.patch
>
>
> According to the JavaDoc for org.osgi.service.http.HttpContext, the 
> authentication type and remote user should be accessible via the standard 
> getAuthType() and getRemoteUser() methods of HttpServletRequest. However, 
> Felix HttpService's ServletHandlerRequest class does *not* do this.
> patch to follow shortly...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1860) HttpServletRequest objects passed through HttpService don't respond to getAuthType() and getRemoteUser() properly

2009-11-16 Thread Sten Roger Sandvik (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sten Roger Sandvik updated FELIX-1860:
--

Fix Version/s: http-2.0.4

> HttpServletRequest objects passed through HttpService don't respond to 
> getAuthType() and getRemoteUser() properly
> -
>
> Key: FELIX-1860
> URL: https://issues.apache.org/jira/browse/FELIX-1860
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http-2.0.2
>Reporter: Justin Edelson
> Fix For: http-2.0.4
>
> Attachments: FELIX-1860.patch
>
>
> According to the JavaDoc for org.osgi.service.http.HttpContext, the 
> authentication type and remote user should be accessible via the standard 
> getAuthType() and getRemoteUser() methods of HttpServletRequest. However, 
> Felix HttpService's ServletHandlerRequest class does *not* do this.
> patch to follow shortly...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1873) Wrong default HttpContext in Whiteboard

2009-11-16 Thread Sten Roger Sandvik (JIRA)
Wrong default HttpContext in Whiteboard
---

 Key: FELIX-1873
 URL: https://issues.apache.org/jira/browse/FELIX-1873
 Project: Felix
  Issue Type: Bug
  Components: HTTP Service
Affects Versions: http-2.0.2
Reporter: Sten Roger Sandvik
Assignee: Sten Roger Sandvik
 Fix For: http-2.0.4


When a whiteboard registration is used with no httpcontext it should be using a 
default. This default should be associated with the right bundle (bundle which 
registered the service) so that ServletContext.getResource(..) methods will 
work correctly. Right now it is not using the right bundle - it's using the 
whiteboard extender itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1872) NPE while setting attribute on ServletContext

2009-11-16 Thread Sten Roger Sandvik (JIRA)
NPE while setting attribute on ServletContext
-

 Key: FELIX-1872
 URL: https://issues.apache.org/jira/browse/FELIX-1872
 Project: Felix
  Issue Type: Bug
  Components: HTTP Service
Affects Versions: http-2.0.2
Reporter: Sten Roger Sandvik
Assignee: Sten Roger Sandvik
 Fix For: http-2.0.4


NPE inside ServletContextImpl.setAttribute(..) when setting with null key 
and/or null value. Should be failsafe.

java.lang.NullPointerException
at 
java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:881)
at 
org.apache.felix.http.base.internal.context.ServletContextImpl.setAttribute(ServletContextImpl.java:152)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1871) fileinstall picks up hidden files and directories by default. This causes our JVM to crash.

2009-11-16 Thread Peter Lawrey (JIRA)
fileinstall picks up hidden files and directories by default. This causes our 
JVM to crash.
---

 Key: FELIX-1871
 URL: https://issues.apache.org/jira/browse/FELIX-1871
 Project: Felix
  Issue Type: Bug
Affects Versions: fileinstall-2.0.4
Reporter: Peter Lawrey


The file installer find our .svn directory and builds a .svn.jar from it every 
second.
It also checks it every second to see if its a valid JarFile and occasionally 
crashes the JVM (due to a bug reported to sun)
It would be better if hidden files/directories were ignored.  c.f. 
File.isHidden.

The workaround is to create a filter which ignored files starting with a '.'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1870) deleteFile deletes files recursively following symbolic links.

2009-11-16 Thread Peter Lawrey (JIRA)
deleteFile deletes files recursively following symbolic links.
--

 Key: FELIX-1870
 URL: https://issues.apache.org/jira/browse/FELIX-1870
 Project: Felix
  Issue Type: Bug
Reporter: Peter Lawrey


In org.apache.felix.karaf.admin.internal.InstanceImpl.deleteFile() it does a 
recursive delete.
However, it only tests for isDirectory() which is true for links to directories.
e.g. a link to root would attempt to delete everything it can, repeatedly until 
the filenames became too long. ;)

Apache's FileUtils.isSymlink() does a check and in fact using 
FileUtils.deleteDirectory() would fix the problem. Perhaps this is a better 
choice.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1845) Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0

2009-11-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778321#action_12778321
 ] 

Carsten Ziegeler commented on FELIX-1845:
-

Hi Geert, could you please retest with latest from trunk? It seems that this 
has been fixed with all the refactorings and changes we did - at least I can't 
reproduce.

> Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0
> ---
>
> Key: FELIX-1845
> URL: https://issues.apache.org/jira/browse/FELIX-1845
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Geert Schuring
>Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: package-info.java
>
>
> For some unknown reason my maven-scr-plugin stopped working and throws the 
> following exception:
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Building ipds-service
> [INFO]task-segment: [package]
> [INFO] 
> 
> [INFO] [resources:resources {execution: default-resources}]
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] [compiler:compile {execution: default-compile}]
> [INFO] Compiling 3 source files to 
> C:\Users\geert\workspace\nl.interact911.ipds.ipds-service\target\classes
> [INFO] [scr:scr {execution: generate-scr-scrdescriptor}]
> [INFO] 
> 
> [ERROR] FATAL ERROR
> [INFO] 
> 
> [INFO] 0
> [INFO] 
> 
> [INFO] Trace
> java.lang.ArrayIndexOutOfBoundsException: 0
>   at 
> org.apache.felix.scrplugin.tags.JavaClassDescriptorManager.getSourceDescriptions(JavaClassDescriptorManager.java:393)
>   at 
> org.apache.felix.scrplugin.SCRDescriptorMojo.execute(SCRDescriptorMojo.java:167)
>   at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>   at 
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> [INFO] 
> 
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Wed Nov 04 16:46:39 CET 2009
> [INFO] Final Memory: 14M/26M
> [INFO] 
> 
> I have no clue why I get this message, and the exception does not have a 
> message that I could use to try to locate the source of the problem. I really 
> hope you can point me in the richt direction by telling me why this exception 
> is being thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (FELIX-1845) Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0

2009-11-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned FELIX-1845:
---

Assignee: Carsten Ziegeler

> Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0
> ---
>
> Key: FELIX-1845
> URL: https://issues.apache.org/jira/browse/FELIX-1845
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Geert Schuring
>Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: package-info.java
>
>
> For some unknown reason my maven-scr-plugin stopped working and throws the 
> following exception:
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Building ipds-service
> [INFO]task-segment: [package]
> [INFO] 
> 
> [INFO] [resources:resources {execution: default-resources}]
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO] [compiler:compile {execution: default-compile}]
> [INFO] Compiling 3 source files to 
> C:\Users\geert\workspace\nl.interact911.ipds.ipds-service\target\classes
> [INFO] [scr:scr {execution: generate-scr-scrdescriptor}]
> [INFO] 
> 
> [ERROR] FATAL ERROR
> [INFO] 
> 
> [INFO] 0
> [INFO] 
> 
> [INFO] Trace
> java.lang.ArrayIndexOutOfBoundsException: 0
>   at 
> org.apache.felix.scrplugin.tags.JavaClassDescriptorManager.getSourceDescriptions(JavaClassDescriptorManager.java:393)
>   at 
> org.apache.felix.scrplugin.SCRDescriptorMojo.execute(SCRDescriptorMojo.java:167)
>   at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
>   at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>   at 
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> [INFO] 
> 
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Wed Nov 04 16:46:39 CET 2009
> [INFO] Final Memory: 14M/26M
> [INFO] 
> 
> I have no clue why I get this message, and the exception does not have a 
> message that I could use to try to locate the source of the problem. I really 
> hope you can point me in the richt direction by telling me why this exception 
> is being thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1629) SCR Annotations with Constanst reference may cause NPE

2009-11-16 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-1629.
-


> SCR Annotations with Constanst reference may cause NPE
> --
>
> Key: FELIX-1629
> URL: https://issues.apache.org/jira/browse/FELIX-1629
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: 090922_npe_fix_FELIX-1629.patch
>
>
> under certain circumstances the maven scr plugin throws a NPE like this
> java.lang.NullPointerException
> at 
> org.apache.felix.scrplugin.tags.annotation.defaulttag.Util.getAnnotationValue(Util.java:362)
> at 
> org.apache.felix.scrplugin.tags.annotation.defaulttag.Util.getAnnotationValues(Util.java:399)
> at 
> org.apache.felix.scrplugin.tags.annotation.defaulttag.Util.getStringValue(Util.java:277)
> at 
> org.cqstone.core.annotationtagprovider.ComponentComponentTag.(ComponentComponentTag.java:31)
> at 
> org.cqstone.core.annotationtagprovider.CqstoneAnnotationTagProvider.getTags(CqstoneAnnotationTagProvider.java:31)
> at 
> org.apache.felix.scrplugin.tags.annotation.AnnotationTagProviderManager.getTags(AnnotationTagProviderManager.java:105)
> at 
> org.apache.felix.scrplugin.tags.annotation.AnnotationTagProviderManager.getTags(AnnotationTagProviderManager.java:90)
> at 
> org.apache.felix.scrplugin.tags.annotation.AnnotationTagProviderManager.hasScrPluginAnnotation(AnnotationTagProviderManager.java:118)
> at 
> org.apache.felix.scrplugin.tags.JavaClassDescriptorManager.getJavaClassDescription(JavaClassDescriptorManager.java:417)
> at 
> org.apache.felix.scrplugin.tags.JavaClassDescriptorManager.getSourceDescriptions(JavaClassDescriptorManager.java:394)
> at 
> org.apache.felix.scrplugin.SCRDescriptorMojo.execute(SCRDescriptorMojo.java:167)
> at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
> at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
> at 
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at 
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> the reason of the NPE is that the "prescan" which is done in 
> AnnotationTagProviderManager#hasScrPluginAnnotation to check if any 
> annotation is present in a java class at all calls the getTags methods 
> without a "JavaClassDescription" object. but Util.getAnnotationValue depends 
> on this, although this is not needed for the "prescan" check.
> the attached patch fixes this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1725) SCR Annotations - Support "Add" Operator in annotation values

2009-11-16 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-1725.
-


> SCR Annotations - Support "Add" Operator in annotation values
> -
>
> Key: FELIX-1725
> URL: https://issues.apache.org/jira/browse/FELIX-1725
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: 091009_annotationadd_FELIX-1725.patch, 
> 091103_annotationadd_FELIX-1725.patch
>
>
> in scr plugin 1.4.0 it is not possible to use a annotation expression like 
> this:
> contentType = "application/json;charset=" + CharEncoding.UTF_8
> the attached patch solves this problem by supporting the qdox "AnnotationAdd" 
> class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1419) Add support for nested/inner classes in SCR Plugins (QDox+Annotations)

2009-11-16 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-1419.
-


> Add support for nested/inner classes in SCR Plugins (QDox+Annotations)
> --
>
> Key: FELIX-1419
> URL: https://issues.apache.org/jira/browse/FELIX-1419
> Project: Felix
>  Issue Type: Improvement
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.2.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: 090728_innerclasssupport.patch
>
>
> the current scr plugin implementation ignores inner classes, even if they 
> have SCR plugin annotations or QDox tags.
> the attached patch solves this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1726) SCR Annotations - Enhance error messages in case of missing project dependencies

2009-11-16 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed FELIX-1726.
-


thanks

> SCR Annotations - Enhance error messages in case of missing project 
> dependencies
> 
>
> Key: FELIX-1726
> URL: https://issues.apache.org/jira/browse/FELIX-1726
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: felix.patch
>
>
> in rev. 821022 felix removed some dependencies that where unneeded for the 
> code that existed in the scr plugin itself.
> there where unneeded to compile the plugin, but they are needed in some 
> usecases for annotation parsing.
> e.g. if a project's class is annotated with SCR annotations, and at the same 
> time declares a static field with a slf4j Logger class, reading other static 
> string field values fails with a ClassNotFound exception pointing to a slf4j 
> class.
> re-adding the slf4j dependencies again solves the problem.
> unfortunately the exception handling in this case is not good - the message 
> is only "Somehing went wrong.", because the ClassNotFound exception was 
> swallowed in ClassUtil.getInitializationExpression method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (FELIX-1726) SCR Annotations - Enhance error messages in case of missing project dependencies

2009-11-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved FELIX-1726.
-

Resolution: Fixed

I've applied the patch in Revision 880725

> SCR Annotations - Enhance error messages in case of missing project 
> dependencies
> 
>
> Key: FELIX-1726
> URL: https://issues.apache.org/jira/browse/FELIX-1726
> Project: Felix
>  Issue Type: Bug
>  Components: Maven SCR Plugin
>Affects Versions: maven-scr-plugin-1.4.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: maven-scr-plugin-1.4.1
>
> Attachments: felix.patch
>
>
> in rev. 821022 felix removed some dependencies that where unneeded for the 
> code that existed in the scr plugin itself.
> there where unneeded to compile the plugin, but they are needed in some 
> usecases for annotation parsing.
> e.g. if a project's class is annotated with SCR annotations, and at the same 
> time declares a static field with a slf4j Logger class, reading other static 
> string field values fails with a ClassNotFound exception pointing to a slf4j 
> class.
> re-adding the slf4j dependencies again solves the problem.
> unfortunately the exception handling in this case is not good - the message 
> is only "Somehing went wrong.", because the ClassNotFound exception was 
> swallowed in ClassUtil.getInitializationExpression method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (FELIX-1850) Expose additional isRoot attribute on AdminServiceMBean

2009-11-16 Thread Guillaume Nodet (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-1850.


Resolution: Fixed
  Assignee: Guillaume Nodet

Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/Instance.java
Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/internal/AdminServiceImpl.java
Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/internal/InstanceImpl.java
Sending
karaf/admin/management/src/main/java/org/apache/felix/karaf/admin/management/AdminServiceMBean.java
Sending
karaf/admin/management/src/main/java/org/apache/felix/karaf/admin/management/codec/JmxInstance.java
Sending
karaf/admin/management/src/test/java/org/apache/felix/karaf/admin/management/codec/JmxInstanceTest.java
Sending
karaf/admin/management/src/test/java/org/apache/felix/karaf/admin/management/internal/AdminServiceMBeanImplTest.java
Sendingkaraf/main/src/main/java/org/apache/felix/karaf/main/Main.java
Transmitting file data 
Committed revision 880721.


> Expose additional isRoot attribute on AdminServiceMBean
> ---
>
> Key: FELIX-1850
> URL: https://issues.apache.org/jira/browse/FELIX-1850
> Project: Felix
>  Issue Type: Task
>Affects Versions: karaf-1.0.0
>Reporter: Eoghan Glynn
>Assignee: Guillaume Nodet
> Fix For: karaf-1.2.0
>
>
> Currently determining if an instance is the root instance depends on the 
> karaf.name not having been over-ridden from "root" to some other value. 
> It would be useful to provide this information explicitly via a new isRoot 
> attribute 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (FELIX-1849) Provide Instance details for root instance via AdminServiceMBean.getInstances() attribute

2009-11-16 Thread Guillaume Nodet (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved FELIX-1849.


Resolution: Fixed

Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/Instance.java
Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/internal/AdminServiceImpl.java
Sending
karaf/admin/core/src/main/java/org/apache/felix/karaf/admin/internal/InstanceImpl.java
Sending
karaf/admin/management/src/main/java/org/apache/felix/karaf/admin/management/AdminServiceMBean.java
Sending
karaf/admin/management/src/main/java/org/apache/felix/karaf/admin/management/codec/JmxInstance.java
Sending
karaf/admin/management/src/test/java/org/apache/felix/karaf/admin/management/codec/JmxInstanceTest.java
Sending
karaf/admin/management/src/test/java/org/apache/felix/karaf/admin/management/internal/AdminServiceMBeanImplTest.java
Sendingkaraf/main/src/main/java/org/apache/felix/karaf/main/Main.java
Transmitting file data 
Committed revision 880721.


> Provide Instance details for root instance via 
> AdminServiceMBean.getInstances() attribute
> -
>
> Key: FELIX-1849
> URL: https://issues.apache.org/jira/browse/FELIX-1849
> Project: Felix
>  Issue Type: Task
>Affects Versions: karaf-1.0.0
>Reporter: Eoghan Glynn
>Assignee: Guillaume Nodet
> Fix For: karaf-1.2.0
>
> Attachments: felix_1849.patch
>
>
> Currently only child instances are reported via this tabular data, with the 
> result that the ssh port for the root instance is not available via JMX.
> An additional Instance should be included in this list to represent root.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (FELIX-1849) Provide Instance details for root instance via AdminServiceMBean.getInstances() attribute

2009-11-16 Thread Guillaume Nodet (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned FELIX-1849:
--

Assignee: Guillaume Nodet

> Provide Instance details for root instance via 
> AdminServiceMBean.getInstances() attribute
> -
>
> Key: FELIX-1849
> URL: https://issues.apache.org/jira/browse/FELIX-1849
> Project: Felix
>  Issue Type: Task
>Affects Versions: karaf-1.0.0
>Reporter: Eoghan Glynn
>Assignee: Guillaume Nodet
> Fix For: karaf-1.2.0
>
> Attachments: felix_1849.patch
>
>
> Currently only child instances are reported via this tabular data, with the 
> result that the ssh port for the root instance is not available via JMX.
> An additional Instance should be included in this list to represent root.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1868) DM/ NullObject improvement

2009-11-16 Thread Marcel Offermans (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778250#action_12778250
 ] 

Marcel Offermans commented on FELIX-1868:
-

A couple of comments here:

1) Of course one can argue, but I would not return new Date(), which is the 
*current* date, as the default for a date that has not been supplied, but use 
new Date(0) instead (the oldest possible date). Admittedly the Date class is 
one of the most broken ones in the JDK. :)

This should be easy to fix.

2) Adding new interface types to a static map means that a reference to these 
types stays in memory forever which hurts the ability to unload these classes 
after an update.

Because of this I don't want to apply this as is.

3) I am a bit worried about adding recursion to the NullObject when it comes to 
returning itself.

Needs further discussion, but if we can find cases where this leads to infinite 
recursion, I don't think that's good behaviour for the "default" null object.

Of course, there always is the option to supply your own "default 
implementation" in specialized cases where you *know* these things are not an 
issue.


> DM/ NullObject improvement
> --
>
> Key: FELIX-1868
> URL: https://issues.apache.org/jira/browse/FELIX-1868
> Project: Felix
>  Issue Type: Improvement
>  Components: Dependency Manager
>Affects Versions: dependencymanager-2.0.1
>Reporter: Pierre De Rop
>Priority: Minor
> Attachments: DefaultNullObject.java
>
>
> Here are three improvements concerning the Default NullObject in DM:
> 1) support for a default Date return type
> 2) support for a default String return type
> 3) return a NullObject for method whose return type is not a primitive type.
> For example, currently, the following "MyService.getSomething()" method can't 
> return a NullObject with the current DefaultNullObject: class:
> interface MyService {
>Something getSomething();
> }
> interface Something {
> }
> 
> See attached patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.