Re: [VOTE] Release fileinstall 2.0.6

2009-12-21 Thread Carsten Ziegeler
+1

Carsten

Guillaume Nodet wrote:
 Release Notes - Felix - Version fileinstall-2.0.6
 ** Bug
 * [FELIX-1775] - fileinstall release archives contains an empty
 load folder which should be removed
 * [FELIX-1789] - FileInstall is too verbose
 * [FELIX-1851] - FileInstall watched bundles are restarted twice upon 
 update
 * [FELIX-1861] - FileInstall created temp directories are never deleted
 * [FELIX-1862] - fileinstall thread name as printed in log
 messages need to be less verbose
 * [FELIX-1928] - File installer starts bundles too early on restart
 ** Task
 * [FELIX-1811] - fileinstall should depend on the official osgi artifacts
 
 Staging repository:
 https://repository.apache.org/content/repositories/felix-staging-054/
 
 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
 
 Usage:
 sh check_staged_release.sh 054 /tmp/felix-staging
 
 Please vote to approve this release:
 
 [ ] +1 Approve the release
 [ ] -1 Veto the release (please provide specific comments)
 
 This vote will be open for 72 hours.
 


-- 
Carsten Ziegeler
cziege...@apache.org


[RESULT] [VOTE] Release Felix SCR version 1.4.0

2009-12-21 Thread Felix Meschberger

Hi all,

Time to tally the vote. We have received the following votes:

  +1 Felix Meschberger (*)
  +1 Carsten Ziegeler (*)
  +1 Rob Walker (*)
  +1 David Bosschaert
  +1 Pierre De Rop
  +1 Richard S. Hall (*)

Thus this vote passes with 6 +1 votes (4 of which binding). No other 
votes have been cast.


I will proceed publishing the artifacts.

Regards
Felix

On 15.12.2009 10:11, Felix Meschberger wrote:

Hi,

Here is the Apache Felix Declarative Services implementation version
1.4.0 release. This release consists of bug fixes and two notable
enhancements:

   FELIX-1893 Add update callback support to inform components of
modified service properties. This has also been reported to
the OSGi as an enhancment.

   FELIX-1897 Add proper Configuration Admin support for SCR
configuration.

As a consequence of FELIX-1893 the org.apache.felix.scr package is now
exported as version 1.4 (one method added to the Reference interface)
and the bundle is released as version 1.4.0

We solved 13 issues in this release:
https://issues.apache.org/jira/browse/FELIX/fixforversion/12314356

There is one outstanding issue:
https://issues.apache.org/jira/browse/FELIX/component/12310349

Staging repository:
https://repository.apache.org/content/repositories/orgapachefelix-047/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 047 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Don't the release (please provide specific comments)

This vote will be open for 72 hours.

Regards
Felix




Re: [VOTE] Release fileinstall 2.0.6

2009-12-21 Thread Felix Meschberger

+1

Regards
Felix

On 17.12.2009 11:06, Guillaume Nodet wrote:

Release Notes - Felix - Version fileinstall-2.0.6
** Bug
 * [FELIX-1775] - fileinstall release archives contains an empty
load folder which should be removed
 * [FELIX-1789] - FileInstall is too verbose
 * [FELIX-1851] - FileInstall watched bundles are restarted twice upon 
update
 * [FELIX-1861] - FileInstall created temp directories are never deleted
 * [FELIX-1862] - fileinstall thread name as printed in log
messages need to be less verbose
 * [FELIX-1928] - File installer starts bundles too early on restart
** Task
 * [FELIX-1811] - fileinstall should depend on the official osgi artifacts

Staging repository:
https://repository.apache.org/content/repositories/felix-staging-054/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 054 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote will be open for 72 hours.



[jira] Created: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Valentin Valchev (JIRA)
Collect duplicate  reusable code in WebConsoleUtil
---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Priority: Trivial


I've looked at the Web Console code and found some common methods that are used 
in the plugins. These methods can be reused by third party plugins and it would 
be nice, if they are exported as new class WebConsoleUtil.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1956:


Attachment: eclipse-warnings-duplicate-code.patch

I'm attaching a patch that:
* adds WebConsoleUtil class with static utility methods.
* getParameter  sendRedirect from AbstractWebConsolePlugin are moved to that 
class, the original methods are deprecated.
* fixed a lot of eclipse warnings - this is mostly javadoc code, undocumented 
blocks or spelling errors.

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Priority: Trivial
 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Valentin Valchev (JIRA)
Make Web Console compatible with OSGi/Minimum-1.0 EE


 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
Reporter: Valentin Valchev


Currently the Web Console requires some methods that are JDK 1.4+ specific.
In some embedded JVM the methods are not available. 
However, it's not needed to sync with each embedded JVM but make sure to run at 
least at OSGi/Minimum-1.0 Execution Environment.

The problem methods are:
String.matches(pattern);   (LicenseServlet  BundlesServlet)
String.replaceAll();  (ConfigurationRender)
String.split();(BundleRepositoryRender)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1957:


Attachment: mathes-patch.patch

The attached 'matches-patch.patch' fixes the usage of
String.matches(pattern) in BundlesServlet

The usage of String.replaceAll() in ConfigurationRender can be replaced by 
WebConsoleUtil.escapeHtml()
(see https://issues.apache.org/jira/browse/FELIX-1956)

 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
Reporter: Valentin Valchev
 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1957:


Description: 
Currently the Web Console requires some methods that are JDK 1.4+ specific.
In some embedded JVM the methods are not available. 
However, it's not needed to sync with each embedded JVM but make sure to run at 
least at OSGi/Minimum-1.0 Execution Environment.

The problem methods are:
String.matches(pattern);   (LicenseServlet  BundlesServlet)
String.replaceAll();  (ConfigurationRender)
String.split();(BundleRepositoryRender)

The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
ConfigurationListener.

  was:
Currently the Web Console requires some methods that are JDK 1.4+ specific.
In some embedded JVM the methods are not available. 
However, it's not needed to sync with each embedded JVM but make sure to run at 
least at OSGi/Minimum-1.0 Execution Environment.

The problem methods are:
String.matches(pattern);   (LicenseServlet  BundlesServlet)
String.replaceAll();  (ConfigurationRender)
String.split();(BundleRepositoryRender)



 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
Reporter: Valentin Valchev
 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Valentin Valchev (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793207#action_12793207
 ] 

Valentin Valchev edited comment on FELIX-1957 at 12/21/09 2:19 PM:
---

The attached 'matches-patch.patch' fixes the usage of
String.matches(pattern) in BundlesServlet

The usage of String.replaceAll() in ConfigurationRender can be replaced by 
WebConsoleUtil.escapeHtml()
(see https://issues.apache.org/jira/browse/FELIX-1956 )

  was (Author: v_valchev):
The attached 'matches-patch.patch' fixes the usage of
String.matches(pattern) in BundlesServlet

The usage of String.replaceAll() in ConfigurationRender can be replaced by 
WebConsoleUtil.escapeHtml()
(see https://issues.apache.org/jira/browse/FELIX-1956)
  
 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Reporter: Valentin Valchev
 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1957:


Component/s: Web Console

 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Reporter: Valentin Valchev
 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1958) Branding LF issues

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1958:


Description: 
Currently the heading of the Apache Web Console consists of:

Left:
Admin Title
Plugin Title

Right:
Vendor Logo

Unfortunately the Admin Title cannot be changed, unless the bundles are 
modified. And in case, when we install Karaf with branding support, opening the 
bundles tab we see the following headings on left:


Apache Felix Web Management Console
Bundle


When opening the Karaf Admin we see:

Apache Felix Karaf :: Web Console :: Admin
Admin


(The attached image shows the visual inconsistency)

What about changing the Admin Title to Product Title. So, when the Web 
Console is installed in a product like Karaf the top-most title will be always 
consistent and more-over, you will always know that you work with a specific 
product. In this case the previous examples might look this way:


Karaf Web Management Console
Bundles

Karaf Web Management Console
Karaf :: Admin



The change can be easily implement by changing the 
AbstractWebConsolePlugin.startResponse() method by replacing the
'adminTitle' with brandingPlugin.getBrandName() or 
brandingPlugin.getProductName().

This way we will also eliminate the need of reading the Bundle-Name manifest 
header for each plug-in.

  was:
Currently the heading of the Apache Web Console consists of:

Left:
Admin Title
Plugin Title

Right:
Vendor Logo

Unfortunately the Admin Title cannot be changed, unless the bundles are 
modified. And in case, when we install Karaf with branding support, opening the 
bundles tab we see the following headings on left:


Apache Felix Web Management Console
Bundle


When opening the Karaf Admin we see:

Apache Felix Karaf :: Web Console :: Admin
Admin


What about changing the Admin Title to Product Title. So, when the Web 
Console is installed in a product like Karaf the top-most title will be always 
consistent and more-over, you will always know that you work with a specific 
product. In this case the previous examples might look this way:


Karaf Web Management Console
Bundles

Karaf Web Management Console
Karaf :: Admin



The change can be easily implement by changing the 
AbstractWebConsolePlugin.startResponse() method by replacing the
'adminTitle' with brandingPlugin.getBrandName() or 
brandingPlugin.getProductName().

This way we will also eliminate the need of reading the Bundle-Name manifest 
header for each plug-in.


 Branding LF issues 
 

 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Priority: Minor
 Attachments: branding-title.png


 Currently the heading of the Apache Web Console consists of:
 Left:
 Admin Title
 Plugin Title
 Right:
 Vendor Logo
 Unfortunately the Admin Title cannot be changed, unless the bundles are 
 modified. And in case, when we install Karaf with branding support, opening 
 the bundles tab we see the following headings on left:
 
 Apache Felix Web Management Console
 Bundle
 
 When opening the Karaf Admin we see:
 
 Apache Felix Karaf :: Web Console :: Admin
 Admin
 
 (The attached image shows the visual inconsistency)
 What about changing the Admin Title to Product Title. So, when the Web 
 Console is installed in a product like Karaf the top-most title will be 
 always consistent and more-over, you will always know that you work with a 
 specific product. In this case the previous examples might look this way:
 
 Karaf Web Management Console
 Bundles
 
 Karaf Web Management Console
 Karaf :: Admin
 
 The change can be easily implement by changing the 
 AbstractWebConsolePlugin.startResponse() method by replacing the
 'adminTitle' with brandingPlugin.getBrandName() or 
 brandingPlugin.getProductName().
 This way we will also eliminate the need of reading the Bundle-Name manifest 
 header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (FELIX-1958) Branding LF issues

2009-12-21 Thread Valentin Valchev (JIRA)
Branding LF issues 


 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Priority: Minor
 Attachments: branding-title.png

Currently the heading of the Apache Web Console consists of:

Left:
Admin Title
Plugin Title

Right:
Vendor Logo

Unfortunately the Admin Title cannot be changed, unless the bundles are 
modified. And in case, when we install Karaf with branding support, opening the 
bundles tab we see the following headings on left:


Apache Felix Web Management Console
Bundle


When opening the Karaf Admin we see:

Apache Felix Karaf :: Web Console :: Admin
Admin


What about changing the Admin Title to Product Title. So, when the Web 
Console is installed in a product like Karaf the top-most title will be always 
consistent and more-over, you will always know that you work with a specific 
product. In this case the previous examples might look this way:


Karaf Web Management Console
Bundles

Karaf Web Management Console
Karaf :: Admin



The change can be easily implement by changing the 
AbstractWebConsolePlugin.startResponse() method by replacing the
'adminTitle' with brandingPlugin.getBrandName() or 
brandingPlugin.getProductName().

This way we will also eliminate the need of reading the Bundle-Name manifest 
header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1958) Branding LF issues

2009-12-21 Thread Valentin Valchev (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Valentin Valchev updated FELIX-1958:


Attachment: branding-title.png

 Branding LF issues 
 

 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Priority: Minor
 Attachments: branding-title.png


 Currently the heading of the Apache Web Console consists of:
 Left:
 Admin Title
 Plugin Title
 Right:
 Vendor Logo
 Unfortunately the Admin Title cannot be changed, unless the bundles are 
 modified. And in case, when we install Karaf with branding support, opening 
 the bundles tab we see the following headings on left:
 
 Apache Felix Web Management Console
 Bundle
 
 When opening the Karaf Admin we see:
 
 Apache Felix Karaf :: Web Console :: Admin
 Admin
 
 What about changing the Admin Title to Product Title. So, when the Web 
 Console is installed in a product like Karaf the top-most title will be 
 always consistent and more-over, you will always know that you work with a 
 specific product. In this case the previous examples might look this way:
 
 Karaf Web Management Console
 Bundles
 
 Karaf Web Management Console
 Karaf :: Admin
 
 The change can be easily implement by changing the 
 AbstractWebConsolePlugin.startResponse() method by replacing the
 'adminTitle' with brandingPlugin.getBrandName() or 
 brandingPlugin.getProductName().
 This way we will also eliminate the need of reading the Bundle-Name manifest 
 header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release fileinstall 2.0.6

2009-12-21 Thread Richard S. Hall
Strange. I wasn't able to verify the signatures just now using the 
provided script...


- richard

On 12/17/09 5:06, Guillaume Nodet wrote:

Release Notes - Felix - Version fileinstall-2.0.6
** Bug
 * [FELIX-1775] - fileinstall release archives contains an empty
load folder which should be removed
 * [FELIX-1789] - FileInstall is too verbose
 * [FELIX-1851] - FileInstall watched bundles are restarted twice upon 
update
 * [FELIX-1861] - FileInstall created temp directories are never deleted
 * [FELIX-1862] - fileinstall thread name as printed in log
messages need to be less verbose
 * [FELIX-1928] - File installer starts bundles too early on restart
** Task
 * [FELIX-1811] - fileinstall should depend on the official osgi artifacts

Staging repository:
https://repository.apache.org/content/repositories/felix-staging-054/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 054 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote will be open for 72 hours.

   


[jira] Assigned: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger reassigned FELIX-1956:


Assignee: Felix Meschberger

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Trivial
 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1958) Branding LF issues

2009-12-21 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793250#action_12793250
 ] 

Felix Meschberger commented on FELIX-1958:
--

Thanks for reporting the issue and proposing a fix. This makes perfect sense 
IMO.

 Branding LF issues 
 

 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Priority: Minor
 Fix For: webconsole-2.0.6

 Attachments: branding-title.png


 Currently the heading of the Apache Web Console consists of:
 Left:
 Admin Title
 Plugin Title
 Right:
 Vendor Logo
 Unfortunately the Admin Title cannot be changed, unless the bundles are 
 modified. And in case, when we install Karaf with branding support, opening 
 the bundles tab we see the following headings on left:
 
 Apache Felix Web Management Console
 Bundle
 
 When opening the Karaf Admin we see:
 
 Apache Felix Karaf :: Web Console :: Admin
 Admin
 
 (The attached image shows the visual inconsistency)
 What about changing the Admin Title to Product Title. So, when the Web 
 Console is installed in a product like Karaf the top-most title will be 
 always consistent and more-over, you will always know that you work with a 
 specific product. In this case the previous examples might look this way:
 
 Karaf Web Management Console
 Bundles
 
 Karaf Web Management Console
 Karaf :: Admin
 
 The change can be easily implement by changing the 
 AbstractWebConsolePlugin.startResponse() method by replacing the
 'adminTitle' with brandingPlugin.getBrandName() or 
 brandingPlugin.getProductName().
 This way we will also eliminate the need of reading the Bundle-Name manifest 
 header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1958) Branding LF issues

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger updated FELIX-1958:
-

Affects Version/s: webconsole-2.0.4
Fix Version/s: webconsole-2.0.6

 Branding LF issues 
 

 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Minor
 Fix For: webconsole-2.0.6

 Attachments: branding-title.png


 Currently the heading of the Apache Web Console consists of:
 Left:
 Admin Title
 Plugin Title
 Right:
 Vendor Logo
 Unfortunately the Admin Title cannot be changed, unless the bundles are 
 modified. And in case, when we install Karaf with branding support, opening 
 the bundles tab we see the following headings on left:
 
 Apache Felix Web Management Console
 Bundle
 
 When opening the Karaf Admin we see:
 
 Apache Felix Karaf :: Web Console :: Admin
 Admin
 
 (The attached image shows the visual inconsistency)
 What about changing the Admin Title to Product Title. So, when the Web 
 Console is installed in a product like Karaf the top-most title will be 
 always consistent and more-over, you will always know that you work with a 
 specific product. In this case the previous examples might look this way:
 
 Karaf Web Management Console
 Bundles
 
 Karaf Web Management Console
 Karaf :: Admin
 
 The change can be easily implement by changing the 
 AbstractWebConsolePlugin.startResponse() method by replacing the
 'adminTitle' with brandingPlugin.getBrandName() or 
 brandingPlugin.getProductName().
 This way we will also eliminate the need of reading the Bundle-Name manifest 
 header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (FELIX-1958) Branding LF issues

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger reassigned FELIX-1958:


Assignee: Felix Meschberger

 Branding LF issues 
 

 Key: FELIX-1958
 URL: https://issues.apache.org/jira/browse/FELIX-1958
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Minor
 Fix For: webconsole-2.0.6

 Attachments: branding-title.png


 Currently the heading of the Apache Web Console consists of:
 Left:
 Admin Title
 Plugin Title
 Right:
 Vendor Logo
 Unfortunately the Admin Title cannot be changed, unless the bundles are 
 modified. And in case, when we install Karaf with branding support, opening 
 the bundles tab we see the following headings on left:
 
 Apache Felix Web Management Console
 Bundle
 
 When opening the Karaf Admin we see:
 
 Apache Felix Karaf :: Web Console :: Admin
 Admin
 
 (The attached image shows the visual inconsistency)
 What about changing the Admin Title to Product Title. So, when the Web 
 Console is installed in a product like Karaf the top-most title will be 
 always consistent and more-over, you will always know that you work with a 
 specific product. In this case the previous examples might look this way:
 
 Karaf Web Management Console
 Bundles
 
 Karaf Web Management Console
 Karaf :: Admin
 
 The change can be easily implement by changing the 
 AbstractWebConsolePlugin.startResponse() method by replacing the
 'adminTitle' with brandingPlugin.getBrandName() or 
 brandingPlugin.getProductName().
 This way we will also eliminate the need of reading the Bundle-Name manifest 
 header for each plug-in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793251#action_12793251
 ] 

Felix Meschberger commented on FELIX-1956:
--

Thanks for reporting the issue and proposing a patch. At first read, this makes 
perfect sense.

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Trivial
 Fix For: webconsole-2.0.6

 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger reassigned FELIX-1957:


Assignee: Felix Meschberger

 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.6

 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger updated FELIX-1957:
-

Affects Version/s: webconsole-2.0.4
Fix Version/s: webconsole-2.0.6

 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.6

 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil

2009-12-21 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger updated FELIX-1956:
-

Affects Version/s: webconsole-2.0.4
Fix Version/s: webconsole-2.0.6

 Collect duplicate  reusable code in WebConsoleUtil
 ---

 Key: FELIX-1956
 URL: https://issues.apache.org/jira/browse/FELIX-1956
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
Priority: Trivial
 Fix For: webconsole-2.0.6

 Attachments: eclipse-warnings-duplicate-code.patch


 I've looked at the Web Console code and found some common methods that are 
 used in the plugins. These methods can be reused by third party plugins and 
 it would be nice, if they are exported as new class WebConsoleUtil.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE

2009-12-21 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793252#action_12793252
 ] 

Felix Meschberger commented on FELIX-1957:
--

Thanks for reporting this issue and proposing workarounds and a patch.

 Make Web Console compatible with OSGi/Minimum-1.0 EE
 

 Key: FELIX-1957
 URL: https://issues.apache.org/jira/browse/FELIX-1957
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Valentin Valchev
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.6

 Attachments: mathes-patch.patch


 Currently the Web Console requires some methods that are JDK 1.4+ specific.
 In some embedded JVM the methods are not available. 
 However, it's not needed to sync with each embedded JVM but make sure to run 
 at least at OSGi/Minimum-1.0 Execution Environment.
 The problem methods are:
 String.matches(pattern);   (LicenseServlet  BundlesServlet)
 String.replaceAll();  (ConfigurationRender)
 String.split();(BundleRepositoryRender)
 The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the 
 ConfigurationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1898) Extend SCR Plugin to support new updated method declaration

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1898.
---


 Extend SCR Plugin to support new updated method declaration
 ---

 Key: FELIX-1898
 URL: https://issues.apache.org/jira/browse/FELIX-1898
 Project: Felix
  Issue Type: Sub-task
  Components: Maven SCR Plugin, SCR Annotations
Affects Versions: maven-scr-plugin-1.4.0, scr annotations 1.0.0
Reporter: Felix Meschberger
Assignee: Carsten Ziegeler
 Fix For: maven-scr-plugin-1.4.2, scr annotations 1.2.0

 Attachments: FELIX-1898-annotations.patch, FELIX-1898.patch


 Provided FELIX-1893 is being implemented, the Maven SCR plugin must be 
 enhanced to support the new updated method:
* basically support the method if explicitly declared
* automatically set namespace if updated method is declared
* implement automatic method detection (similar to bind/unbind method 
 detection)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1800) Bound configurations for which there exists no bundle cannot be edited

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1800.
---


 Bound configurations for which there exists no bundle cannot be edited
 --

 Key: FELIX-1800
 URL: https://issues.apache.org/jira/browse/FELIX-1800
 Project: Felix
  Issue Type: Bug
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 Consider a configuration bound to a certain bundle [location]. If there is no 
 bundle installed with that bundle location, the configuration cannot be 
 edited event though there might be metatype information.
 The problem is that (1) metatype information is only retrieved for the bundle 
 named by the bundle location. It should probably be searched globally. (2) 
 the configuration detail information fails with a NullPointerException if 
 there is no bundle with the bound location installed.
 Another issue is, that existing configuration for which no metatype exists is 
 not listed in the drop-down, even though it can be rendered. The problem is 
 an erratic (probably historic) check for metatype information, which is not 
 really required.
 Finally, the configuration properties are not displayed if there is no 
 metatype information because the client side rendering script does not attach 
 the respect HTML elements to the parent element.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1884) WebConsole should have a Services plugin

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1884.
---


 WebConsole should have a Services plugin
 

 Key: FELIX-1884
 URL: https://issues.apache.org/jira/browse/FELIX-1884
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Justin Edelson
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4

 Attachments: FELIX-1884.patch, FELIX-1884a.png, FELIX-1884b.png




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1894) Show more fragment information in bundle details

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1894.
---


 Show more fragment information in bundle details
 

 Key: FELIX-1894
 URL: https://issues.apache.org/jira/browse/FELIX-1894
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 Currently the only fragment information of a bundle is, the fact that a 
 bundle might be a fragment. It would be interesting to also display the 
 following information available from the PackageAdmin service:
* If a bundle is a fragment list the host to which the fragment is attached
* If a (host) bundle has attached fragments these fragments should be 
 listed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1808) Support unbinding configurations through the Web Console

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1808.
---


 Support unbinding configurations through the Web Console
 

 Key: FELIX-1808
 URL: https://issues.apache.org/jira/browse/FELIX-1808
 Project: Felix
  Issue Type: New Feature
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 There are times where configurations exist in the system which are bound to 
 bundles which do not exist any more. This may for example happen if a bundle 
 is being uninstalled while the Configuration Admin service is not running. 
 Another cause might be explicit configuration binding as per a call to 
 Configuration.setBundleLocation() as the trunk version of Apache Felix SCR 
 does. A Bundle location set in this way is not removed even if the bundle is 
 uninstalled.
 To fix these issues, it would be helpfull if the web console would allow 
 explicit unbinding of configurations by calling 
 Configuration.setBundleLocation() with a null location. This does not cause 
 configurations to actually be removed from any ManagedService[Factory] 
 services or DS components. In fact the configuration will be bound again once 
 it assigned. But in case of wrong bundle bindings, the configuration may 
 afterwards be used again by components now located in bundles with a 
 different bundle location.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1912) Bundles without categories are never displayed in the bundle repository list

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1912.
---


 Bundles without categories are never displayed in the bundle repository list
 

 Key: FELIX-1912
 URL: https://issues.apache.org/jira/browse/FELIX-1912
 Project: Felix
  Issue Type: Bug
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 Reported by Gerry Woods on the dev list:
  Hi,
  It seems that the WebConsole OSGi Repository page will only display OBR
  resources that have a category defined.  We do not define categories so none
  of our bundles show up.  Is there a reason for this or is it simply a bug?
  Thanks for any insights,
  Gerry
 Issue is, that bundles without any categories are never listed. It also looks 
 like the selection code is suboptimal: if all categories are desired, we 
 don't have to inspect the bundle categories, we just list the bundle.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1895) Show configuration property names in configuration forms

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1895.
---


 Show configuration property names in configuration forms
 

 Key: FELIX-1895
 URL: https://issues.apache.org/jira/browse/FELIX-1895
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 In some situations it would be helpful to have the configuration property 
 names displayed in the configuration forms along with the metatype service 
 descriptions. This could for example be done by adding this information in 
 parentheses after the descriptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1916) Rename Location label to Bundle Location in the bundle details display

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1916.
---


 Rename Location label to Bundle Location in the bundle details display
 --

 Key: FELIX-1916
 URL: https://issues.apache.org/jira/browse/FELIX-1916
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: webconsole-2.0.4


 As discussed in FELIX-1758.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1930) Clicking action on bundles detail page shows full bundle list while URL stays on bundles/id

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1930.
---


 Clicking action on bundles detail page shows full bundle list while URL stays 
 on bundles/id
 -

 Key: FELIX-1930
 URL: https://issues.apache.org/jira/browse/FELIX-1930
 Project: Felix
  Issue Type: Bug
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Alexander Klimetschek
Assignee: Carsten Ziegeler
Priority: Minor
 Fix For: webconsole-2.0.4


 1. Go to webconsole, click on a bundle to go to its detail page (eg. 
 /system/bundles/1)
 2. Click on any action (stop/start/uninstall etc.)
 Problem:
 = The content of the page will switch to the list of all bundles (like 
 /system/bundles) but the URL stays on /system/bundles/1
 Expected:
 = Only the bundle detail content is refreshed (reflecting the status change 
 from the action), URL stays on /system/bundles/1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1931) Keep sort order of bundle list across page reloads (eg. in a cookie)

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1931.
---


 Keep sort order of bundle list across page reloads (eg. in a cookie)
 

 Key: FELIX-1931
 URL: https://issues.apache.org/jira/browse/FELIX-1931
 Project: Felix
  Issue Type: Improvement
  Components: Web Console
Affects Versions: webconsole-2.0.2
Reporter: Alexander Klimetschek
Assignee: Carsten Ziegeler
Priority: Minor
 Fix For: webconsole-2.0.4


 A typical use case is that I set the sort order of the bundle list so that it 
 shows me the non-active bundles (e.g. the ones that make problems because of 
 unresolved dependencies etc.) first. When installing and restarting bundles I 
 find myself refreshing the bundles page very often, so that it would be nice 
 if the list would keep the sort order.
 This could for example be done by storing the sort state in a cookie.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1685) Cleanup dependencies

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1685.
---


 Cleanup dependencies
 

 Key: FELIX-1685
 URL: https://issues.apache.org/jira/browse/FELIX-1685
 Project: Felix
  Issue Type: Improvement
  Components: Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.4.0
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: maven-scr-plugin-1.4.2


 The Maven SCR plugin currently has a number of dependencies, which are not 
 used and we should (probably) also depend on the official OSGi R4.0 API 
 libraries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1708) Improve error reporting

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1708.
---


 Improve error reporting
 ---

 Key: FELIX-1708
 URL: https://issues.apache.org/jira/browse/FELIX-1708
 Project: Felix
  Issue Type: Improvement
  Components: Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.4.0
Reporter: Felix Meschberger
Assignee: Felix Meschberger
 Fix For: maven-scr-plugin-1.4.2


 Currently error reporting in the Maven SCR Plugin is rather straightforward 
 supporting only string messages.
 Now, that the SCR Plugin can be used outside of the Maven scope where more 
 functionality may be provided, a more detailed error reporting mechanism 
 might make sense. Specifically, support for providing three part messages 
 (source, line number, message) would be very helpfull in certain situations 
 and would also allow for a more standardized log formatting in the maven case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1819) Problem with dependencies resolution

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1819.
---


 Problem with dependencies resolution
 

 Key: FELIX-1819
 URL: https://issues.apache.org/jira/browse/FELIX-1819
 Project: Felix
  Issue Type: Bug
  Components: Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.2.0
Reporter: Rembert Magri
Assignee: Carsten Ziegeler
 Fix For: maven-scr-plugin-1.4.2

 Attachments: JavaClassDescriptorManager.java


 When adding dependencies with provided scope, the plugin cannot find the 
 bundle correctly. I fixed the problem by changing the getManifest and getFile 
 methods as follows:
 protected Manifest getManifest(Artifact artifact) throws IOException {
   if (!this.isJavaArtifact(artifact)) {
   throw new IllegalArgumentException(Trying to load Manifest 
 from a non-Java type);
   }
   
   if (bundle.equals(artifact.getType())) {
   return getManifestFromBundle(artifact);
   }
   
   return getManifestFromJarFile(artifact);
 
 }
   private Manifest getManifestFromBundle(Artifact artifact)
   throws FileNotFoundException, IOException {
   //artifact.getFile() returns {project}/target/classes, and I 
 want {project}/META-INF/MANIFEST.MF
   File file = getFileFromBundle(artifact, META-INF/MANIFEST.MF);
   FileInputStream manifestInputStream = null;
   try {
   manifestInputStream = new FileInputStream(file);
   return new Manifest(manifestInputStream);
   } finally {
   if (manifestInputStream != null) {
   try {
   manifestInputStream.close();
   } catch (IOException ignore) {
   }
   }
   }
   }
   private Manifest getManifestFromJarFile(Artifact artifact)
   throws IOException {
   JarFile file = null;
   try {
   file = new JarFile(artifact.getFile());
   return file.getManifest();
   } finally {
   if (file != null) {
   try {
   file.close();
   } catch (IOException ignore) {
   }
   }
   }
   }
 protected File getFile(Artifact artifact, String path) throws IOException 
 {
   if (bundle.equals(artifact.getType())) {
   return getFileFromBundle(artifact, path);
   }
   
 return getFileFromJar(artifact, path);
 }
   private File getFileFromBundle(Artifact artifact, String path) throws 
 FileNotFoundException {
   //artifact.getFile() returns {project}/target/classes, and I 
 want {project}/path
   File file = artifact.getFile();
   File targetFile = new 
 File(file.getParentFile().getParentFile(),path);
   if (targetFile.canRead()) {
   return targetFile;
   }
   log.warn(Won't be able to read:  + targetFile);
   return null;
   }
   private File getFileFromJar(Artifact artifact, String path)
   throws IOException, FileNotFoundException {
   final int pos = path.lastIndexOf('.');
 final String suffix = path.substring(pos + 1);
 JarFile file = null;
 File tmpFile = null;
 try {
 file = new JarFile(artifact.getFile());
 final JarEntry entry = file.getJarEntry(path);
 if ( entry != null ) {
 tmpFile = File.createTempFile(scrjcdm + 
 artifact.getArtifactId(), suffix);
 tmpFile.deleteOnExit();
 final FileOutputStream fos = new FileOutputStream(tmpFile);
 IOUtil.copy(file.getInputStream(entry), fos);
 IOUtil.close(fos);
 return tmpFile;
 }
 return null;
 } finally {
 if (file != null) {
 try {
 file.close();
 } catch (IOException ignore) {
 }
 }
 }
   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1703) SCR Plugin not always recognizes correctly to switch into DS 1.1 descriptor mode

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1703.
---


 SCR Plugin not always recognizes correctly to switch into DS 1.1 descriptor 
 mode
 

 Key: FELIX-1703
 URL: https://issues.apache.org/jira/browse/FELIX-1703
 Project: Felix
  Issue Type: Improvement
  Components: Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.4.0
Reporter: Felix Meschberger
 Fix For: maven-scr-plugin-1.4.2


 Given a simple component like this:
 /**
  * @scr.component activate=newActivate deactivate=newDeactivate
  * @scr.property name=sample value=Sample Value
  */
 public class SampleComponent {
 private final Logger log = LoggerFactory.getLogger(getClass());
 protected void activate(Map?, ? config) {
 log.info(Component {} starting, config.get(component.name));
 }
 protected void deactivate(Map?, ? config, int reason) {
 log.info(Component {} stopping, reason: {}, 
 config.get(component.name), reason);
 }
 }
 The Maven SCR plugin in this case does not accept the signatures of the 
 activate and deactivate methods to require a DS 1.1 descriptor.
 Maybe, for backwards compatibility with existing source, it is also better to 
 not switch into a DS 1.1 descriptor: There might be code where methods with 
 signatures newly supported by DS 1.1 should not be used. In this case it 
 would be good to be able to explicitly declare the component to be a DS 1.1 
 compliant component.
 Currently it is not possible to specify this on a per-component level. It is 
 only possible per plugin configuration or by having the plugin detect a DS 
 1.1 feature, such as the activate or deactivate attribute to the 
 @scr.component tag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1845) Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1845.
---


 Unclear exception being thrown: java.lang.ArrayIndexOutOfBoundsException: 0
 ---

 Key: FELIX-1845
 URL: https://issues.apache.org/jira/browse/FELIX-1845
 Project: Felix
  Issue Type: Bug
  Components: Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.4.0
Reporter: Geert Schuring
Assignee: Carsten Ziegeler
 Fix For: maven-scr-plugin-1.4.2

 Attachments: package-info.java


 For some unknown reason my maven-scr-plugin stopped working and throws the 
 following exception:
 [INFO] Scanning for projects...
 [INFO] 
 
 [INFO] Building ipds-service
 [INFO]task-segment: [package]
 [INFO] 
 
 [INFO] [resources:resources {execution: default-resources}]
 [INFO] Using 'UTF-8' encoding to copy filtered resources.
 [INFO] Copying 0 resource
 [INFO] [compiler:compile {execution: default-compile}]
 [INFO] Compiling 3 source files to 
 C:\Users\geert\workspace\nl.interact911.ipds.ipds-service\target\classes
 [INFO] [scr:scr {execution: generate-scr-scrdescriptor}]
 [INFO] 
 
 [ERROR] FATAL ERROR
 [INFO] 
 
 [INFO] 0
 [INFO] 
 
 [INFO] Trace
 java.lang.ArrayIndexOutOfBoundsException: 0
   at 
 org.apache.felix.scrplugin.tags.JavaClassDescriptorManager.getSourceDescriptions(JavaClassDescriptorManager.java:393)
   at 
 org.apache.felix.scrplugin.SCRDescriptorMojo.execute(SCRDescriptorMojo.java:167)
   at 
 org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
   at 
 org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
   at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
   at 
 org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
   at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
   at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
   at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
 [INFO] 
 
 [INFO] Total time: 2 seconds
 [INFO] Finished at: Wed Nov 04 16:46:39 CET 2009
 [INFO] Final Memory: 14M/26M
 [INFO] 
 
 I have no clue why I get this message, and the exception does not have a 
 message that I could use to try to locate the source of the problem. I really 
 hope you can point me in the richt direction by telling me why this exception 
 is being thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (FELIX-1847) Error with duplicates when using maven-bundle-plugin 2.0.1 and maven-scr-plugin 1.4

2009-12-21 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed FELIX-1847.
---


 Error with duplicates when using maven-bundle-plugin 2.0.1 and 
 maven-scr-plugin 1.4
 ---

 Key: FELIX-1847
 URL: https://issues.apache.org/jira/browse/FELIX-1847
 Project: Felix
  Issue Type: Bug
  Components: Maven Bundle Plugin, Maven SCR Plugin
Affects Versions: maven-scr-plugin-1.4.0, maven-bundle-plugin-2.0.1
 Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
 Java version: 1.6.0_15
 Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home
 Default locale: de_DE, platform encoding: MacRoman
 OS name: mac os x version: 10.5.8 arch: x86_64 Family: mac
Reporter: Daniel Bimschas
Assignee: Carsten Ziegeler
 Fix For: maven-scr-plugin-1.4.2

 Attachments: felix-1847-patch


 Experiencing the same problem as Patrick Forhahn who commented after 
 https://issues.apache.org/jira/browse/FELIX-1262 was fixed I asked Stuart 
 McCulloch about the bug. Here is his answer about the issue:
 --
 The underlying effect is the same (Bnd tool appends ~ to duplicate clauses) 
 but the cause is different.
 FELIX-1262 was caused by duplicate clauses in the Include-Resource calculated 
 by the bundleplugin,
 whereas this new issue is caused by duplication of Service-Component clauses 
 by the scrplugin.
  
 Basically duplicate entries should be removed, which is why directly setting 
 ServiceComponent works.
 The question is whether the scrplugin or the bundleplugin should detect and 
 remove the duplicates...
 --
 The reason of error is the same as in Patricks comment:
 [ERROR] Error building bundle 
 org.bjc.es:org.bjc.osgi.foundation.cache:bundle:1.13.0.RC1-SNAPSHOT : 
 Service-Component entry can not be located in JAR: 
 OSGI-INF/serviceComponents.xml~

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release fileinstall 2.0.6

2009-12-21 Thread Chris Custine
Not sure how I missed that, but you are right Richard, the md5 and sha1 sigs
are bad.  I will cut a 2.0.8 release and start a new vote.

Thanks,
Chris

--
Chris Custine
FUSESource :: http://fusesource.com
My Blog :: http://blog.organicelement.com
Apache ServiceMix :: http://servicemix.apache.org
Apache Felix :: http://felix.apache.org
Apache Directory Server :: http://directory.apache.org


On Mon, Dec 21, 2009 at 9:27 AM, Richard S. Hall he...@ungoverned.orgwrote:

 Strange. I wasn't able to verify the signatures just now using the provided
 script...

 - richard


 On 12/17/09 5:06, Guillaume Nodet wrote:

 Release Notes - Felix - Version fileinstall-2.0.6
 ** Bug
 * [FELIX-1775] - fileinstall release archives contains an empty
 load folder which should be removed
 * [FELIX-1789] - FileInstall is too verbose
 * [FELIX-1851] - FileInstall watched bundles are restarted twice upon
 update
 * [FELIX-1861] - FileInstall created temp directories are never
 deleted
 * [FELIX-1862] - fileinstall thread name as printed in log
 messages need to be less verbose
 * [FELIX-1928] - File installer starts bundles too early on restart
 ** Task
 * [FELIX-1811] - fileinstall should depend on the official osgi
 artifacts

 Staging repository:
 https://repository.apache.org/content/repositories/felix-staging-054/

 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 054 /tmp/felix-staging

 Please vote to approve this release:

 [ ] +1 Approve the release
 [ ] -1 Veto the release (please provide specific comments)

 This vote will be open for 72 hours.