[jira] Commented: (FELIX-1792) Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement
[ https://issues.apache.org/jira/browse/FELIX-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799655#action_12799655 ] hehe ji commented on FELIX-1792: Hi Richard, Can you please investigate the hanging? Thanks Emily Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement -- Key: FELIX-1792 URL: https://issues.apache.org/jira/browse/FELIX-1792 Project: Felix Issue Type: Bug Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.4.2 Environment: n/a Reporter: david small99 Assignee: Richard S. Hall Fix For: bundlerepository-1.6.0 I have one bundle bundle1, which imports a package called com.obr.bundle Bundle1's manifest: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle1 Bundle-Version: 1.0.0 Export-Package: com.obr.bundle1 Import-Package: com.obr.bundle;version=[1.2.0.999,3.2.2.bz] There are two bundles in my repositories, bundler2 and bundle 3. Both of them export package com.obr.bundle. Below are their manifest files. Bundle2 Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle2 Bundle-Version: 1.0.0 Bundle-Vendor: xxx Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.2.2.blah Bundle3: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle3 Bundle-Version: 1.0.0 Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.1 As you can see, both bundle2 and bundle3 meet the requirements of bundle1. I hope the highest package version, which is bundle2, is chosen by felix obr. However, sometimes bundle 3 was chosen instead of bundle2. The behaviour is random. Am I right to say that the Felix obr runtime just picks the first bundle that meets the requirements and then stop searching for any more eligible bundles? Thanks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1980) Gogo TelnetShell cannot be activated
[ https://issues.apache.org/jira/browse/FELIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799656#action_12799656 ] Arjun Panday commented on FELIX-1980: - Speaking of which, my patch also introduces a similar osgi.shell.console property (enabled by default to keep things as they were), which could be renamed felix.shell.console or felix.shell.tui or..? but it would be nice to have the possibility to enable telnet only, and not necessarily the StdioConsole. Gogo TelnetShell cannot be activated Key: FELIX-1980 URL: https://issues.apache.org/jira/browse/FELIX-1980 Project: Felix Issue Type: Bug Components: Gogo Reporter: Arjun Panday Priority: Minor Attachments: gogo.tgz Gogo's TelnetShell is implemented as an SCR component but no XML is provided to activate it. /Arjun -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1979) ServletHandlerRequest.getPathInfo() returns undecoded string
[ https://issues.apache.org/jira/browse/FELIX-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799665#action_12799665 ] Felix Meschberger commented on FELIX-1979: -- Reconsidering, I wonder, whether we could not just use the actual servlet container's patchInfo and cut off the servlet alias from the front instead of decoding ourselves ? ServletHandlerRequest.getPathInfo() returns undecoded string Key: FELIX-1979 URL: https://issues.apache.org/jira/browse/FELIX-1979 Project: Felix Issue Type: Bug Components: HTTP Service Affects Versions: http-2.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: http-2.0.6 Attachments: FELIX-1979.patch The Servlet API specifies the HttpServletRequest.getPathInfo() to return a decoded path string. The current implementation just cuts off the servlet context and servlet alias from the request URL (retrieved from HttpServletRequest.getRequestURI()), which is not decoded. Therefore the resulting path info is also not decoded and needs decoding. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (FELIX-1983) WebConsole HttpContext should flush response after setting response status
WebConsole HttpContext should flush response after setting response status -- Key: FELIX-1983 URL: https://issues.apache.org/jira/browse/FELIX-1983 Project: Felix Issue Type: Bug Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: webconsole-2.0.6 The Web Console uses its own HttpContext implementation to handle authentication. When authentication is missing, it sets (or currently sendError) the response status 401/UNAUTHENTICATED but does not flush the response. The Felix Http Base code overwrites this to 403/FORBIDDEN if the response is not committed. So to ensure, the correct status is really sent, the handleSecurity implementation must flush the response. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1983) WebConsole HttpContext should flush response after setting response status
[ https://issues.apache.org/jira/browse/FELIX-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-1983. -- Resolution: Fixed Rev. 898696: Redo sending the 401/UNAUTHORIZED status to just use setStatus and then flush the response. Don't use sendError to prevent any error handlers to kick in -- we really want the 401 status to be sent to the client. WebConsole HttpContext should flush response after setting response status -- Key: FELIX-1983 URL: https://issues.apache.org/jira/browse/FELIX-1983 Project: Felix Issue Type: Bug Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: webconsole-2.0.6 The Web Console uses its own HttpContext implementation to handle authentication. When authentication is missing, it sets (or currently sendError) the response status 401/UNAUTHENTICATED but does not flush the response. The Felix Http Base code overwrites this to 403/FORBIDDEN if the response is not committed. So to ensure, the correct status is really sent, the handleSecurity implementation must flush the response. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (FELIX-1984) Components starts disabled
Components starts disabled
--
Key: FELIX-1984
URL: https://issues.apache.org/jira/browse/FELIX-1984
Project: Felix
Issue Type: Bug
Components: Declarative Services (SCR)
Affects Versions: scr-1.4.0
Environment: felix-2.0.2
Reporter: Artur Opala
From SCR version 1.2.0 all components starts with state 'disabled', SCR 1.0.8
worked fine. Configuration dump attached as zip file.
{code}
0=[pl.eurobank.osgi.springframework.web.SpringServletContextListener]
Bundlepl.eurobank.osgi.springframework-bundle (11)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.ServletContextListener
Properties=
component.id=0
component.name=pl.eurobank.osgi.springframework.web.SpringServletContextListener
service.pid=pl.eurobank.osgi.springframework.web.SpringServletContextListener
1=[pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator]
Bundlepl.eurobank.osgi.launcher-bundle (18)
State=disabled
DefaultState=enabled
Activation=immediate
Reference=bundleProviderService, Satisfied
Service Name: pl.eurobank.osgi.deployment.BundleProviderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=httpService, Satisfied
Service Name: org.osgi.service.http.HttpService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=logReader, Satisfied
Service Name: org.osgi.service.log.LogReaderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Properties=
component.id=1
component.name=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
service.pid=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
2=[pl.eurobank.osgi.struts.internal.TestFilter]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Filter
Properties=
alias=/test2/*
component.id=2
component.name=pl.eurobank.osgi.struts.internal.TestFilter
contextPath=/bar
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.TestFilter
service.ranking=50
3=[pl.eurobank.osgi.struts.internal.IndexServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=/index
component.id=3
component.name=pl.eurobank.osgi.struts.internal.IndexServlet
contextPath=/
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.IndexServlet
4=[pl.eurobank.osgi.struts.internal.StrutsProxyServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=*.ebk
component.id=4
component.name=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
service.pid=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
5=[pl.eurobank.osgi.jsp.internal.JspProxyServlet]
Bundlepl.eurobank.osgi.jsp-bundle (20)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=org.osgi.util.tracker.BundleTrackerCustomizer, java.io.Serializable,
javax.servlet.Servlet, javax.servlet.ServletConfig
Properties=
alias=*.jsp
component.id=5
component.name=pl.eurobank.osgi.jsp.internal.JspProxyServlet
service.pid=pl.eurobank.osgi.jsp.internal.JspProxyServlet
6=[pl.eurobank.multipulpit.system.menu.MenuService]
Bundleeb-multipulpit-system (25)
State=disabled
DefaultState=enabled
Activation=immediate
ServiceType=service
Services=pl.eurobank.multipulpit.system.menu.MenuService
Properties=
component.id=6
component.name=pl.eurobank.multipulpit.system.menu.MenuService
service.pid=pl.eurobank.multipulpit.system.menu.MenuService
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1984) Components starts disabled
[
https://issues.apache.org/jira/browse/FELIX-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artur Opala updated FELIX-1984:
---
Attachment: configuration-status-20100113-1209+0100.zip
Components starts disabled
--
Key: FELIX-1984
URL: https://issues.apache.org/jira/browse/FELIX-1984
Project: Felix
Issue Type: Bug
Components: Declarative Services (SCR)
Affects Versions: scr-1.4.0
Environment: felix-2.0.2
Reporter: Artur Opala
Attachments: configuration-status-20100113-1209+0100.zip
From SCR version 1.2.0 all components starts with state 'disabled', SCR 1.0.8
worked fine. Configuration dump attached as zip file.
{code}
0=[pl.eurobank.osgi.springframework.web.SpringServletContextListener]
Bundlepl.eurobank.osgi.springframework-bundle (11)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.ServletContextListener
Properties=
component.id=0
component.name=pl.eurobank.osgi.springframework.web.SpringServletContextListener
service.pid=pl.eurobank.osgi.springframework.web.SpringServletContextListener
1=[pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator]
Bundlepl.eurobank.osgi.launcher-bundle (18)
State=disabled
DefaultState=enabled
Activation=immediate
Reference=bundleProviderService, Satisfied
Service Name: pl.eurobank.osgi.deployment.BundleProviderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=httpService, Satisfied
Service Name: org.osgi.service.http.HttpService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=logReader, Satisfied
Service Name: org.osgi.service.log.LogReaderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Properties=
component.id=1
component.name=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
service.pid=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
2=[pl.eurobank.osgi.struts.internal.TestFilter]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Filter
Properties=
alias=/test2/*
component.id=2
component.name=pl.eurobank.osgi.struts.internal.TestFilter
contextPath=/bar
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.TestFilter
service.ranking=50
3=[pl.eurobank.osgi.struts.internal.IndexServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=/index
component.id=3
component.name=pl.eurobank.osgi.struts.internal.IndexServlet
contextPath=/
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.IndexServlet
4=[pl.eurobank.osgi.struts.internal.StrutsProxyServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=*.ebk
component.id=4
component.name=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
service.pid=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
5=[pl.eurobank.osgi.jsp.internal.JspProxyServlet]
Bundlepl.eurobank.osgi.jsp-bundle (20)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=org.osgi.util.tracker.BundleTrackerCustomizer, java.io.Serializable,
javax.servlet.Servlet, javax.servlet.ServletConfig
Properties=
alias=*.jsp
component.id=5
component.name=pl.eurobank.osgi.jsp.internal.JspProxyServlet
service.pid=pl.eurobank.osgi.jsp.internal.JspProxyServlet
6=[pl.eurobank.multipulpit.system.menu.MenuService]
Bundleeb-multipulpit-system (25)
State=disabled
DefaultState=enabled
Activation=immediate
ServiceType=service
Services=pl.eurobank.multipulpit.system.menu.MenuService
Properties=
component.id=6
component.name=pl.eurobank.multipulpit.system.menu.MenuService
service.pid=pl.eurobank.multipulpit.system.menu.MenuService
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1984) Components starts disabled
[
https://issues.apache.org/jira/browse/FELIX-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799700#action_12799700
]
Artur Opala commented on FELIX-1984:
Declaration of a selected component
?xml version=1.0 encoding=UTF-8?
components xmlns:scr=http://www.osgi.org/xmlns/scr/v1.0.0;
scr:component enabled=true immediate=true
name=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
implementation
class=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator/
property name=service.pid
value=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator/
reference name=httpService
interface=org.osgi.service.http.HttpService cardinality=0..1
policy=dynamic bind=bindHttpService unbind=unbindHttpService/
reference name=logReader
interface=org.osgi.service.log.LogReaderService cardinality=0..1
policy=dynamic bind=bindLogReader unbind=unbindLogReader/
reference name=bundleProviderService
interface=pl.eurobank.osgi.deployment.BundleProviderService
cardinality=0..1 policy=dynamic bind=bindBundleProviderService
unbind=unbindBundleProviderService/
/scr:component
/components
Components starts disabled
--
Key: FELIX-1984
URL: https://issues.apache.org/jira/browse/FELIX-1984
Project: Felix
Issue Type: Bug
Components: Declarative Services (SCR)
Affects Versions: scr-1.4.0
Environment: felix-2.0.2
Reporter: Artur Opala
Attachments: configuration-status-20100113-1209+0100.zip
From SCR version 1.2.0 all components starts with state 'disabled', SCR 1.0.8
worked fine. Configuration dump attached as zip file.
{code}
0=[pl.eurobank.osgi.springframework.web.SpringServletContextListener]
Bundlepl.eurobank.osgi.springframework-bundle (11)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.ServletContextListener
Properties=
component.id=0
component.name=pl.eurobank.osgi.springframework.web.SpringServletContextListener
service.pid=pl.eurobank.osgi.springframework.web.SpringServletContextListener
1=[pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator]
Bundlepl.eurobank.osgi.launcher-bundle (18)
State=disabled
DefaultState=enabled
Activation=immediate
Reference=bundleProviderService, Satisfied
Service Name: pl.eurobank.osgi.deployment.BundleProviderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=httpService, Satisfied
Service Name: org.osgi.service.http.HttpService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Reference=logReader, Satisfied
Service Name: org.osgi.service.log.LogReaderService
Multiple: single
Optional: optional
Policy: dynamic
No Services bound
Properties=
component.id=1
component.name=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
service.pid=pl.eurobank.osgi.launcher.bundle.internal.LauncherSupportActivator
2=[pl.eurobank.osgi.struts.internal.TestFilter]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Filter
Properties=
alias=/test2/*
component.id=2
component.name=pl.eurobank.osgi.struts.internal.TestFilter
contextPath=/bar
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.TestFilter
service.ranking=50
3=[pl.eurobank.osgi.struts.internal.IndexServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=/index
component.id=3
component.name=pl.eurobank.osgi.struts.internal.IndexServlet
contextPath=/
init.testparam=testvalue
service.pid=pl.eurobank.osgi.struts.internal.IndexServlet
4=[pl.eurobank.osgi.struts.internal.StrutsProxyServlet]
Bundlepl.eurobank.osgi.struts-1-2-bundle (19)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=javax.servlet.Servlet
Properties=
alias=*.ebk
component.id=4
component.name=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
service.pid=pl.eurobank.osgi.struts.internal.StrutsProxyServlet
5=[pl.eurobank.osgi.jsp.internal.JspProxyServlet]
Bundlepl.eurobank.osgi.jsp-bundle (20)
State=disabled
DefaultState=enabled
Activation=delayed
ServiceType=service
Services=org.osgi.util.tracker.BundleTrackerCustomizer, java.io.Serializable,
javax.servlet.Servlet, javax.servlet.ServletConfig
Properties=
alias=*.jsp
component.id=5
component.name=pl.eurobank.osgi.jsp.internal.JspProxyServlet
service.pid=pl.eurobank.osgi.jsp.internal.JspProxyServlet
6=[pl.eurobank.multipulpit.system.menu.MenuService]
Bundleeb-multipulpit-system (25)
State=disabled
DefaultState=enabled
Activation=immediate
[jira] Updated: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE
[ https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated FELIX-1957: - Fix Version/s: (was: webconsole-2.0.6) webconsole-3.0.0 This will probably a major overhaul of the internals of the Web Console an rewrite of some embedded plugins (though the API will remain backwards compatible). Therefore tentatively tagging this issue for a new major release. Make Web Console compatible with OSGi/Minimum-1.0 EE Key: FELIX-1957 URL: https://issues.apache.org/jira/browse/FELIX-1957 Project: Felix Issue Type: New Feature Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Valentin Valchev Assignee: Felix Meschberger Fix For: webconsole-3.0.0 Attachments: mathes-patch.patch Currently the Web Console requires some methods that are JDK 1.4+ specific. In some embedded JVM the methods are not available. However, it's not needed to sync with each embedded JVM but make sure to run at least at OSGi/Minimum-1.0 Execution Environment. The problem methods are: String.matches(pattern); (LicenseServlet BundlesServlet) String.replaceAll(); (ConfigurationRender) String.split();(BundleRepositoryRender) The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the ConfigurationListener. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1958) Branding LF issues
[ https://issues.apache.org/jira/browse/FELIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated FELIX-1958: - Fix Version/s: (was: webconsole-2.0.6) webconsole-3.0.0 This will probably a major overhaul of the internals of the Web Console an rewrite of some embedded plugins (though the API will remain backwards compatible). Therefore tentatively tagging this issue for a new major release Branding LF issues Key: FELIX-1958 URL: https://issues.apache.org/jira/browse/FELIX-1958 Project: Felix Issue Type: Improvement Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Valentin Valchev Assignee: Felix Meschberger Priority: Minor Fix For: webconsole-3.0.0 Attachments: branding-title.png Currently the heading of the Apache Web Console consists of: Left: Admin Title Plugin Title Right: Vendor Logo Unfortunately the Admin Title cannot be changed, unless the bundles are modified. And in case, when we install Karaf with branding support, opening the bundles tab we see the following headings on left: Apache Felix Web Management Console Bundle When opening the Karaf Admin we see: Apache Felix Karaf :: Web Console :: Admin Admin (The attached image shows the visual inconsistency) What about changing the Admin Title to Product Title. So, when the Web Console is installed in a product like Karaf the top-most title will be always consistent and more-over, you will always know that you work with a specific product. In this case the previous examples might look this way: Karaf Web Management Console Bundles Karaf Web Management Console Karaf :: Admin The change can be easily implement by changing the AbstractWebConsolePlugin.startResponse() method by replacing the 'adminTitle' with brandingPlugin.getBrandName() or brandingPlugin.getProductName(). This way we will also eliminate the need of reading the Bundle-Name manifest header for each plug-in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Work started: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE
[ https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on FELIX-1957 started by Felix Meschberger. Make Web Console compatible with OSGi/Minimum-1.0 EE Key: FELIX-1957 URL: https://issues.apache.org/jira/browse/FELIX-1957 Project: Felix Issue Type: New Feature Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Valentin Valchev Assignee: Felix Meschberger Fix For: webconsole-2.0.6 Attachments: mathes-patch.patch Currently the Web Console requires some methods that are JDK 1.4+ specific. In some embedded JVM the methods are not available. However, it's not needed to sync with each embedded JVM but make sure to run at least at OSGi/Minimum-1.0 Execution Environment. The problem methods are: String.matches(pattern); (LicenseServlet BundlesServlet) String.replaceAll(); (ConfigurationRender) String.split();(BundleRepositoryRender) The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the ConfigurationListener. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1957) Make Web Console compatible with OSGi/Minimum-1.0 EE
[ https://issues.apache.org/jira/browse/FELIX-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-1957. -- Resolution: Fixed Applied the patch slightly modified in Rev. 898728: * renamed the method to enableLineWrapping * replace char[] by direct string access * only append blank after ; and , (the brackets and braces were part of the regexp) Make Web Console compatible with OSGi/Minimum-1.0 EE Key: FELIX-1957 URL: https://issues.apache.org/jira/browse/FELIX-1957 Project: Felix Issue Type: New Feature Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Valentin Valchev Assignee: Felix Meschberger Fix For: webconsole-2.0.6 Attachments: mathes-patch.patch Currently the Web Console requires some methods that are JDK 1.4+ specific. In some embedded JVM the methods are not available. However, it's not needed to sync with each embedded JVM but make sure to run at least at OSGi/Minimum-1.0 Execution Environment. The problem methods are: String.matches(pattern); (LicenseServlet BundlesServlet) String.replaceAll(); (ConfigurationRender) String.split();(BundleRepositoryRender) The class LinkedHashMap is missing in OSGi/Minimum-1.0 EE but used in the ConfigurationListener. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1956) Collect duplicate reusable code in WebConsoleUtil
[ https://issues.apache.org/jira/browse/FELIX-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799711#action_12799711 ] Felix Meschberger commented on FELIX-1956: -- This patch cannot be applied because the WebConsoleUtil class is missing. Can you please attach this class to this issue ? Thanks. Collect duplicate reusable code in WebConsoleUtil --- Key: FELIX-1956 URL: https://issues.apache.org/jira/browse/FELIX-1956 Project: Felix Issue Type: Improvement Components: Web Console Affects Versions: webconsole-2.0.4 Reporter: Valentin Valchev Assignee: Felix Meschberger Priority: Trivial Fix For: webconsole-2.0.6 Attachments: eclipse-warnings-duplicate-code.patch I've looked at the Web Console code and found some common methods that are used in the plugins. These methods can be reused by third party plugins and it would be nice, if they are exported as new class WebConsoleUtil. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1792) Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement
[ https://issues.apache.org/jira/browse/FELIX-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799746#action_12799746 ] Richard S. Hall commented on FELIX-1792: I will try to look into it...got caught up in some higher priority issues... Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement -- Key: FELIX-1792 URL: https://issues.apache.org/jira/browse/FELIX-1792 Project: Felix Issue Type: Bug Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.4.2 Environment: n/a Reporter: david small99 Assignee: Richard S. Hall Fix For: bundlerepository-1.6.0 I have one bundle bundle1, which imports a package called com.obr.bundle Bundle1's manifest: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle1 Bundle-Version: 1.0.0 Export-Package: com.obr.bundle1 Import-Package: com.obr.bundle;version=[1.2.0.999,3.2.2.bz] There are two bundles in my repositories, bundler2 and bundle 3. Both of them export package com.obr.bundle. Below are their manifest files. Bundle2 Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle2 Bundle-Version: 1.0.0 Bundle-Vendor: xxx Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.2.2.blah Bundle3: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle3 Bundle-Version: 1.0.0 Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.1 As you can see, both bundle2 and bundle3 meet the requirements of bundle1. I hope the highest package version, which is bundle2, is chosen by felix obr. However, sometimes bundle 3 was chosen instead of bundle2. The behaviour is random. Am I right to say that the Felix obr runtime just picks the first bundle that meets the requirements and then stop searching for any more eligible bundles? Thanks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1980) Gogo TelnetShell cannot be activated
[ https://issues.apache.org/jira/browse/FELIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799747#action_12799747 ] Richard S. Hall commented on FELIX-1980: One approach would be to have a multi-valued property which could be set to any combination, like: felix.shell.access=telnet,console To disable it, have no value. To have one or the other, just put the value you want. Gogo TelnetShell cannot be activated Key: FELIX-1980 URL: https://issues.apache.org/jira/browse/FELIX-1980 Project: Felix Issue Type: Bug Components: Gogo Reporter: Arjun Panday Priority: Minor Attachments: gogo.tgz Gogo's TelnetShell is implemented as an SCR component but no XML is provided to activate it. /Arjun -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-1980) Gogo TelnetShell cannot be activated
[ https://issues.apache.org/jira/browse/FELIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799747#action_12799747 ] Richard S. Hall edited comment on FELIX-1980 at 1/13/10 2:07 PM: - One approach would be to have a multi-valued property which could be set to any combination, like: felix.gogo.access=telnet,console To disable it, have no value. To have one or the other, just put the value you want. was (Author: rickhall): One approach would be to have a multi-valued property which could be set to any combination, like: felix.shell.access=telnet,console To disable it, have no value. To have one or the other, just put the value you want. Gogo TelnetShell cannot be activated Key: FELIX-1980 URL: https://issues.apache.org/jira/browse/FELIX-1980 Project: Felix Issue Type: Bug Components: Gogo Reporter: Arjun Panday Priority: Minor Attachments: gogo.tgz Gogo's TelnetShell is implemented as an SCR component but no XML is provided to activate it. /Arjun -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1980) Gogo TelnetShell cannot be activated
[ https://issues.apache.org/jira/browse/FELIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799761#action_12799761 ] Arjun Panday commented on FELIX-1980: - Sure, but then some additional properties such as port, ip, max connections... are specific to telnet so this approach may end up making things more confusing.. The osgi.shell.* properties seem to be still in use for the old (if i may already call it so) org.apache.felix.shell.remote: http://felix.apache.org/site/apache-felix-remote-shell.html I didn't understand why it was a problem to reuse these. Now actually any property name would suit me as long as it gets the job done :) Gogo TelnetShell cannot be activated Key: FELIX-1980 URL: https://issues.apache.org/jira/browse/FELIX-1980 Project: Felix Issue Type: Bug Components: Gogo Reporter: Arjun Panday Priority: Minor Attachments: gogo.tgz Gogo's TelnetShell is implemented as an SCR component but no XML is provided to activate it. /Arjun -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1980) Gogo TelnetShell cannot be activated
[ https://issues.apache.org/jira/browse/FELIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799766#action_12799766 ] Richard S. Hall commented on FELIX-1980: First, I don't consider the Remote Shell the old one. I was talking about telnetD, which was for Oscar. The property in config.properties for telnet referred to that one. Second, I was not aware that Remote Shell was using properties on the osgi.* namespace, it should probably rename its properties to be in the felix. namespace so people don't get confused and think they are standard properties. Third, I don't really care about the approach for properties too much neither. Just throwing out proposals. I am not convinced having separate properties for port, etc. would be confusing, since they are going to be separate regardless. If you really wanted to go crazy you could make the property follow OSGi standard syntax and do something like: felix.gogo.access=telnet;port:=;maxconnect:=5,console Gogo TelnetShell cannot be activated Key: FELIX-1980 URL: https://issues.apache.org/jira/browse/FELIX-1980 Project: Felix Issue Type: Bug Components: Gogo Reporter: Arjun Panday Priority: Minor Attachments: gogo.tgz Gogo's TelnetShell is implemented as an SCR component but no XML is provided to activate it. /Arjun -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (FELIX-1985) Whitespace sensitivity in the Include-Resource instruction.
Whitespace sensitivity in the Include-Resource instruction.
---
Key: FELIX-1985
URL: https://issues.apache.org/jira/browse/FELIX-1985
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.0.1
Environment: Linux quartz 2.6.31-17-generic #54-Ubuntu SMP Thu Dec 10
17:01:44 UTC 2009 x86_64 GNU/Linux
Reporter: Pierre Bourret
Priority: Minor
With the following maven-bundle-plugin configuration :
plugin
groupIdorg.apache.felix/groupId
artifactIdmaven-bundle-plugin/artifactId
version2.0.1/version
extensionstrue/extensions
configuration
instructions
...
Include-Resource
{maven-resources},
META-INF/LICENSE=LICENSE,
META-INF/NOTICE=NOTICE
/Include-Resource
/instructions
/configuration
/plugin
I get these errors :
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: LICENSE~
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: NOTICE~
[ERROR] Error(s) found in bundle configuration
(Note the trailing '~' at the end of the real file names)
But when I insert whitespaces around the '=' symbol (either before or after
it), it works : neither error nor warning.
Include-Resource
{maven-resources},
META-INF/LICENSE =LICENSE,
META-INF/NOTICE= NOTICE
/Include-Resource
[INFO] BUILD SUCCESSFUL
The first configuration (the one without spaces around '=') works with the
1.4.3 version of the maven-bundle-plugin.
Is this a regression ? Or maybe the syntax of the Include-Resource instruction
has changed since the 1.4.3 version (may it affect other instruction too ?).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1985) Whitespace sensitivity in the Include-Resource instruction.
[
https://issues.apache.org/jira/browse/FELIX-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799788#action_12799788
]
Stuart McCulloch commented on FELIX-1985:
-
The trailing '~' is typically seen with duplicate entries - a recent change in
how the Bnd Tool processes the instructions meant duplicate clauses are tagged
with '~' which then leads to failures finding the named resource because the
original path doesn't have '~'. Note that this is part of the general purpose
Bnd instruction processing that was added to support merging of clauses and
just has an unfortunate side effect when Include-Resource contains duplicate
entries (something that only happens when Include-Resource is generated).
This was fixed for Include-Resource in FELIX-1262 which is in 2.0.1...
http://issues.apache.org/jira/browse/FELIX-1262?focusedCommentId=12730288page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12730288
but perhaps this fix missed a corner case involving {maven-resources} ... if
this expands to also contain entries for META-INF/LICENSE etc. then you would
have duplicate entries and they'd be tagged with '~' (the fix is supposed to
filter out these duplicate entries before they reach the Bnd Tool). Adding
spaces to the clause probably makes them different enough from the generated
entries which explains why you don't see the error.
Whitespace sensitivity in the Include-Resource instruction.
---
Key: FELIX-1985
URL: https://issues.apache.org/jira/browse/FELIX-1985
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.0.1
Environment: Linux quartz 2.6.31-17-generic #54-Ubuntu SMP Thu Dec 10
17:01:44 UTC 2009 x86_64 GNU/Linux
Reporter: Pierre Bourret
Priority: Minor
With the following maven-bundle-plugin configuration :
plugin
groupIdorg.apache.felix/groupId
artifactIdmaven-bundle-plugin/artifactId
version2.0.1/version
extensionstrue/extensions
configuration
instructions
...
Include-Resource
{maven-resources},
META-INF/LICENSE=LICENSE,
META-INF/NOTICE=NOTICE
/Include-Resource
/instructions
/configuration
/plugin
I get these errors :
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: LICENSE~
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: NOTICE~
[ERROR] Error(s) found in bundle configuration
(Note the trailing '~' at the end of the real file names)
But when I insert whitespaces around the '=' symbol (either before or after
it), it works : neither error nor warning.
Include-Resource
{maven-resources},
META-INF/LICENSE =LICENSE,
META-INF/NOTICE= NOTICE
/Include-Resource
[INFO] BUILD SUCCESSFUL
The first configuration (the one without spaces around '=') works with the
1.4.3 version of the maven-bundle-plugin.
Is this a regression ? Or maybe the syntax of the Include-Resource
instruction has changed since the 1.4.3 version (may it affect other
instruction too ?).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1985) Whitespace sensitivity in the Include-Resource instruction.
[
https://issues.apache.org/jira/browse/FELIX-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799789#action_12799789
]
Stuart McCulloch commented on FELIX-1985:
-
If you run with mvn -X you'll get a load of debug (pipe it to a file)
including the exact instructions the bundleplugin passes on to the Bnd Tool
(ie. after processing) which you can check to see if it does contain any
duplicate Include-Resource clauses.
Whitespace sensitivity in the Include-Resource instruction.
---
Key: FELIX-1985
URL: https://issues.apache.org/jira/browse/FELIX-1985
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.0.1
Environment: Linux quartz 2.6.31-17-generic #54-Ubuntu SMP Thu Dec 10
17:01:44 UTC 2009 x86_64 GNU/Linux
Reporter: Pierre Bourret
Priority: Minor
With the following maven-bundle-plugin configuration :
plugin
groupIdorg.apache.felix/groupId
artifactIdmaven-bundle-plugin/artifactId
version2.0.1/version
extensionstrue/extensions
configuration
instructions
...
Include-Resource
{maven-resources},
META-INF/LICENSE=LICENSE,
META-INF/NOTICE=NOTICE
/Include-Resource
/instructions
/configuration
/plugin
I get these errors :
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: LICENSE~
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: NOTICE~
[ERROR] Error(s) found in bundle configuration
(Note the trailing '~' at the end of the real file names)
But when I insert whitespaces around the '=' symbol (either before or after
it), it works : neither error nor warning.
Include-Resource
{maven-resources},
META-INF/LICENSE =LICENSE,
META-INF/NOTICE= NOTICE
/Include-Resource
[INFO] BUILD SUCCESSFUL
The first configuration (the one without spaces around '=') works with the
1.4.3 version of the maven-bundle-plugin.
Is this a regression ? Or maybe the syntax of the Include-Resource
instruction has changed since the 1.4.3 version (may it affect other
instruction too ?).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1982) Documented but uninterpreted felix.cache.* properties
[ https://issues.apache.org/jira/browse/FELIX-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard S. Hall resolved FELIX-1982. Resolution: Fixed Fix Version/s: felix-2.2.0 Assignee: Richard S. Hall I updated the class-level javadoc. If you are satisfied, please close this issue. Documented but uninterpreted felix.cache.* properties - Key: FELIX-1982 URL: https://issues.apache.org/jira/browse/FELIX-1982 Project: Felix Issue Type: Bug Components: Framework Affects Versions: felix-2.0.1 Reporter: Jesse Glick Assignee: Richard S. Hall Priority: Minor Fix For: felix-2.2.0 apache-felix-framework-usage-documentation.html documents that felix.cache.dir and felix.cache.profile are gone and that felix.cache.profiledir has been renamed to the standard org.osgi.framework.storage. The Javadoc in BundleCache.java has however not been updated accordingly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1985) Whitespace sensitivity in the Include-Resource instruction.
[
https://issues.apache.org/jira/browse/FELIX-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799806#action_12799806
]
Pierre Bourret commented on FELIX-1985:
---
First, thanks for reacting so fast !
I have run maven with the -X flag and have noticed that the LICENSE and NOTICE
files are included twice. After checking again the pom hierarchy, I've found
that the parent pom of my project already contains resource instructions to
add LICENSE and NOTICE in the project resources. So the entries in the
bundle-plugin configuration are redundant. You're right !
It was my fault... Sorry to report a non-issue. I'm going to close this
immediately...
Whitespace sensitivity in the Include-Resource instruction.
---
Key: FELIX-1985
URL: https://issues.apache.org/jira/browse/FELIX-1985
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.0.1
Environment: Linux quartz 2.6.31-17-generic #54-Ubuntu SMP Thu Dec 10
17:01:44 UTC 2009 x86_64 GNU/Linux
Reporter: Pierre Bourret
Priority: Minor
With the following maven-bundle-plugin configuration :
plugin
groupIdorg.apache.felix/groupId
artifactIdmaven-bundle-plugin/artifactId
version2.0.1/version
extensionstrue/extensions
configuration
instructions
...
Include-Resource
{maven-resources},
META-INF/LICENSE=LICENSE,
META-INF/NOTICE=NOTICE
/Include-Resource
/instructions
/configuration
/plugin
I get these errors :
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: LICENSE~
[ERROR] Error building bundle
org.ow2.chameleon.handies:org.ow2.chameleon.handies.ipojo-tccl-handler:bundle:0.0.1-SNAPSHOT
: Input file does not exist: NOTICE~
[ERROR] Error(s) found in bundle configuration
(Note the trailing '~' at the end of the real file names)
But when I insert whitespaces around the '=' symbol (either before or after
it), it works : neither error nor warning.
Include-Resource
{maven-resources},
META-INF/LICENSE =LICENSE,
META-INF/NOTICE= NOTICE
/Include-Resource
[INFO] BUILD SUCCESSFUL
The first configuration (the one without spaces around '=') works with the
1.4.3 version of the maven-bundle-plugin.
Is this a regression ? Or maybe the syntax of the Include-Resource
instruction has changed since the 1.4.3 version (may it affect other
instruction too ?).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1982) Documented but uninterpreted felix.cache.* properties
[
https://issues.apache.org/jira/browse/FELIX-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse Glick closed FELIX-1982.
--
Looks better.
BTW there is a broken link in Javadoc; fix:
Index: framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
===
--- framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
(revision 898924)
+++ framework/src/main/java/org/apache/felix/framework/cache/BundleCache.java
(working copy)
@@ -60,7 +60,7 @@
* For specific information on how to configure the Felix framework, refer
* to the Felix framework usage documentation.
* /p
- * @see org.apache.felix.framework.util.BundleArchive
+ * @see org.apache.felix.framework.cache.BundleArchive
**/
public class BundleCache
{
Documented but uninterpreted felix.cache.* properties
-
Key: FELIX-1982
URL: https://issues.apache.org/jira/browse/FELIX-1982
Project: Felix
Issue Type: Bug
Components: Framework
Affects Versions: felix-2.0.1
Reporter: Jesse Glick
Assignee: Richard S. Hall
Priority: Minor
Fix For: felix-2.2.0
apache-felix-framework-usage-documentation.html documents that
felix.cache.dir and felix.cache.profile are gone and that
felix.cache.profiledir has been renamed to the standard
org.osgi.framework.storage. The Javadoc in BundleCache.java has however not
been updated accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1792) Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement
[ https://issues.apache.org/jira/browse/FELIX-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799915#action_12799915 ] Richard S. Hall commented on FELIX-1792: It was not a deadlock, but an infinite loop. In my last patch, I was attempting to remove a Resource from the list of candidates when it failed to resolve, but I should have been removing a Capability. As a result, the list never got smaller, which led to an infinite loop. I fixed it and your example now works for me. I deployed a new snapshot, let me know if you run into any other issues. Thanks. Felix OBR seems to just randomly choose one of the satisifed bundles if more than one bundle meets the requirement -- Key: FELIX-1792 URL: https://issues.apache.org/jira/browse/FELIX-1792 Project: Felix Issue Type: Bug Components: Bundle Repository (OBR) Affects Versions: bundlerepository-1.4.2 Environment: n/a Reporter: david small99 Assignee: Richard S. Hall Fix For: bundlerepository-1.6.0 I have one bundle bundle1, which imports a package called com.obr.bundle Bundle1's manifest: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle1 Bundle-Version: 1.0.0 Export-Package: com.obr.bundle1 Import-Package: com.obr.bundle;version=[1.2.0.999,3.2.2.bz] There are two bundles in my repositories, bundler2 and bundle 3. Both of them export package com.obr.bundle. Below are their manifest files. Bundle2 Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle2 Bundle-Version: 1.0.0 Bundle-Vendor: xxx Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.2.2.blah Bundle3: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Bundle-ManifestVersion: 2 Bundle-Name: Bundle Plug-in Bundle-SymbolicName: com.obr.bundle3 Bundle-Version: 1.0.0 Import-Package: a.b.c Export-Package: com.obr.bundle;version=3.1 As you can see, both bundle2 and bundle3 meet the requirements of bundle1. I hope the highest package version, which is bundle2, is chosen by felix obr. However, sometimes bundle 3 was chosen instead of bundle2. The behaviour is random. Am I right to say that the Felix obr runtime just picks the first bundle that meets the requirements and then stop searching for any more eligible bundles? Thanks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1979) ServletHandlerRequest.getPathInfo() returns undecoded string
[ https://issues.apache.org/jira/browse/FELIX-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800128#action_12800128 ] Sten Roger Sandvik commented on FELIX-1979: --- Yes. That would be another approach. URLDecode approach is atleast server-container neutral (if for some reason some servlet containers do this differently). ServletHandlerRequest.getPathInfo() returns undecoded string Key: FELIX-1979 URL: https://issues.apache.org/jira/browse/FELIX-1979 Project: Felix Issue Type: Bug Components: HTTP Service Affects Versions: http-2.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: http-2.0.6 Attachments: FELIX-1979.patch The Servlet API specifies the HttpServletRequest.getPathInfo() to return a decoded path string. The current implementation just cuts off the servlet context and servlet alias from the request URL (retrieved from HttpServletRequest.getRequestURI()), which is not decoded. Therefore the resulting path info is also not decoded and needs decoding. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
