[VOTE RESULT] Accept Arjun Panday's service Diagnostics service and graphical WebConsole plugin
The vote to accept Arjun Panday's contribution has passed with the following votes: * +1 from Arjun Panday (non-binding), Carsten Ziegeler, Stuart McCulloch, Richard S. Hall, Pierre De Rop, Felix Meschberger, Karl Pauls, and Marcel Offermanns I'll start to work on the next steps for IP clearance. Thanks Carsten -- Carsten Ziegeler cziege...@apache.org
[jira] [Assigned] (FELIX-1828) Mistake in code of the class UpdateCommand
[ https://issues.apache.org/jira/browse/FELIX-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Offermans reassigned FELIX-1828: --- Assignee: Marcel Offermans Mistake in code of the class UpdateCommand -- Key: FELIX-1828 URL: https://issues.apache.org/jira/browse/FELIX-1828 Project: Felix Issue Type: Bug Components: Deployment Admin Reporter: Pavel Kodl Assignee: Marcel Offermans Priority: Critical On row 70 should be : Bundle bundle = targetPackage.getBundle(bundleInfo.getSymbolicName()); instead of: Bundle bundle = source.getBundle(bundleInfo.getSymbolicName()); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-1828) Mistake in code of the class UpdateCommand
[ https://issues.apache.org/jira/browse/FELIX-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Offermans resolved FELIX-1828. - Resolution: Fixed Mistake in code of the class UpdateCommand -- Key: FELIX-1828 URL: https://issues.apache.org/jira/browse/FELIX-1828 Project: Felix Issue Type: Bug Components: Deployment Admin Reporter: Pavel Kodl Assignee: Marcel Offermans Priority: Critical On row 70 should be : Bundle bundle = targetPackage.getBundle(bundleInfo.getSymbolicName()); instead of: Bundle bundle = source.getBundle(bundleInfo.getSymbolicName()); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-1829) Method AbstractDeploymentPackage.getBundle(...) throws NullPointerException
[
https://issues.apache.org/jira/browse/FELIX-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Offermans reassigned FELIX-1829:
---
Assignee: Marcel Offermans
Method AbstractDeploymentPackage.getBundle(...) throws NullPointerException
---
Key: FELIX-1829
URL: https://issues.apache.org/jira/browse/FELIX-1829
Project: Felix
Issue Type: Bug
Components: Deployment Admin
Reporter: Pavel Kodl
Assignee: Marcel Offermans
Priority: Critical
Because in this method on row 115 is:
if (bundles[i].getSymbolicName().equals(symbolicName)) {
but should be something like:
String sn = bundles[i].getSymbolicName();
if (sn != null sn.equals(symbolicName)) {
It happends by installing a deployment package, stack trace is:
java.lang.NullPointerException
at
org.apache.felix.deploymentadmin.AbstractDeploymentPackage.getBundle(AbstractDeploymentPackage.java:115)
at
org.apache.felix.deploymentadmin.spi.UpdateCommand.execute(UpdateCommand.java:70)
at
org.apache.felix.deploymentadmin.spi.DeploymentSessionImpl.call(DeploymentSessionImpl.java:74)
at
org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:215)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-1831) Reinstalling of deployment package fails
[
https://issues.apache.org/jira/browse/FELIX-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117301#comment-13117301
]
Marcel Offermans commented on FELIX-1831:
-
So far I have not succeeded in reproducing this one. With re-installing, do you
mean installing the exact same deployment package twice?
Reinstalling of deployment package fails
Key: FELIX-1831
URL: https://issues.apache.org/jira/browse/FELIX-1831
Project: Felix
Issue Type: Bug
Components: Deployment Admin
Environment: Windows Vista x64, Apache Felix
Reporter: Pavel Kodl
Priority: Critical
In DeploymentAdminImpl class should be from line 240 something like this:
} else {
// causes unlock deployment package manifest file
m_packages.remove(source.getName());
System.gc(); // have to be here
File targetPackage = m_context.getDataFile(PACKAGE_DIR +
File.separator + source.getName());
targetPackage.mkdirs();
ExplodingOutputtingInputStream.replace(targetPackage,
tempPackage);
}
instead of:
} else {
File targetPackage = m_context.getDataFile(PACKAGE_DIR +
File.separator + source.getName());
targetPackage.mkdirs();
ExplodingOutputtingInputStream.replace(targetPackage,
tempPackage);
}
without this correction it throws:
org.osgi.service.deploymentadmin.DeploymentException: Could not create
installed deployment package from disk
at
org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:252)
at
org.apache.felix.webconsole.internal.deppack.DepPackServlet.doPost(DepPackServlet.java:94)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:296)
at
org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:92)
at
org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:78)
at
org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:42)
at
org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:49)
at
org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:33)
at
org.apache.felix.http.base.internal.dispatch.FilterPipeline.dispatch(FilterPipeline.java:48)
at
org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:39)
at
org.apache.felix.http.base.internal.DispatcherServlet.service(DispatcherServlet.java:55)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:390)
at
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:536)
at
org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:930)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:747)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:405)
at
org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
at
org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
Caused by: java.io.FileNotFoundException:
.\felix-cache\bundle23\data\packages\test4\index.txt
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.init(FileInputStream.java:106)
at java.io.FileReader.init(FileReader.java:55)
at
org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.readIndex(ExplodingOutputtingInputStream.java:212)
at
org.apache.felix.deploymentadmin.FileDeploymentPackage.init(FileDeploymentPackage.java:52)
at
org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:247)
... 26 more
--
This message is automatically generated by JIRA.
If you think it was sent
[jira] [Resolved] (FELIX-3072) Bad manifest content on Import-package part
[ https://issues.apache.org/jira/browse/FELIX-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Offermans resolved FELIX-3072. - Resolution: Not A Problem See comment. Bad manifest content on Import-package part --- Key: FELIX-3072 URL: https://issues.apache.org/jira/browse/FELIX-3072 Project: Felix Issue Type: Bug Components: Deployment Admin Affects Versions: deploymentadmin-0.9.0 Environment: linux (archlinux Reporter: Thierry D. Priority: Minor Labels: build The Import-Package parameter of the bundle's manifest file should not contain org.osgi.service.deploymentadmin packages classes because it embeds these classes. this bug generates ClassNotFound exception when you use the webconsole bundle felix plugin. original parameter value : Import-Package: org.apache.felix.dm;version=[3.0,4),org.osgi.framework;version=[1.5,2),org.osgi.service.deploymentadmin;version=1.1,2),org.osgi.service.deploymentadmin.spi;version=[1.0,2),org.osgi.service.event;version=[1.2,2),org.osgi.service.log;version=1.3,2),org.osgi.service.packageadmin;version=[1.2,2) suggested parameter value (fix ?): Import-Package: org.apache.felix.dm;version=[3.0,4),org.osgi.framework;version=[1.5,2),org.osgi.service.event;version=[1.2,2), org.osgi.service.log;version=[1.3,2),org.osgi.service.packageadmin;version=[1.2,2) unfortunatelly I am not able to provide a fix because I dont know how the osgi bunble maven plugin work exactly. I hope this will help you regards -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-3139) Implement uninstall() for deployment admin.
Implement uninstall() for deployment admin. --- Key: FELIX-3139 URL: https://issues.apache.org/jira/browse/FELIX-3139 Project: Felix Issue Type: Improvement Components: Deployment Admin Reporter: Marcel Offermans Currently, uninstall() is not implemented, even though it's part of the API. The root cause of that is historical, as DA was originally developed for Apache ACE and ACE never uninstalls deployment packages (but instead installs an empty update if you remove all artifacts from a deployment package). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-3139) Implement uninstall() for deployment admin.
[ https://issues.apache.org/jira/browse/FELIX-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Offermans reassigned FELIX-3139: --- Assignee: Marcel Offermans Implement uninstall() for deployment admin. --- Key: FELIX-3139 URL: https://issues.apache.org/jira/browse/FELIX-3139 Project: Felix Issue Type: Improvement Components: Deployment Admin Reporter: Marcel Offermans Assignee: Marcel Offermans Currently, uninstall() is not implemented, even though it's part of the API. The root cause of that is historical, as DA was originally developed for Apache ACE and ACE never uninstalls deployment packages (but instead installs an empty update if you remove all artifacts from a deployment package). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3084) Submission of source code for review of software grant for lightweight HTTP service implementation.
[ https://issues.apache.org/jira/browse/FELIX-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117626#comment-13117626 ] Richard S. Hall commented on FELIX-3084: I think we are ready now. I've created the IP clearance form, so once it propagates to the public web site, then I will announce it to the incubator and then we just have to wait a few days and we are good to go. Submission of source code for review of software grant for lightweight HTTP service implementation. --- Key: FELIX-3084 URL: https://issues.apache.org/jira/browse/FELIX-3084 Project: Felix Issue Type: Task Components: HTTP Service Reporter: Ken Gilmer Labels: software Attachments: GRANT.pdf, org.apache.felix.http.lightweight-src.tar.gz This issue is created as part of the process outlined in the Contributing Source Code Felix page as suggested by Richard Hall in issue FELIX-538[1]. The source code attached[6] to this issue is an implementation of the OSGi HTTP Service specification version 1.2. The code is based on Richard's original server which is also referenced in FELIX-538, and the remaining code was developed by me, with the exception of a few classes which were adapted from existing Felix sources[2]. Design constraints for this project were backwards compatibility, simplicity, and size. The code base consists of 23 Java files in 3 packages. The source is divided into osgi, server, and servlet packages according to the primary purpose of the class, and interfaces are utilized to keep the three domains fairly isolated[3]. The minimal compiled jar which does not include the servlet API or OSGi API currently is 41Kb, and the dependency-free jar with all necessary APIs is 125Kb. An Ant script is provided that will build the jars and a CI server is also available for binary builds[4] and javadocs[5]. In terms of features the server doesn't offer: -HTTPS -Authentication -Cookie support -Session support In addition several aspects of the Servlet implementation have not been tested including: -Multipart POST -DELETE -PUT -Non-default character encodings And as of the submission several Servlet API methods are unimplemented in (all unimplemented methods throw org.apache.felix.http.lightweight.servlet.UnimplementedAPIException): -HttpServletRequest(Impl) -HttpServletResponse(Impl) However the core functionality has been implemented and tested and the Felix Web Admin application can be hosted with this HTTP Service implementation. I plan in continuing to use the service in personal and professional projects and would be happy to continue to add unimplemented features and maintain the code base as a Felix committer. Thanks! Ken Gilmer 1: https://issues.apache.org/jira/browse/FELIX-538 2: /plain-http-service/src/main/java/org/apache/felix/http/lightweight/osgi/DefaultContextImpl.java, /plain-http-service/src/main/java/org/apache/felix/http/lightweight/osgi/Logger.java 3: /plain-http-service/src/main/java/org/apache/felix/http/lightweight/osgi/ServiceRegistrationHandler.java, /plain-http-service/src/main/java/org/apache/felix/http/lightweight/osgi/ServiceRegistrationResolver.java 4: https://leafcutter.ci.cloudbees.com/job/lightweight%20http%20service/ 5: https://leafcutter.ci.cloudbees.com/job/lightweight%20http%20service/javadoc/ 6: MD5SUM 47580996a8c364890518222494d4d26b org.apache.felix.http.lightweight-src.tar.gz -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
