[jira] [Resolved] (FELIX-2719) Add name space support to the meta type implementation
[ https://issues.apache.org/jira/browse/FELIX-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-2719. -- Resolution: Fixed Fix Version/s: metatype-1.0.6 I think this can be regarded as resolved... Add name space support to the meta type implementation -- Key: FELIX-2719 URL: https://issues.apache.org/jira/browse/FELIX-2719 Project: Felix Issue Type: New Feature Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Marcel Offermans Assignee: Marcel Offermans Fix For: metatype-1.0.6 The current reader / parser does not support name spaces. Add support for it, plus a unit test to validate the behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-2867) getIcon() in LocalizedObjectClassDefinition keyset iteration incorrect
[ https://issues.apache.org/jira/browse/FELIX-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-2867. -- Resolution: Fixed Fix Version/s: metatype-1.0.6 Assignee: Felix Meschberger Thanks for reporting the bug. I have fixed this in Rev. 1187680 getIcon() in LocalizedObjectClassDefinition keyset iteration incorrect -- Key: FELIX-2867 URL: https://issues.apache.org/jira/browse/FELIX-2867 Project: Felix Issue Type: Bug Components: Metatype Service Affects Versions: metatype-1.0.4 Environment: ubuntu 10.04 Reporter: jamie campbell Assignee: Felix Meschberger Fix For: metatype-1.0.6 LocalizedObjectClassDefinition:137 attempts to get next iteration element typecast to Map.Entry , which gets a class cast exception most likely because the keys are of type Integer. The map is keys = integers , values = strings (see OCD.java two levels up). The code appears to believe that, instead, it's a map of maps.. or something. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-2868) Icon only works if absolute path specified, but specification allows for relative urls
[ https://issues.apache.org/jira/browse/FELIX-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned FELIX-2868: Assignee: Felix Meschberger Icon only works if absolute path specified, but specification allows for relative urls -- Key: FELIX-2868 URL: https://issues.apache.org/jira/browse/FELIX-2868 Project: Felix Issue Type: Bug Components: Metatype Service Affects Versions: metatype-1.0.4 Environment: ubuntu 10.04 Reporter: jamie campbell Assignee: Felix Meschberger Priority: Minor the icon's resource attribute only resolves to an icon if the absolute url path is specified, but the specification says The base URL is assumed to be the XML file with the definition. I.e. if the XML is a resource in the JAR file, then this URL can reference another resource in that JAR file using a relative URL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-3182) Update to use parent POM 2.1
Update to use parent POM 2.1 Key: FELIX-3182 URL: https://issues.apache.org/jira/browse/FELIX-3182 Project: Felix Issue Type: Task Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 Make use of the 2.1 parent POM to leverage new plugins and remote resources for the legal files -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3182) Update to use parent POM 2.1
[ https://issues.apache.org/jira/browse/FELIX-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-3182. -- Resolution: Fixed Done in Rev. 1187702: Use parent POM 2.1 - remove old legal files in root folder - create replacements (based on old files) in src/main/appended-resources - use bundle plugin referred to by parent POM - depend on official R4 OSGi libraries Update to use parent POM 2.1 Key: FELIX-3182 URL: https://issues.apache.org/jira/browse/FELIX-3182 Project: Felix Issue Type: Task Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 Make use of the 2.1 parent POM to leverage new plugins and remote resources for the legal files -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-2868) Icon only works if absolute path specified, but specification allows for relative urls
[ https://issues.apache.org/jira/browse/FELIX-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-2868. -- Resolution: Fixed Fix Version/s: metatype-1.0.6 Fixed in Rev. 1187688. Now the icon path is converted into an URL using the metatype descriptor file referring to it as the base URL (as implied by the spec) Icon only works if absolute path specified, but specification allows for relative urls -- Key: FELIX-2868 URL: https://issues.apache.org/jira/browse/FELIX-2868 Project: Felix Issue Type: Bug Components: Metatype Service Affects Versions: metatype-1.0.4 Environment: ubuntu 10.04 Reporter: jamie campbell Assignee: Felix Meschberger Priority: Minor Fix For: metatype-1.0.6 the icon's resource attribute only resolves to an icon if the absolute url path is specified, but the specification says The base URL is assumed to be the XML file with the definition. I.e. if the XML is a resource in the JAR file, then this URL can reference another resource in that JAR file using a relative URL. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-3183) Attribute requirement is not validated
Attribute requirement is not validated -- Key: FELIX-3183 URL: https://issues.apache.org/jira/browse/FELIX-3183 Project: Felix Issue Type: Bug Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 The AD.validate method validates a false positive for a missing value even if a value would be required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3183) Attribute requirement is not validated
[ https://issues.apache.org/jira/browse/FELIX-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-3183. -- Resolution: Fixed Fixed in Rev. 1187704 Attribute requirement is not validated -- Key: FELIX-3183 URL: https://issues.apache.org/jira/browse/FELIX-3183 Project: Felix Issue Type: Bug Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 The AD.validate method validates a false positive for a missing value even if a value would be required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2096) Check MetaTypeProvider.getObjectClassDefinition(String, String) specification compliance
[ https://issues.apache.org/jira/browse/FELIX-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133399#comment-13133399 ] Felix Meschberger commented on FELIX-2096: -- As of Rev. 1187706 the getObjectClassDefinition throws an IllegalArgumentException if either id is empty or null or no localized ObjectClassDefinition for the ID can be found. Null is never returned. Check MetaTypeProvider.getObjectClassDefinition(String, String) specification compliance Key: FELIX-2096 URL: https://issues.apache.org/jira/browse/FELIX-2096 Project: Felix Issue Type: Task Components: Metatype Service, Specification compliance Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger I have been running the Apache Felix Metatype Service implementation through the OSGi CT and found an issue with the MetaTypeProvider.getObjectClassDefinition(String id, String locale) method as used in the testMetaTypeProvider test. The method is defined in Section 105.13.4.2 in the R4.2 Compendium specification to: * either return an ObjectClassDefinition for the requested id and locale * or throw an IllegalArgumentException if either id or the locale is invalid THe CT test calls the getObjectClassDefinition three times: (1) getObjectClassDefinition(, du); Expects null, but the id here is definitely invalid (empty string) and not defined, thus an exception might be more appropriate Our implementation returns null (which is presumably wrong) but passes the test (2) getObjectClassDefinition(com.acme.23456789, abc); Expects an exception due to the locale abc not provided as a file Our implementation returns null because the id com.acme.23456789 is not declared Here an exception is probably really expected because the id is not declared. It may be expected due to the missing locale. (3) getObjectClassDefinition(com.acme.foo, du) This test should pass as expected A question regarding invalidity is in place: * What does invalid mean for the id ? Empty string ? Undefined/Undeclared ObjectClassDefinition ? * What does invalid mean for the locale ? This is tricky, since locales form an implicit inheritance hierarchy and even though translations for an exact locale may not be provided, such translations may be provided by the parent. And the default definitions should probably be the root of this tree. E.g. given the locale is de_CH and translations exist for de, it is IMHO expected to get a translation for de instead of de_CH. NB: Returning null as our implementation does is probably definitely wrong according to the spec, since null is not defined to be a valid result. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-2096) Check MetaTypeProvider.getObjectClassDefinition(String, String) specification compliance
[ https://issues.apache.org/jira/browse/FELIX-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-2096. -- Resolution: Fixed Fix Version/s: metatype-1.0.6 I think throwing if an ObjectClassDefinition cannot be returned is ok. So I resolve this issue Check MetaTypeProvider.getObjectClassDefinition(String, String) specification compliance Key: FELIX-2096 URL: https://issues.apache.org/jira/browse/FELIX-2096 Project: Felix Issue Type: Task Components: Metatype Service, Specification compliance Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 I have been running the Apache Felix Metatype Service implementation through the OSGi CT and found an issue with the MetaTypeProvider.getObjectClassDefinition(String id, String locale) method as used in the testMetaTypeProvider test. The method is defined in Section 105.13.4.2 in the R4.2 Compendium specification to: * either return an ObjectClassDefinition for the requested id and locale * or throw an IllegalArgumentException if either id or the locale is invalid THe CT test calls the getObjectClassDefinition three times: (1) getObjectClassDefinition(, du); Expects null, but the id here is definitely invalid (empty string) and not defined, thus an exception might be more appropriate Our implementation returns null (which is presumably wrong) but passes the test (2) getObjectClassDefinition(com.acme.23456789, abc); Expects an exception due to the locale abc not provided as a file Our implementation returns null because the id com.acme.23456789 is not declared Here an exception is probably really expected because the id is not declared. It may be expected due to the missing locale. (3) getObjectClassDefinition(com.acme.foo, du) This test should pass as expected A question regarding invalidity is in place: * What does invalid mean for the id ? Empty string ? Undefined/Undeclared ObjectClassDefinition ? * What does invalid mean for the locale ? This is tricky, since locales form an implicit inheritance hierarchy and even though translations for an exact locale may not be provided, such translations may be provided by the parent. And the default definitions should probably be the root of this tree. E.g. given the locale is de_CH and translations exist for de, it is IMHO expected to get a translation for de instead of de_CH. NB: Returning null as our implementation does is probably definitely wrong according to the spec, since null is not defined to be a valid result. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-2880) The Webconsole does not handle VectorPrimitiveWrapper
[ https://issues.apache.org/jira/browse/FELIX-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated FELIX-2880: - Component/s: (was: Metatype Service) Web Console I assume this is a web console issue ... The Webconsole does not handle VectorPrimitiveWrapper --- Key: FELIX-2880 URL: https://issues.apache.org/jira/browse/FELIX-2880 Project: Felix Issue Type: Bug Components: Web Console Reporter: Peter Kriens An AD like: AD name='Ints' id='ints' cardinality='-2147483648' required='true' type='Integer'/ Should be edited as a list and returned as a VectorInteger. However, this shows as a single integer in the webconsole, not a list editor. I guess it gets confused with primiitves? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2880) The Webconsole does not handle VectorPrimitiveWrapper
[ https://issues.apache.org/jira/browse/FELIX-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133403#comment-13133403 ] Felix Meschberger commented on FELIX-2880: -- Still strange, I cannot reproduce this issue. I have added your sample AD to an existing metatype.xml and get the editor incl. the +/- as expected. I am using Web Console 3.1.6. The Webconsole does not handle VectorPrimitiveWrapper --- Key: FELIX-2880 URL: https://issues.apache.org/jira/browse/FELIX-2880 Project: Felix Issue Type: Bug Components: Web Console Reporter: Peter Kriens An AD like: AD name='Ints' id='ints' cardinality='-2147483648' required='true' type='Integer'/ Should be edited as a list and returned as a VectorInteger. However, this shows as a single integer in the webconsole, not a list editor. I guess it gets confused with primiitves? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-3184) Add support for metatype extension by MetatypeProvider services
Add support for metatype extension by MetatypeProvider services --- Key: FELIX-3184 URL: https://issues.apache.org/jira/browse/FELIX-3184 Project: Felix Issue Type: Task Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 Metatype service 1.2 (as defined in the Residential 4.3 final draft) supports dynamic addition of MetatypeInformation by MetatypeProvider services. We should add support for such services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3182) Update to use parent POM 2.1
[ https://issues.apache.org/jira/browse/FELIX-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133413#comment-13133413 ] David Jencks commented on FELIX-3182: - I'm worried by the removal of all LICENSE and NOTICE files from the metatype root. Expected scm checkout points and the buildable source archives that are the official voted-on apache artifacts need to have LICENSE and NOTICE files at their root correct for their contents. Since metatype is released by itself I think it's an expected scm checkout and needs these. They don't need to reference kxml since there is no kxml source in the metatype scm, but they do need to be present. The appended-resources and m-r-r-p are good for constructing the (different) legal files that are needed in binary artifacts. Update to use parent POM 2.1 Key: FELIX-3182 URL: https://issues.apache.org/jira/browse/FELIX-3182 Project: Felix Issue Type: Task Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 Make use of the 2.1 parent POM to leverage new plugins and remote resources for the legal files -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3182) Update to use parent POM 2.1
[ https://issues.apache.org/jira/browse/FELIX-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133441#comment-13133441 ] Felix Meschberger commented on FELIX-3182: -- Nothing to worry about. This setup is quite custom in Java-based project. As long as the required files exist in the final build - source and binary. If you build with the apache-release profile,which is the case for a release build, the source distro is created with the correct files. Update to use parent POM 2.1 Key: FELIX-3182 URL: https://issues.apache.org/jira/browse/FELIX-3182 Project: Felix Issue Type: Task Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: metatype-1.0.6 Make use of the 2.1 parent POM to leverage new plugins and remote resources for the legal files -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (FELIX-2719) Add name space support to the meta type implementation
[ https://issues.apache.org/jira/browse/FELIX-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reopened FELIX-2719: -- Assignee: Felix Meschberger (was: Marcel Offermans) The REPORT_NAMESPACE_ATTRIBUTES feature is not supported and causes parsing to break. Also the tests do not actually involve namespace aware parsing because they do no set the feature. Add name space support to the meta type implementation -- Key: FELIX-2719 URL: https://issues.apache.org/jira/browse/FELIX-2719 Project: Felix Issue Type: New Feature Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Marcel Offermans Assignee: Felix Meschberger Fix For: metatype-1.0.6 The current reader / parser does not support name spaces. Add support for it, plus a unit test to validate the behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-2719) Add name space support to the meta type implementation
[ https://issues.apache.org/jira/browse/FELIX-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved FELIX-2719. -- Resolution: Fixed Fixed the support in Rev. 1187808 : - allow for 1.0.0, 1.1.0, and new 1.2.0 namespaces - throw if unsupported namespace is encountered - don't further process namespace Not sure, on the other hand, whether we should not just ignore Metadata elements with an unknown namespace Lets just throw for now ... Add name space support to the meta type implementation -- Key: FELIX-2719 URL: https://issues.apache.org/jira/browse/FELIX-2719 Project: Felix Issue Type: New Feature Components: Metatype Service Affects Versions: metatype-1.0.4 Reporter: Marcel Offermans Assignee: Felix Meschberger Fix For: metatype-1.0.6 The current reader / parser does not support name spaces. Add support for it, plus a unit test to validate the behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
