[jira] [Resolved] (FELIX-4011) [DS] code refactoring/simplification
[ https://issues.apache.org/jira/browse/FELIX-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks resolved FELIX-4011. - Resolution: Fixed Fixed in revs 1463767-1463771, 1463820, 1465203, and 1467353 > [DS] code refactoring/simplification > > > Key: FELIX-4011 > URL: https://issues.apache.org/jira/browse/FELIX-4011 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-1.8.0 >Reporter: David Jencks >Assignee: David Jencks > Fix For: scr-1.8.0 > > > I think we can simplify the code a bit by e.g. having only one map of > component instances to stuff related to the component and keeping the edge > infos and component instance in the component context impl. I found some > bugs too... ReadOnlyDictionary copying a non-hashtable didn't work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4020) [DS] A reference being unregistered between checking for references available and actual binding may get bound anyway
[ https://issues.apache.org/jira/browse/FELIX-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks resolved FELIX-4020. - Resolution: Fixed Fixed in revs 1470393-1470397 > [DS] A reference being unregistered between checking for references available > and actual binding may get bound anyway > - > > Key: FELIX-4020 > URL: https://issues.apache.org/jira/browse/FELIX-4020 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-1.8.0 >Reporter: David Jencks >Assignee: David Jencks > Fix For: scr-1.8.0 > > > I think the order of events is: > t1: collect dependencies to make sure component can be activated > t2. unregister required service in a single static reference > t1. create object binding the removed service object. > I don't know if this happens with other reference cardinalities/policies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4001) SCR should depend on released version of animal-sniffer-annotations
[ https://issues.apache.org/jira/browse/FELIX-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks resolved FELIX-4001. - Resolution: Fixed Fix Version/s: scr-1.8.0 Assignee: David Jencks I ran into the same problem and fixed this in rev 1465203 before I saw your issue or patch. > SCR should depend on released version of animal-sniffer-annotations > --- > > Key: FELIX-4001 > URL: https://issues.apache.org/jira/browse/FELIX-4001 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-1.8.0 >Reporter: Robert Munteanu >Assignee: David Jencks >Priority: Minor > Fix For: scr-1.8.0 > > Attachments: FELIX-4001-1.patch > > > There's no reason to depen on 1.10-SNAPSHOT when 1.9 works just fine and is > available outside of the Apache snapshot repo. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4031) [DS] Respond better to InterruptedException
[ https://issues.apache.org/jira/browse/FELIX-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks resolved FELIX-4031. - Resolution: Fixed Fixed in rev 1471172 > [DS] Respond better to InterruptedException > --- > > Key: FELIX-4031 > URL: https://issues.apache.org/jira/browse/FELIX-4031 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-1.8.0, scr ds annotations 1.2.2 >Reporter: David Jencks >Assignee: David Jencks > Fix For: scr-1.8.0 > > > Most of the locks in ds have a timeout. After reading about interruption and > thinking I think that the proper response to an InterruptedException is to > keep waiting for the timeout to expire, but give up if interrupted a second > time. The interruption is supposed to be a hint to not continue forever, but > the timeout is already doing that for us. > We could track the time when we start the lock and only wait until the > original timeout would have expired, but I think this would slow down normal > operations too much for very minimal gain. > In any case we should reset the interrupted flag. (already done in rev > 1470394) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-4022) [DS] Deleting a configuration is supposed to deactivate the component unconditionally
[ https://issues.apache.org/jira/browse/FELIX-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650513#comment-13650513 ] David Jencks commented on FELIX-4022: - Discussion in an osgi bug indicates our behavior is probably correct and the spec misleading, incomplete, or wrong. > [DS] Deleting a configuration is supposed to deactivate the component > unconditionally > - > > Key: FELIX-4022 > URL: https://issues.apache.org/jira/browse/FELIX-4022 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) >Affects Versions: scr-1.8.0 >Reporter: David Jencks >Assignee: David Jencks > Fix For: scr-1.8.0 > > > Spec 112.7.1 says if a configuration is deleted the component it configures > must be deactivated (and presumably attempt reactivation if it's still > satisfied). Doesn't make sense to me, but there it is. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-4054) Use current factory version to generate instance name if required
[ https://issues.apache.org/jira/browse/FELIX-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650173#comment-13650173 ] Pierre Bourret commented on FELIX-4054: --- Fix confirmed (trunk r1479678) : Got 2 factories with the same name "BarImpl" and 2 different versions : null (no version set) and "2.0.0" First instance created with "null" factory is named : "BarImpl-0" First instance created with "2.0.0" factory is named "BarImpl-0-2.0.0" (No instance name is provided for these 2 creations, to force name generation) Before the fix, the second instance creation failed because of a generated name conflict (both were "BarImpl-0") > Use current factory version to generate instance name if required > - > > Key: FELIX-4054 > URL: https://issues.apache.org/jira/browse/FELIX-4054 > Project: Felix > Issue Type: Bug > Components: iPOJO >Affects Versions: ipojo-runtime-1.8.6 >Reporter: Clement Escoffier >Assignee: Clement Escoffier > Fix For: ipojo-runtime-1.10 > > > When two factories of different versions are installed, the unique name > generation should use the factory version if a conflict is detected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3339) Consolidate Thread Dump Support
[
https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated FELIX-3339:
--
Attachment: FELIX-3339_threaddump-smarter-jdk_version-comparison.patch
Please find the attached latest patch which implements a asmarter
{{java.specification.version}} comparison limiting the checks to jdk 1.6 and 1.5
> Consolidate Thread Dump Support
> ---
>
> Key: FELIX-3339
> URL: https://issues.apache.org/jira/browse/FELIX-3339
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-3.1.8
>Reporter: Felix Meschberger
> Attachments: FELIX-3339_initial-proto.patch,
> FELIX-3339_threaddump-include-jdk18.patch,
> FELIX-3339_threaddump-smarter-jdk_version-comparison.patch
>
>
> The Felix Web Console currently has an embedded plugin only using traditional
> Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs.
> These two should be consolidated and extended such that:
> * Separate bundle (not embedded in the Web Console Bundle)
> * one single plugin in Apache Felix
> * Uses Java 6 JMX API if available
> * Falls back to Java 5 JMX API if not Java 6
> * Falls back to regular Java API as a last step
> * Provide Gogo Shell Commands
> The advantage of using Java 6 API is to be able to inject lock information in
> the thread dumps to be able to followup on deadlock and similar situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[
https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650127#comment-13650127
]
Simone Tripodi commented on FELIX-3339:
---
looks like {{java.lang .Package#isCompatibleWith(String)}} refers to
{{@version}} javadoc tag, it cannot be used for that purpose - guess that we
have to fallback to {{java.specification.version}} System Property comparison,
maybe a smarter comparison that understand if JDK version >= 1.6 then use Java6
APIs...
> Consolidate Thread Dump Support
> ---
>
> Key: FELIX-3339
> URL: https://issues.apache.org/jira/browse/FELIX-3339
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-3.1.8
>Reporter: Felix Meschberger
> Attachments: FELIX-3339_initial-proto.patch,
> FELIX-3339_threaddump-include-jdk18.patch
>
>
> The Felix Web Console currently has an embedded plugin only using traditional
> Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs.
> These two should be consolidated and extended such that:
> * Separate bundle (not embedded in the Web Console Bundle)
> * one single plugin in Apache Felix
> * Uses Java 6 JMX API if available
> * Falls back to Java 5 JMX API if not Java 6
> * Falls back to regular Java API as a last step
> * Provide Gogo Shell Commands
> The advantage of using Java 6 API is to be able to inject lock information in
> the thread dumps to be able to followup on deadlock and similar situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4054) Use current factory version to generate instance name if required
[ https://issues.apache.org/jira/browse/FELIX-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clement Escoffier resolved FELIX-4054. -- Resolution: Fixed Fixed in trunk > Use current factory version to generate instance name if required > - > > Key: FELIX-4054 > URL: https://issues.apache.org/jira/browse/FELIX-4054 > Project: Felix > Issue Type: Bug > Components: iPOJO >Affects Versions: ipojo-runtime-1.8.6 >Reporter: Clement Escoffier >Assignee: Clement Escoffier > Fix For: ipojo-runtime-1.10 > > > When two factories of different versions are installed, the unique name > generation should use the factory version if a conflict is detected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-4054) Use current factory version to generate instance name if required
Clement Escoffier created FELIX-4054: Summary: Use current factory version to generate instance name if required Key: FELIX-4054 URL: https://issues.apache.org/jira/browse/FELIX-4054 Project: Felix Issue Type: Bug Components: iPOJO Affects Versions: ipojo-runtime-1.8.6 Reporter: Clement Escoffier Assignee: Clement Escoffier Fix For: ipojo-runtime-1.10 When two factories of different versions are installed, the unique name generation should use the factory version if a conflict is detected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4048) @Requires handler does not fail when no specification can be found
[ https://issues.apache.org/jira/browse/FELIX-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clement Escoffier resolved FELIX-4048. -- Resolution: Fixed Fix Version/s: ipojo-runtime-1.10 Assignee: Clement Escoffier Fixed in trunk > @Requires handler does not fail when no specification can be found > -- > > Key: FELIX-4048 > URL: https://issues.apache.org/jira/browse/FELIX-4048 > Project: Felix > Issue Type: Bug > Components: iPOJO >Reporter: Guillaume Sauthier >Assignee: Clement Escoffier > Fix For: ipojo-runtime-1.10 > > > The requires handler is designed to track services using their service > interfaces (specification). > If no specification is found, there is no failure at deploy time, but nothing > happen during execution. > that's a silent failure :) > iPOJO should throw an Exception and express the fact that the configuration > is invalid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[ https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649919#comment-13649919 ] Simone Tripodi commented on FELIX-3339: --- Sure, I'll investigate on what you suggested and propose a patch! > Consolidate Thread Dump Support > --- > > Key: FELIX-3339 > URL: https://issues.apache.org/jira/browse/FELIX-3339 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-3.1.8 >Reporter: Felix Meschberger > Attachments: FELIX-3339_initial-proto.patch, > FELIX-3339_threaddump-include-jdk18.patch > > > The Felix Web Console currently has an embedded plugin only using traditional > Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs. > These two should be consolidated and extended such that: > * Separate bundle (not embedded in the Web Console Bundle) > * one single plugin in Apache Felix > * Uses Java 6 JMX API if available > * Falls back to Java 5 JMX API if not Java 6 > * Falls back to regular Java API as a last step > * Provide Gogo Shell Commands > The advantage of using Java 6 API is to be able to inject lock information in > the thread dumps to be able to followup on deadlock and similar situations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[ https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649854#comment-13649854 ] Felix Meschberger commented on FELIX-3339: -- I am a bit weary about the version comparison since it bombs on us with Java 9. Would it be an option to use the Package.isCompatibleWith(String) on the "java.lang" package ? > Consolidate Thread Dump Support > --- > > Key: FELIX-3339 > URL: https://issues.apache.org/jira/browse/FELIX-3339 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-3.1.8 >Reporter: Felix Meschberger > Attachments: FELIX-3339_initial-proto.patch, > FELIX-3339_threaddump-include-jdk18.patch > > > The Felix Web Console currently has an embedded plugin only using traditional > Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs. > These two should be consolidated and extended such that: > * Separate bundle (not embedded in the Web Console Bundle) > * one single plugin in Apache Felix > * Uses Java 6 JMX API if available > * Falls back to Java 5 JMX API if not Java 6 > * Falls back to regular Java API as a last step > * Provide Gogo Shell Commands > The advantage of using Java 6 API is to be able to inject lock information in > the thread dumps to be able to followup on deadlock and similar situations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3339) Consolidate Thread Dump Support
[
https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated FELIX-3339:
--
Attachment: FELIX-3339_threaddump-include-jdk18.patch
The {{threaddump-include-jdk18.patch}} includes the JDK1.8 support to use Java6
APIs (and doesn't fall back to JDK1.4)
> Consolidate Thread Dump Support
> ---
>
> Key: FELIX-3339
> URL: https://issues.apache.org/jira/browse/FELIX-3339
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-3.1.8
>Reporter: Felix Meschberger
> Attachments: FELIX-3339_initial-proto.patch,
> FELIX-3339_threaddump-include-jdk18.patch
>
>
> The Felix Web Console currently has an embedded plugin only using traditional
> Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs.
> These two should be consolidated and extended such that:
> * Separate bundle (not embedded in the Web Console Bundle)
> * one single plugin in Apache Felix
> * Uses Java 6 JMX API if available
> * Falls back to Java 5 JMX API if not Java 6
> * Falls back to regular Java API as a last step
> * Provide Gogo Shell Commands
> The advantage of using Java 6 API is to be able to inject lock information in
> the thread dumps to be able to followup on deadlock and similar situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[ https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649843#comment-13649843 ] Simone Tripodi commented on FELIX-3339: --- I haven't noticed any difference between Java8 [ThreadMXBean|http://download.java.net/jdk8/docs/api/java/lang/management/ThreadMXBean.html] and [ThreadInfo|http://download.java.net/jdk8/docs/api/java/lang/management/ThreadInfo.html] compared to Java6 [ThreadMXBean|http://docs.oracle.com/javase/6/docs/api/java/lang/management/ThreadMXBean.html] and [ThreadInfo|http://docs.oracle.com/javase/6/docs/api/java/lang/management/ThreadInfo.html] definition, I am providing a new patch in order to support Java8 as well > Consolidate Thread Dump Support > --- > > Key: FELIX-3339 > URL: https://issues.apache.org/jira/browse/FELIX-3339 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-3.1.8 >Reporter: Felix Meschberger > Attachments: FELIX-3339_initial-proto.patch > > > The Felix Web Console currently has an embedded plugin only using traditional > Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs. > These two should be consolidated and extended such that: > * Separate bundle (not embedded in the Web Console Bundle) > * one single plugin in Apache Felix > * Uses Java 6 JMX API if available > * Falls back to Java 5 JMX API if not Java 6 > * Falls back to regular Java API as a last step > * Provide Gogo Shell Commands > The advantage of using Java 6 API is to be able to inject lock information in > the thread dumps to be able to followup on deadlock and similar situations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-3339) Consolidate Thread Dump Support
[
https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649830#comment-13649830
]
Simone Tripodi edited comment on FELIX-3339 at 5/6/13 4:22 PM:
---
Hi [~cziegeler]! :)
If I am not wrong, Java7 and Java6 JXM APIs are exactly the same, so I
configured the main printer to fallback to the {{Jdk16ThreadDumper}}, in case
the JVM version is _1.7_, see the {{CompositeThreadDumper}} class in the patch.
Apologize for not having had a look at Java8 APIs, this is something I can
provide a new patch to fill that lack.
was (Author: simone.tripodi):
Hi [~cziegeler]! :)
If I am not wrong, Java7 and Java6 JXM APIs are exactly the same, so I
configured the main printer to fallback to the {{Jdk16ThreadDumper}}, see the
{{CompositeThreadDumper}} class in the patch.
Apologize for not having had a look at Java8 APIs, this is something I can
provide a new patch to fill that lack.
> Consolidate Thread Dump Support
> ---
>
> Key: FELIX-3339
> URL: https://issues.apache.org/jira/browse/FELIX-3339
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-3.1.8
>Reporter: Felix Meschberger
> Attachments: FELIX-3339_initial-proto.patch
>
>
> The Felix Web Console currently has an embedded plugin only using traditional
> Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs.
> These two should be consolidated and extended such that:
> * Separate bundle (not embedded in the Web Console Bundle)
> * one single plugin in Apache Felix
> * Uses Java 6 JMX API if available
> * Falls back to Java 5 JMX API if not Java 6
> * Falls back to regular Java API as a last step
> * Provide Gogo Shell Commands
> The advantage of using Java 6 API is to be able to inject lock information in
> the thread dumps to be able to followup on deadlock and similar situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[
https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649830#comment-13649830
]
Simone Tripodi commented on FELIX-3339:
---
Hi [~cziegeler]! :)
If I am not wrong, Java7 and Java6 JXM APIs are exactly the same, so I
configured the main printer to fallback to the {{Jdk16ThreadDumper}}, see the
{{CompositeThreadDumper}} class in the patch.
Apologize for not having had a look at Java8 APIs, this is something I can
provide a new patch to fill that lack.
> Consolidate Thread Dump Support
> ---
>
> Key: FELIX-3339
> URL: https://issues.apache.org/jira/browse/FELIX-3339
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
>Affects Versions: webconsole-3.1.8
>Reporter: Felix Meschberger
> Attachments: FELIX-3339_initial-proto.patch
>
>
> The Felix Web Console currently has an embedded plugin only using traditional
> Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs.
> These two should be consolidated and extended such that:
> * Separate bundle (not embedded in the Web Console Bundle)
> * one single plugin in Apache Felix
> * Uses Java 6 JMX API if available
> * Falls back to Java 5 JMX API if not Java 6
> * Falls back to regular Java API as a last step
> * Provide Gogo Shell Commands
> The advantage of using Java 6 API is to be able to inject lock information in
> the thread dumps to be able to followup on deadlock and similar situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4041) Properties starting with . should not be propagated
[ https://issues.apache.org/jira/browse/FELIX-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clement Escoffier resolved FELIX-4041. -- Resolution: Fixed Fixed in trunk > Properties starting with . should not be propagated > --- > > Key: FELIX-4041 > URL: https://issues.apache.org/jira/browse/FELIX-4041 > Project: Felix > Issue Type: Bug > Components: iPOJO >Affects Versions: ipojo-runtime-1.8.6 >Reporter: Clement Escoffier >Assignee: Clement Escoffier > Fix For: ipojo-runtime-1.10 > > > To be conform with the configuration admin, properties starting with . should > not be propagated to the service registrations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4053) Avoid @StaticServiceProperty to be used on classes
[
https://issues.apache.org/jira/browse/FELIX-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clement Escoffier resolved FELIX-4053.
--
Resolution: Fixed
Assignee: Clement Escoffier
Fixed in trunk.
The @StaticServiceProperty annotation is now set to be only using in complex
type.
> Avoid @StaticServiceProperty to be used on classes
> --
>
> Key: FELIX-4053
> URL: https://issues.apache.org/jira/browse/FELIX-4053
> Project: Felix
> Issue Type: Bug
> Components: iPOJO
>Affects Versions: ipojo-runtime-1.8.6
>Reporter: Clement Escoffier
>Assignee: Clement Escoffier
> Fix For: ipojo-runtime-1.10
>
>
> The @StaticServiceProperty annotation is made to be used like this:
> @Component
> @Provides(properties = {
> @StaticServiceProperty(name="property", value="value", type =
> "java.lang.String")
> })
> @Instantiate(name="instanceWithProperties")
> public class MyComponent {
> //...
> }
> It cannot be used on classes directory (as it's attached to a provided
> service). To avoid this mistake, we should set the `target` of the annotation
> to {}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-4053) Avoid @StaticServiceProperty to be used on classes
Clement Escoffier created FELIX-4053:
Summary: Avoid @StaticServiceProperty to be used on classes
Key: FELIX-4053
URL: https://issues.apache.org/jira/browse/FELIX-4053
Project: Felix
Issue Type: Bug
Components: iPOJO
Affects Versions: ipojo-runtime-1.8.6
Reporter: Clement Escoffier
Fix For: ipojo-runtime-1.10
The @StaticServiceProperty annotation is made to be used like this:
@Component
@Provides(properties = {
@StaticServiceProperty(name="property", value="value", type =
"java.lang.String")
})
@Instantiate(name="instanceWithProperties")
public class MyComponent {
//...
}
It cannot be used on classes directory (as it's attached to a provided
service). To avoid this mistake, we should set the `target` of the annotation
to {}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3339) Consolidate Thread Dump Support
[ https://issues.apache.org/jira/browse/FELIX-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649730#comment-13649730 ] Carsten Ziegeler commented on FELIX-3339: - Thanks for your patch Simone; it basically looks good to me, with one minor request: could you make sure that if a java version higher than 7 is used, it doesn't revert back to the 1.4 implementation but uses the same as for java 7? This way, the plugin should look the same with java 8, regardless whether we enhance it for java 8 or not > Consolidate Thread Dump Support > --- > > Key: FELIX-3339 > URL: https://issues.apache.org/jira/browse/FELIX-3339 > Project: Felix > Issue Type: Improvement > Components: Web Console >Affects Versions: webconsole-3.1.8 >Reporter: Felix Meschberger > Attachments: FELIX-3339_initial-proto.patch > > > The Felix Web Console currently has an embedded plugin only using traditional > Java API. Sling has a Web Console plugin leveraging the Java 5 JMX APIs. > These two should be consolidated and extended such that: > * Separate bundle (not embedded in the Web Console Bundle) > * one single plugin in Apache Felix > * Uses Java 6 JMX API if available > * Falls back to Java 5 JMX API if not Java 6 > * Falls back to regular Java API as a last step > * Provide Gogo Shell Commands > The advantage of using Java 6 API is to be able to inject lock information in > the thread dumps to be able to followup on deadlock and similar situations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-4051) Properties when removed is not reflected in .cfg file.
[ https://issues.apache.org/jira/browse/FELIX-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649693#comment-13649693 ] Jeffrie Joshua L G edited comment on FELIX-4051 at 5/6/13 12:48 PM: When i remove the first property browserProperties.fileName2 = C:/Testing/conf/configuration.properties and save , The properties are getting updated just fine in application level, But its not getting updated in the actual .cfg file. Updations and adding new property are all working fine i.e the .cfg is getting updated. was (Author: jeffriejoshua): When i remove the first property browserProperties.fileName2 = C:/Testing/conf/configuration.properties and save. the properties are getting updated just fine in application level, But its not getting updated in the actual .cfg file. Updations and adding new property are all working fine i.e the .cfg is getting updated. > Properties when removed is not reflected in .cfg file. > -- > > Key: FELIX-4051 > URL: https://issues.apache.org/jira/browse/FELIX-4051 > Project: Felix > Issue Type: Bug >Affects Versions: fileinstall-3.2.6 >Reporter: Jeffrie Joshua L G >Priority: Minor > Attachments: screenshot-1.jpg > > > When i update/delete any property in .cfg, its getting reflecting in web > console. When i add or update in web console its also getting reflected in > the corresponding .cfg file. > But, removing any property from the configuration file using console is not > getting updated in the corresponding .cfg file. > ref screen shot -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-4052) Instance declaration not created correctly when using @Instantiate if the @Component specifies a name
[
https://issues.apache.org/jira/browse/FELIX-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clement Escoffier resolved FELIX-4052.
--
Resolution: Fixed
Fixed in trunk
> Instance declaration not created correctly when using @Instantiate if the
> @Component specifies a name
> -
>
> Key: FELIX-4052
> URL: https://issues.apache.org/jira/browse/FELIX-4052
> Project: Felix
> Issue Type: Bug
> Components: iPOJO
>Affects Versions: ipojo-manipulator-1.8.6
>Reporter: Clement Escoffier
>Assignee: Clement Escoffier
> Fix For: ipojo-manipulator-1.8.8
>
>
> The instance declaration is incorrect when a component is using the "name"
> attribute and an instance is declared using the @Instantiate annotation such
> as in:
> @Component(name="my-custom-name)
> @Instantiate
> public class MyComponent {
> //...
> }
> The instance is declared by is looking for a factory with the component's
> classname (the default) as factory name, and so the declaration is never
> bound. In this case the instance must look for the factory with the specified
> name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-4051) Properties when removed is not reflected in .cfg file.
[ https://issues.apache.org/jira/browse/FELIX-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeffrie Joshua L G updated FELIX-4051: -- Issue Type: Bug (was: Improvement) > Properties when removed is not reflected in .cfg file. > -- > > Key: FELIX-4051 > URL: https://issues.apache.org/jira/browse/FELIX-4051 > Project: Felix > Issue Type: Bug >Affects Versions: fileinstall-3.2.6 >Reporter: Jeffrie Joshua L G >Priority: Minor > Attachments: screenshot-1.jpg > > > When i update/delete any property in .cfg, its getting reflecting in web > console. When i add or update in web console its also getting reflected in > the corresponding .cfg file. > But, removing any property from the configuration file using console is not > getting updated in the corresponding .cfg file. > ref screen shot -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-4051) Properties when removed is not reflected in .cfg file.
[ https://issues.apache.org/jira/browse/FELIX-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeffrie Joshua L G updated FELIX-4051: -- Attachment: screenshot-1.jpg When i remove the first property browserProperties.fileName2 = C:/Testing/conf/configuration.properties and save. the properties are getting updated just fine in application level, But its not getting updated in the actual .cfg file. Updations and adding new property are all working fine i.e the .cfg is getting updated. > Properties when removed is not reflected in .cfg file. > -- > > Key: FELIX-4051 > URL: https://issues.apache.org/jira/browse/FELIX-4051 > Project: Felix > Issue Type: Improvement >Affects Versions: fileinstall-3.2.6 >Reporter: Jeffrie Joshua L G >Priority: Minor > Attachments: screenshot-1.jpg > > > When i update/delete any property in .cfg, its getting reflecting in web > console. When i add or update in web console its also getting reflected in > the corresponding .cfg file. > But, removing any property from the configuration file using console is not > getting updated in the corresponding .cfg file. > ref screen shot -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-4052) Instance declaration not created correctly when using @Instantiate if the @Component specifies a name
Clement Escoffier created FELIX-4052:
Summary: Instance declaration not created correctly when using
@Instantiate if the @Component specifies a name
Key: FELIX-4052
URL: https://issues.apache.org/jira/browse/FELIX-4052
Project: Felix
Issue Type: Bug
Components: iPOJO
Affects Versions: ipojo-manipulator-1.8.6
Reporter: Clement Escoffier
Assignee: Clement Escoffier
Fix For: ipojo-manipulator-1.8.8
The instance declaration is incorrect when a component is using the "name"
attribute and an instance is declared using the @Instantiate annotation such as
in:
@Component(name="my-custom-name)
@Instantiate
public class MyComponent {
//...
}
The instance is declared by is looking for a factory with the component's
classname (the default) as factory name, and so the declaration is never bound.
In this case the instance must look for the factory with the specified name.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-4044) Web Console has a non-optional dependency on commons fileupload
[
https://issues.apache.org/jira/browse/FELIX-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649686#comment-13649686
]
Thomas Diesler commented on FELIX-4044:
---
Sure, if its fixed its fixed.
> Web Console has a non-optional dependency on commons fileupload
> ---
>
> Key: FELIX-4044
> URL: https://issues.apache.org/jira/browse/FELIX-4044
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-4.0.0
>Reporter: Thomas Diesler
>
> The documentation suggests that the full variant contains file upload
> {code}
> Caused by: org.osgi.service.resolver.ResolutionException: Unable to resolve
> HostBundleRevision[org.apache.felix.webconsole:4.0.0]: missing requirement
> XPackageRequirement[dirs={filter=(&(osgi.wiring.package=org.apache.commons.fileupload)(&(version>=1.2.0)(!(version>=2.0.0},[org.apache.felix.webconsole:4.0.0]]
> at
> org.apache.felix.resolver.Candidates.populateResource(Candidates.java:285)
> at org.apache.felix.resolver.Candidates.populate(Candidates.java:153)
> at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:100)
> at
> org.jboss.osgi.resolver.felix.FelixResolver.resolve(FelixResolver.java:54)
> at
> org.jboss.osgi.framework.internal.ResolverImpl.resolveInternal(ResolverImpl.java:177)
> at
> org.jboss.osgi.framework.internal.ResolverImpl.resolveAndApply(ResolverImpl.java:125)
> at
> org.jboss.osgi.framework.spi.BootstrapBundlesResolve.start(BootstrapBundlesResolve.java:107)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-4044) Web Console has a non-optional dependency on commons fileupload
[
https://issues.apache.org/jira/browse/FELIX-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649683#comment-13649683
]
Felix Meschberger commented on FELIX-4044:
--
Thanks for reporting.
Web Console 4.0.0 does not have a "full" profile. We realized that such a
profile would be helpful and recreated it as part of FELIX-3778.
The current trunk build already provides this fill profile, a release is
imminent.
Thus I would think this issue could be resolved as a duplicate. Do you agree ?
> Web Console has a non-optional dependency on commons fileupload
> ---
>
> Key: FELIX-4044
> URL: https://issues.apache.org/jira/browse/FELIX-4044
> Project: Felix
> Issue Type: Bug
> Components: Web Console
>Affects Versions: webconsole-4.0.0
>Reporter: Thomas Diesler
>
> The documentation suggests that the full variant contains file upload
> {code}
> Caused by: org.osgi.service.resolver.ResolutionException: Unable to resolve
> HostBundleRevision[org.apache.felix.webconsole:4.0.0]: missing requirement
> XPackageRequirement[dirs={filter=(&(osgi.wiring.package=org.apache.commons.fileupload)(&(version>=1.2.0)(!(version>=2.0.0},[org.apache.felix.webconsole:4.0.0]]
> at
> org.apache.felix.resolver.Candidates.populateResource(Candidates.java:285)
> at org.apache.felix.resolver.Candidates.populate(Candidates.java:153)
> at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:100)
> at
> org.jboss.osgi.resolver.felix.FelixResolver.resolve(FelixResolver.java:54)
> at
> org.jboss.osgi.framework.internal.ResolverImpl.resolveInternal(ResolverImpl.java:177)
> at
> org.jboss.osgi.framework.internal.ResolverImpl.resolveAndApply(ResolverImpl.java:125)
> at
> org.jboss.osgi.framework.spi.BootstrapBundlesResolve.start(BootstrapBundlesResolve.java:107)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-4051) Properties when removed is not reflected in .cfg file.
Jeffrie Joshua L G created FELIX-4051: - Summary: Properties when removed is not reflected in .cfg file. Key: FELIX-4051 URL: https://issues.apache.org/jira/browse/FELIX-4051 Project: Felix Issue Type: Improvement Affects Versions: fileinstall-3.2.6 Reporter: Jeffrie Joshua L G Priority: Minor When i update/delete any property in .cfg, its getting reflecting in web console. When i add or update in web console its also getting reflected in the corresponding .cfg file. But, removing any property from the configuration file using console is not getting updated in the corresponding .cfg file. ref screen shot -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FELIX-4050) Named dependencies are not injected if new dependencies are added at init phase.
Tuomas Kiviaho created FELIX-4050: - Summary: Named dependencies are not injected if new dependencies are added at init phase. Key: FELIX-4050 URL: https://issues.apache.org/jira/browse/FELIX-4050 Project: Felix Issue Type: Bug Components: Dependency Manager Affects Versions: dependencymanager-3.1.0 Reporter: Tuomas Kiviaho Spec says that "In the Init method, you are yet allowed to add some additional dependencies (but using the API)." I guess this means that I am allowed to call Component.add(). This leads to state transition for instance when new service dependency is added since it's started right away because component is already instantiated at this point. Component.dependencyAvailable() is called if service tracker finds a match right away and this in turn starts the state change calculation. Problem is that State uses components current instantiated status to determinate whether it is bound or not and not the status what the component was given to the activateService() method. State change calculation transitions to bound state prematurely because component is now instantiated. All required dependencies are available, because component is still unaware of forthcoming named dependencies at this point. I suggest that some sort of placeholder dependencies are used which the named dependencies will replace when they are created/configured. This also approach also preserves the order in which dependencies were actually added to the component. In the future there could be a new is/SetActive property to DependencyActivation which could be used to turn on/off an already added dependencies. Then named dependencies could be used as such instead of placeholders and user could even configure them directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
