[jira] [Commented] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken

2015-11-24 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024017#comment-15024017
 ] 

Stefan Seifert commented on FELIX-5116:
---

yes, correctly.

they are packed directly in the JAR file by maven-bundle-plugin, but do not 
appear in the target/classes directory as it was/is the case with felix SCR 
annotations and the maven SCR plugin (and even the SCR BND plugin).

this code (which was alread developed in FELIX-3324, but broken) unpacks those 
XML files again and stores them in the target/classes directory (if enabled via 
maven configuration parameters on goals bundle or manifest).

> maven-bundle-plugin: Dump SCR component definitions broken
> --
>
> Key: FELIX-5116
> URL: https://issues.apache.org/jira/browse/FELIX-5116
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.0.0
>Reporter: Stefan Seifert
> Fix For: maven-bundle-plugin-3.0.2
>
> Attachments: FELIX-5116.patch
>
>
> the feature to optionally dump SCR component definitions generated by bnd to 
> the output classes folder introduced in FELIX-3324 is broken ins 
> maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called 
> when generating the bundle or manifest.
> the attached patch fixes this and enabled the behavior for both manifest and 
> bundle goals.
> this feature is imporant for unit test support in IDEs, e.g. for 
> https://sling.apache.org/documentation/development/osgi-mock.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (FELIX-5116) maven-bundle-plugin: Dump SCR component definitions broken

2015-11-24 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024017#comment-15024017
 ] 

Stefan Seifert edited comment on FELIX-5116 at 11/24/15 8:48 AM:
-

yes, correctly.

they are packed directly in the JAR file by bnd, but do not appear in the 
target/classes directory as it was/is the case with felix SCR annotations and 
the maven SCR plugin (and even the SCR BND plugin).

this code (which was alread developed in FELIX-3324, but broken) unpacks those 
XML files again and stores them in the target/classes directory (if enabled via 
maven configuration parameters on goals bundle or manifest).


was (Author: sseif...@pro-vision.de):
yes, correctly.

they are packed directly in the JAR file by maven-bundle-plugin, but do not 
appear in the target/classes directory as it was/is the case with felix SCR 
annotations and the maven SCR plugin (and even the SCR BND plugin).

this code (which was alread developed in FELIX-3324, but broken) unpacks those 
XML files again and stores them in the target/classes directory (if enabled via 
maven configuration parameters on goals bundle or manifest).

> maven-bundle-plugin: Dump SCR component definitions broken
> --
>
> Key: FELIX-5116
> URL: https://issues.apache.org/jira/browse/FELIX-5116
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.0.0
>Reporter: Stefan Seifert
> Fix For: maven-bundle-plugin-3.0.2
>
> Attachments: FELIX-5116.patch
>
>
> the feature to optionally dump SCR component definitions generated by bnd to 
> the output classes folder introduced in FELIX-3324 is broken ins 
> maven-bundle-plugin 3.0.0 and 3.0.1 - the associated code is never called 
> when generating the bundle or manifest.
> the attached patch fixes this and enabled the behavior for both manifest and 
> bundle goals.
> this feature is imporant for unit test support in IDEs, e.g. for 
> https://sling.apache.org/documentation/development/osgi-mock.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Update presentations list on our website

2015-11-24 Thread Carsten Ziegeler
Hi,

I just had a look at
http://felix.apache.org/documentation/tutorials-examples-and-presentations/presentations.html

which is pretty outdated, last entry is from January 2011. I'm pretty
sure some of us did great presentations on Felix related topics in the
meantime.

It would really be great if everyone could add their presentations
there, so we get more up to date things included.

I think we should also revert the sorting and list newest first - I can
take care of that.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Assigned] (FELIX-4912) Upgrade autoconf to Dependency Manager 4

2015-11-24 Thread J.W. Janssen (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

J.W. Janssen reassigned FELIX-4912:
---

Assignee: J.W. Janssen

> Upgrade autoconf to Dependency Manager 4
> 
>
> Key: FELIX-4912
> URL: https://issues.apache.org/jira/browse/FELIX-4912
> Project: Felix
>  Issue Type: Improvement
>  Components: Deployment Admin
>Affects Versions: deploymentadmin-0.9.6
>Reporter: Sander Mak
>Assignee: J.W. Janssen
> Attachments: FELIX-4912.patch
>
>
> I want to use org.apache.felix.deployment.rp.autoconf with DM4, but currently 
> it is built against DM3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-4912) Upgrade autoconf to Dependency Manager 4

2015-11-24 Thread J.W. Janssen (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

J.W. Janssen resolved FELIX-4912.
-
   Resolution: Fixed
Fix Version/s: deploymentadmin-0.9.8

Committed a slightly different fix which solves not only this issue, but also a 
couple of other problems, such as wrong parent POMs, etc.

> Upgrade autoconf to Dependency Manager 4
> 
>
> Key: FELIX-4912
> URL: https://issues.apache.org/jira/browse/FELIX-4912
> Project: Felix
>  Issue Type: Improvement
>  Components: Deployment Admin
>Affects Versions: deploymentadmin-0.9.6
>Reporter: Sander Mak
>Assignee: J.W. Janssen
> Fix For: deploymentadmin-0.9.8
>
> Attachments: FELIX-4912.patch
>
>
> I want to use org.apache.felix.deployment.rp.autoconf with DM4, but currently 
> it is built against DM3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-4516) Update command fails for non-bundle resource

2015-11-24 Thread J.W. Janssen (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

J.W. Janssen closed FELIX-4516.
---
Resolution: Not A Problem

Closing this issue as it is using the spec incorrectly. Please reopen if this 
problem this exists in the upcoming versions of DA.

> Update command fails for non-bundle resource
> 
>
> Key: FELIX-4516
> URL: https://issues.apache.org/jira/browse/FELIX-4516
> Project: Felix
>  Issue Type: Bug
>  Components: Deployment Admin
>Affects Versions: deploymentadmin-0.9.6
>Reporter: Norman Fomferra
> Attachments: com.acme.toolbox-1.0.4.jar
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I have a deployment package containg two bundles and an image resource. All 
> three resources are listed in the manifest 
> in the given order. When trying to install the package, the 
> UpdateCommand.doExecute() thows the following exception:   
> {noformat}
> org.osgi.service.deploymentadmin.DeploymentException: Resource 'icon.png' is 
> not described in the manifest.
>   at 
> org.apache.felix.deploymentadmin.spi.UpdateCommand.doExecute(UpdateCommand.java:69)
>   at org.apache.felix.deploymentadmin.spi.Command.execute(Command.java:55)
>   at 
> org.apache.felix.deploymentadmin.spi.DeploymentSessionImpl.call(DeploymentSessionImpl.java:77)
>   at 
> org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:214)
>   at org.teo.obr.DpCommand.installFromFile(DpCommand.java:153)
> {noformat}
> The exception is thrown in 
> org/apache/felix/deploymentadmin/spi/UpdateCommand.java(line 69) once the 
> current JAR
> entry is not the name of an expected bundle:
>  
> {code:java}
> 66  String name = entry.getPath();
> 67  BundleInfoImpl bundleInfo = (BundleInfoImpl) expectedBundles.remove(name);
> 68  if (bundleInfo == null) {
> 69  throw new DeploymentException(DeploymentException.CODE_OTHER_ERROR, 
> "Resource '" + name + "' is not described...");
> 70  }
> {code}
> The code should check first if the current JAR entry points to any other 
> resource in the manifest before assuming 
> it points to a bundle.  
> Issue FELIX-518 is closely created, if not the same.
> Thanks!
>Norman



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Apache Felix Dependency Manager Release Candidate R6

2015-11-24 Thread Pierre De Rop
+1 (binding)

cheers
/Pierre

On Sun, Nov 22, 2015 at 11:28 PM, Pierre De Rop 
wrote:

> Hello all,
>
> I would like to call for a vote on the Dependency Manager toplevel release
> R6.
>
> It is a maintenance release before the new DependencyManager-lambda
> scheduled for the next version.
> The following issues were solved:
>
> Release Notes - Felix - Version org.apache.felix.dependencymanager-r6
>
> ** Bug
> * [FELIX-4974] - DM filter indices not enabled if the
> dependencymanager bundle is started first
> * [FELIX-5045] - DM Optional callbacks may sometimes be invoked before
> start callback
> * [FELIX-5046] - Gradle wrapper is not included in DM source release
>
> ** Improvement
> * [FELIX-4921] - Ensure binary equality of the same bundle between
> successive DM releases
> * [FELIX-4922] - Simplify DM changelog management
> * [FELIX-5054] - Clean-up instance bound dependencies when component
> is destroyed
> * [FELIX-5055] - Upgrade DM to BndTools 3.0.0
> * [FELIX-5104] - Call a conf dependency callback Instance with an
> instantiated component
> * [FELIX-5113] - Remove useless wrong test in
> ConfigurationDependencyImpl
> * [FELIX-5114] - Schedule configuration update in Component executor
> synchronously
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> http://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh r6 /tmp/felix-staging
>
> This script, unlike the original Felix check_stage_release.sh, is specific
> to the new Dependency Manager release process (see FELIX-4818) and will
> download staging from https://dist.apache.org/repos/dist/dev/felix
> instead of http://repository.apache.org/content/repositories.
>
> To rebuild the DM binaries from the source, you can then refer to
> https://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/resources/src/README.src
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours (no less :-))
>
> Thank you;
>
> yours
> /Pierre
>


Re: [VOTE] Apache Felix Dependency Manager Release Candidate R6

2015-11-24 Thread David Bosschaert
+1

David

On 22 November 2015 at 16:28, Pierre De Rop  wrote:
> Hello all,
>
> I would like to call for a vote on the Dependency Manager toplevel release
> R6.
>
> It is a maintenance release before the new DependencyManager-lambda
> scheduled for the next version.
> The following issues were solved:
>
> Release Notes - Felix - Version org.apache.felix.dependencymanager-r6
>
> ** Bug
> * [FELIX-4974] - DM filter indices not enabled if the dependencymanager
> bundle is started first
> * [FELIX-5045] - DM Optional callbacks may sometimes be invoked before
> start callback
> * [FELIX-5046] - Gradle wrapper is not included in DM source release
>
> ** Improvement
> * [FELIX-4921] - Ensure binary equality of the same bundle between
> successive DM releases
> * [FELIX-4922] - Simplify DM changelog management
> * [FELIX-5054] - Clean-up instance bound dependencies when component is
> destroyed
> * [FELIX-5055] - Upgrade DM to BndTools 3.0.0
> * [FELIX-5104] - Call a conf dependency callback Instance with an
> instantiated component
> * [FELIX-5113] - Remove useless wrong test in
> ConfigurationDependencyImpl
> * [FELIX-5114] - Schedule configuration update in Component executor
> synchronously
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> http://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh r6 /tmp/felix-staging
>
> This script, unlike the original Felix check_stage_release.sh, is specific
> to the new Dependency Manager release process (see FELIX-4818) and will
> download staging from https://dist.apache.org/repos/dist/dev/felix instead
> of http://repository.apache.org/content/repositories.
>
> To rebuild the DM binaries from the source, you can then refer to
> https://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/resources/src/README.src
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours (no less :-))
>
> Thank you;
>
> yours
> /Pierre


Re: [VOTE] Apache Felix Dependency Manager Release Candidate R6

2015-11-24 Thread Jamie G.
+1 (non-binding)

On Tue, Nov 24, 2015 at 8:22 AM, David Bosschaert
 wrote:
> +1
>
> David
>
> On 22 November 2015 at 16:28, Pierre De Rop  wrote:
>> Hello all,
>>
>> I would like to call for a vote on the Dependency Manager toplevel release
>> R6.
>>
>> It is a maintenance release before the new DependencyManager-lambda
>> scheduled for the next version.
>> The following issues were solved:
>>
>> Release Notes - Felix - Version org.apache.felix.dependencymanager-r6
>>
>> ** Bug
>> * [FELIX-4974] - DM filter indices not enabled if the dependencymanager
>> bundle is started first
>> * [FELIX-5045] - DM Optional callbacks may sometimes be invoked before
>> start callback
>> * [FELIX-5046] - Gradle wrapper is not included in DM source release
>>
>> ** Improvement
>> * [FELIX-4921] - Ensure binary equality of the same bundle between
>> successive DM releases
>> * [FELIX-4922] - Simplify DM changelog management
>> * [FELIX-5054] - Clean-up instance bound dependencies when component is
>> destroyed
>> * [FELIX-5055] - Upgrade DM to BndTools 3.0.0
>> * [FELIX-5104] - Call a conf dependency callback Instance with an
>> instantiated component
>> * [FELIX-5113] - Remove useless wrong test in
>> ConfigurationDependencyImpl
>> * [FELIX-5114] - Schedule configuration update in Component executor
>> synchronously
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>>
>> http://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh r6 /tmp/felix-staging
>>
>> This script, unlike the original Felix check_stage_release.sh, is specific
>> to the new Dependency Manager release process (see FELIX-4818) and will
>> download staging from https://dist.apache.org/repos/dist/dev/felix instead
>> of http://repository.apache.org/content/repositories.
>>
>> To rebuild the DM binaries from the source, you can then refer to
>> https://svn.apache.org/repos/asf/felix/trunk/dependencymanager/release/resources/src/README.src
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>>
>> This vote will be open for 72 hours (no less :-))
>>
>> Thank you;
>>
>> yours
>> /Pierre


[jira] [Commented] (FELIX-5112) ClassCastException when deploying an OBR Resource already present in the runtime

2015-11-24 Thread Stephen Kahmann (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024748#comment-15024748
 ] 

Stephen Kahmann commented on FELIX-5112:


I'm much more familiar with git so here's a PR: 
https://github.com/apache/felix/pull/42

> ClassCastException when deploying an OBR Resource already present in the 
> runtime
> 
>
> Key: FELIX-5112
> URL: https://issues.apache.org/jira/browse/FELIX-5112
> Project: Felix
>  Issue Type: Bug
>  Components: Bundle Repository (OBR)
>Affects Versions: bundlerepository-2.0.6
>Reporter: Stephen Kahmann
> Attachments: fix_local_resource_resolver.diff
>
>
> When using OBR to deploy a bundle that is already present in the runtime, 
> there is a ClassCastException:
> {code}
> java.lang.ClassCastException: 
> org.apache.felix.bundlerepository.impl.LazyLocalResourceImpl cannot be cast 
> to org.apache.felix.bundlerepository.impl.LocalResourceImpl
>   at 
> org.apache.felix.bundlerepository.impl.ResolverImpl.findUpdatableLocalResource(ResolverImpl.java:703)
>   at 
> org.apache.felix.bundlerepository.impl.ResolverImpl.deploy(ResolverImpl.java:569)
>   at 
> org.apache.karaf.obr.command.ObrCommandSupport.doDeploy(ObrCommandSupport.java:168)
>   at 
> org.apache.karaf.obr.command.StartCommand.doExecute(StartCommand.java:38)
>   at 
> org.apache.karaf.obr.command.ObrCommandSupport.execute(ObrCommandSupport.java:58)
>   at 
> org.apache.karaf.shell.impl.action.command.ActionCommand.execute(ActionCommand.java:83)
>   at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:67)
>   at 
> org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:87)
>   at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:480)
>   at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:406)
>   at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)
>   at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:182)
>   at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:119)
>   at 
> org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:94)
>   at 
> org.apache.karaf.shell.impl.console.HeadlessSessionImpl.execute(HeadlessSessionImpl.java:90)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] felix pull request: Resource exception fix

2015-11-24 Thread skahmann
GitHub user skahmann opened a pull request:

https://github.com/apache/felix/pull/42

Resource exception fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/skahmann/felix resource_exception_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/felix/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 1408ff3ccdbb6a95e65de70da25f930a7df53de0
Author: Stephen Kahmann 
Date:   2015-11-24T16:02:41Z

Fixed local resource exception and cleaned up some code

commit ae32f653ec2bbe78ee030a58bc01e6fac678889b
Author: Stephen Kahmann 
Date:   2015-11-24T16:11:21Z

Added LocalResource interface




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Closed] (FELIX-5115) Embed-Dependency ignores negative clauses

2015-11-24 Thread Stuart McCulloch (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stuart McCulloch closed FELIX-5115.
---
Resolution: Not A Problem

Looks related to FELIX-5070 because changing the Embed-Dependency instruction 
from:
{code}
Embed-Dependency:\
  !slf4j-api, *; scope=compile|runtime; type=!pom
{code}
to:
{code}
Embed-Dependency:\
  artifactId=!slf4j-api; scope=compile|runtime; type=!pom
{code}
also solves the issue.

> Embed-Dependency ignores negative clauses
> -
>
> Key: FELIX-5115
> URL: https://issues.apache.org/jira/browse/FELIX-5115
> Project: Felix
>  Issue Type: Bug
>  Components: Maven Bundle Plugin
>Affects Versions: maven-bundle-plugin-3.0.0, maven-bundle-plugin-3.0.1
>Reporter: Stuart McCulloch
>
> Checkout 
> https://github.com/ops4j/org.ops4j.pax.exam2/commit/50cffc617783223462735cd8f212cdab4b1fb867
>  and build the core/pax-exam-container-rbc project. Notice how the final 
> bundle incorrectly embeds the slf4j-api dependency even though the 
> instructions in 'osgi.bnd' use a negative clause to exclude that dependency.
> Edit the maven-bundle-plugin entry in 'core/pax-exam-container-rbc/pom.xml' 
> to use version 2.5.3 of the plugin and rebuild the project. Notice that the 
> final bundle no longer embeds slf4j-api. This is the expected behaviour which 
> appears to have regressed in 3.0.0, possibly via the fix for FELIX-3565



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)