Re: [VOTE] Release Apache Felix Http SSL Filter 1.0.8
+1, Regards, Clement > On 2 août 2016, at 10:43, Carsten Ziegeler wrote: > > +1 > > > > > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Re: [VOTE] Release Apache Felix Http SSL Filter 1.0.8
The vote passes with four binding +1 votes and one non binding +1 vote. Thanks everyone for voting! Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Closed] (FELIX-4923) SslFilterResponse doesn 't take in account ssl-forward.header property
[
https://issues.apache.org/jira/browse/FELIX-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler closed FELIX-4923.
---
> SslFilterResponse doesn 't take in account ssl-forward.header property
> --
>
> Key: FELIX-4923
> URL: https://issues.apache.org/jira/browse/FELIX-4923
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Reporter: Antonio Sanso
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.sslfilter-1.0.8
>
> Attachments: FELIX-4923-patch.txt
>
>
> {{SslFilterResponse}} doesn 't take in account {{ssl-forward}}.header
> property.
> Indeed the {{SslFilterResponse}} constructor hardcodes
> {{HDR_X_FORWARDED_PROTO}}.
> {code}
> ...
> request.getHeader(HDR_X_FORWARDED_PROTO);
> ...
> {code}
> the {{ssl-forward}} osgin configuration should be taken in account IMHO. The
> default is even different than {{HDR_X_FORWARDED_PROTO}} indeed is rather
> {{X-Forwarded-SSL}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (FELIX-5287) [SSLFilter] use Integer.parseInt instead of Integer.valueOf
[
https://issues.apache.org/jira/browse/FELIX-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler closed FELIX-5287.
---
> [SSLFilter] use Integer.parseInt instead of Integer.valueOf
> ---
>
> Key: FELIX-5287
> URL: https://issues.apache.org/jira/browse/FELIX-5287
> Project: Felix
> Issue Type: Improvement
> Components: HTTP Service
>Affects Versions: http.sslfilter-1.0.6
>Reporter: Jörg Hoh
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.sslfilter-1.0.8
>
>
> SslFilterRequest.getPort() uses Integer.valueOf to extract the port from the
> header, but just returns the primitive type. Thus it relies on the
> auto-unboxing, which takes a bit of time.
> But according to a yourkit profiling run this takes about 0.5% of the total
> request time for my application (which normally make me ignore such things,
> and I still find it very hard to believe), but because it's such an easy
> change we should do it.
> A quick-and-dirty test shows, that
> {noformat}
> for (int i=0;i<10;i++) {
> int result = Integer.valueOf(value);
> }
> {noformat}
> takes 300% of the execution time of
> {noformat}
> for (int i=0;i<10;i++) {
> int result = Integer.parseInt(value);
> }
> {noformat}
> (both running on Java 1.8.0_65)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
Derek Baum created FELIX-5319:
-
Summary: HttpServiceRuntime provides incorrect info for service
that is both Servlet and Resource
Key: FELIX-5319
URL: https://issues.apache.org/jira/browse/FELIX-5319
Project: Felix
Issue Type: Bug
Components: HTTP Service
Affects Versions: http.jetty-3.2.2
Reporter: Derek Baum
Priority: Minor
I have a servlet defined as follows:
Note: it defines _both_ servlet and resource properties.
@Component(property = {
HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
World",
HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
"=/hello/sayHello",
HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
"=/hello/static/*",
HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
})
public class HelloWorldServlet extends HttpServlet implements Servlet {
}
I am using the HttpServiceRuntime to discover servlet info, but this servlet
does not appear.
@Reference
HttpServiceRuntime httpRuntime;
RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
// servletDTOs.length == 0
}
The equivalent code for ResourceDTO _does_ find a ResourceDTO for this servlet,
but it contains servlet, rather than resource info:
resourceDTO.patterns = [/hello/sayHello]
resourceDTO.prefix = null
If I remove this resource property from the servlet, then the above code finds
the servlet, as expected:
HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned FELIX-5319:
---
Assignee: Carsten Ziegeler
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.jetty-3.2.2
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.jetty-3.2.4
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated FELIX-5319:
Fix Version/s: http.jetty-3.2.4
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.jetty-3.2.2
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.jetty-3.2.4
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409497#comment-15409497
]
Carsten Ziegeler commented on FELIX-5319:
-
Thanks for reporting, as a first step I've added a test case for that to our
integration tests...and the test fails of course atm, with the problem
mentioned in the description
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.jetty-3.2.2
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.jetty-3.2.4
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated FELIX-5319:
Fix Version/s: http.bridge-3.0.12
http.base-3.0.12
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.base-3.0.10, http.jetty-3.2.2, http.bridge-3.0.10
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.12, http.jetty-3.2.4, http.bridge-3.0.12
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved FELIX-5319.
-
Resolution: Fixed
I've committed a fix - test passes now.
The problem was that internally a Resource is treated like a Servlet using the
same ServletInfo implementation - which then leads to one object overwriting
the other. As the DTO handling makes the assumption that this can't happen, the
state gets totally corrupted.
We're now using a sub class of ServletInfo for resources and compare the class
names in the compareTo method
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.base-3.0.10, http.jetty-3.2.2, http.bridge-3.0.10
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.12, http.jetty-3.2.4, http.bridge-3.0.12
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated FELIX-5319:
Affects Version/s: http.base-3.0.10
http.bridge-3.0.10
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.base-3.0.10, http.jetty-3.2.2, http.bridge-3.0.10
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.jetty-3.2.4
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FELIX-5320) Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called
Andrea Leofreddi created FELIX-5320: --- Summary: Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called Key: FELIX-5320 URL: https://issues.apache.org/jira/browse/FELIX-5320 Project: Felix Issue Type: Bug Affects Versions: org.apache.felix.dependencymanager-r8 Reporter: Andrea Leofreddi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5320) Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called
[ https://issues.apache.org/jira/browse/FELIX-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Leofreddi updated FELIX-5320: Component/s: Dependency Manager > Dependency Manager: adapter service propagates adaptee properties *after* the > init (and start) callbacks are called > --- > > Key: FELIX-5320 > URL: https://issues.apache.org/jira/browse/FELIX-5320 > Project: Felix > Issue Type: Bug > Components: Dependency Manager >Affects Versions: org.apache.felix.dependencymanager-r8 >Reporter: Andrea Leofreddi > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5320) Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called
[ https://issues.apache.org/jira/browse/FELIX-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Leofreddi updated FELIX-5320: Description: In an adapter service, created using the createAdapterService method of DependencyManager class, one would expect to find the adaptee's properties being propagated to the adapter service itself, as stated in the documentation (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). Instead no propagation happens, and both init and start methods won't see any propagated properties. After investigating I've found that propagations indeed happens (via AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are called. was: In an adapter service, created using the createAdapterService method of DependencyManager class, one would expect to find the adaptee's properties being propagated to the adapter service itself, as stated in the documentation (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). Instead no propagation happens, and both the Init and Start methods won't see any propagated properties. After investigating I've found that propagations indeed happens (via AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are called. > Dependency Manager: adapter service propagates adaptee properties *after* the > init (and start) callbacks are called > --- > > Key: FELIX-5320 > URL: https://issues.apache.org/jira/browse/FELIX-5320 > Project: Felix > Issue Type: Bug > Components: Dependency Manager >Affects Versions: org.apache.felix.dependencymanager-r8 >Reporter: Andrea Leofreddi > > In an adapter service, created using the createAdapterService method of > DependencyManager class, one would expect to find the adaptee's properties > being propagated to the adapter service itself, as stated in the > documentation > (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). > Instead no propagation happens, and both init and start methods won't see any > propagated properties. > After investigating I've found that propagations indeed happens (via > AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are > called. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5320) Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called
[ https://issues.apache.org/jira/browse/FELIX-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Leofreddi updated FELIX-5320: Description: In an adapter service, created using the createAdapterService method of DependencyManager class, one would expect to find the adaptee's properties being propagated to the service itself, as stated in the documentation (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). Instead no propagation happens, and both the Init and Start methods won't see any propagated properties. After investigating I've found that propagations indeed happens (via AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are called. > Dependency Manager: adapter service propagates adaptee properties *after* the > init (and start) callbacks are called > --- > > Key: FELIX-5320 > URL: https://issues.apache.org/jira/browse/FELIX-5320 > Project: Felix > Issue Type: Bug > Components: Dependency Manager >Affects Versions: org.apache.felix.dependencymanager-r8 >Reporter: Andrea Leofreddi > > In an adapter service, created using the createAdapterService method of > DependencyManager class, one would expect to find the adaptee's properties > being propagated to the service itself, as stated in the documentation > (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). > Instead no propagation happens, and both the Init and Start methods won't see > any propagated properties. > After investigating I've found that propagations indeed happens (via > AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are > called. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (FELIX-5320) Dependency Manager: adapter service propagates adaptee properties *after* the init (and start) callbacks are called
[ https://issues.apache.org/jira/browse/FELIX-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Leofreddi updated FELIX-5320: Description: In an adapter service, created using the createAdapterService method of DependencyManager class, one would expect to find the adaptee's properties being propagated to the adapter service itself, as stated in the documentation (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). Instead no propagation happens, and both the Init and Start methods won't see any propagated properties. After investigating I've found that propagations indeed happens (via AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are called. was: In an adapter service, created using the createAdapterService method of DependencyManager class, one would expect to find the adaptee's properties being propagated to the service itself, as stated in the documentation (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). Instead no propagation happens, and both the Init and Start methods won't see any propagated properties. After investigating I've found that propagations indeed happens (via AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are called. > Dependency Manager: adapter service propagates adaptee properties *after* the > init (and start) callbacks are called > --- > > Key: FELIX-5320 > URL: https://issues.apache.org/jira/browse/FELIX-5320 > Project: Felix > Issue Type: Bug > Components: Dependency Manager >Affects Versions: org.apache.felix.dependencymanager-r8 >Reporter: Andrea Leofreddi > > In an adapter service, created using the createAdapterService method of > DependencyManager class, one would expect to find the adaptee's properties > being propagated to the adapter service itself, as stated in the > documentation > (http://felix.apache.org/documentation/subprojects/apache-felix-dependency-manager/reference/component-adapter.html). > Instead no propagation happens, and both the Init and Start methods won't see > any propagated properties. > After investigating I've found that propagations indeed happens (via > AdapterServiceImpl's propagateAdapteeProperties) only after the callbacks are > called. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FELIX-5319) HttpServiceRuntime provides incorrect info for service that is both Servlet and Resource
[
https://issues.apache.org/jira/browse/FELIX-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409596#comment-15409596
]
Derek Baum commented on FELIX-5319:
---
Hi Carsten,
Thanks for fixing this so quickly.
I can confirm that a local build of 3.2.3-SNAPSHOT works fine for me.
--
Derek
> HttpServiceRuntime provides incorrect info for service that is both Servlet
> and Resource
>
>
> Key: FELIX-5319
> URL: https://issues.apache.org/jira/browse/FELIX-5319
> Project: Felix
> Issue Type: Bug
> Components: HTTP Service
>Affects Versions: http.base-3.0.10, http.jetty-3.2.2, http.bridge-3.0.10
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.12, http.jetty-3.2.4, http.bridge-3.0.12
>
>
> I have a servlet defined as follows:
> Note: it defines _both_ servlet and resource properties.
> @Component(property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_NAME + "=Hello
> World",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN +
> "=/hello/sayHello",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN +
> "=/hello/static/*",
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PREFIX + "=/static"
> })
> public class HelloWorldServlet extends HttpServlet implements Servlet {
> }
> I am using the HttpServiceRuntime to discover servlet info, but this servlet
> does not appear.
> @Reference
> HttpServiceRuntime httpRuntime;
> RuntimeDTO runtimeDTO = httpRuntime.getRuntimeDTO();
> for (ServletContextDTO servletContextDTO : runtimeDTO.servletContextDTOs) {
> ServletDTO[] servletDTOs = servletContextDTO.servletDTOs;
> // servletDTOs.length == 0
> }
> The equivalent code for ResourceDTO _does_ find a ResourceDTO for this
> servlet, but it contains servlet, rather than resource info:
> resourceDTO.patterns = [/hello/sayHello]
> resourceDTO.prefix = null
> If I remove this resource property from the servlet, then the above code
> finds the servlet, as expected:
> HttpWhiteboardConstants.HTTP_WHITEBOARD_RESOURCE_PATTERN + "=/hello/static/*"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
