[jira] [Created] (FELIX-5353) ConfigurationAdmin does not log or diagnose invalid contents of files

2016-09-16 Thread Benson Margulies (JIRA)
Benson Margulies created FELIX-5353:
---

 Summary: ConfigurationAdmin does not log or diagnose invalid 
contents of files
 Key: FELIX-5353
 URL: https://issues.apache.org/jira/browse/FELIX-5353
 Project: Felix
  Issue Type: Wish
  Components: Configuration Admin
Reporter: Benson Margulies


If you have a .cfg file with a line like:

{noformat}
prop=${something}/something
{noformat}

The contents of the file disappear, without an exception, a log message, or a 
trace. It should at least, I think be logged.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (FELIX-5352) Bundle-DocURL in the manifest of most bundles is wrong

2016-09-16 Thread Renato Athaydes (JIRA)
Renato Athaydes created FELIX-5352:
--

 Summary: Bundle-DocURL in the manifest of most bundles is wrong
 Key: FELIX-5352
 URL: https://issues.apache.org/jira/browse/FELIX-5352
 Project: Felix
  Issue Type: Improvement
Reporter: Renato Athaydes
Priority: Minor


The Bundle-DocURL entry of most bundles in the Felix Project seem to be wrong.

Examples:

Apache Felix Bundle Repository (2.0.8):

```
Bundle-DocURL = 
http://felix.apache.org/site/apache-felix-osgi-bundle-repository.html
```

Apache Felix Declarative Services (2.0.2):

```
Bundle-DocURL = 
http://felix.apache.org/site/apache-felix-service-component-runtime.html
```

Apache Felix Shell Service (1.4.3):

```
Bundle-DocURL = http://www.apache.org/
```

The two first ones simply do not exist.
The last one is just not very useful.

Here are the correct URLs, if that helps:

Apache Felix Bundle Repository:
http://felix.apache.org/documentation/subprojects/apache-felix-osgi-bundle-repository.html

Apache Felix Declarative Services:
http://felix.apache.org/documentation/subprojects/apache-felix-service-component-runtime.html

Apache Felix Shell Service:
http://felix.apache.org/documentation/subprojects/apache-felix-shell.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5328) NoClassDefFound not wrapped in the ClassScanner

2016-09-16 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496053#comment-15496053
 ] 

Konrad Windszus commented on FELIX-5328:


Thanks [~cziegeler]. Your fix looks better and should cover all exceptions.

> NoClassDefFound not wrapped in the ClassScanner
> ---
>
> Key: FELIX-5328
> URL: https://issues.apache.org/jira/browse/FELIX-5328
> Project: Felix
>  Issue Type: Bug
>  Components: SCR Tooling
>Affects Versions: scr generator 1.14.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin 1.23.0, scr ant task 1.16.0, scr 
> generator 1.15.0, scr bnd plugin 1.6.0
>
>
> Unfortunately only {{ClassNotFoundException}} is wrapped in 
> https://github.com/apache/felix/blob/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java#L148.
>  Every other exception is not wrapped at all, making it very hard to figure 
> out where an issue happened.
> An example stack trace of an error might look likes this
> {code}
> [ERROR] Bundle  analyzing:java.lang.NoClassDefFoundError: 
> javax/servlet/jsp/el/VariableResolver
>   at java.lang.ClassLoader.defineClass1(Native Method)
>   at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
>   at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>   at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>   at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at 
> org.apache.felix.scrplugin.helper.ClassScanner.scanSources(ClassScanner.java:144)
>   at 
> org.apache.felix.scrplugin.SCRDescriptorGenerator.execute(SCRDescriptorGenerator.java:146)
>   at 
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin.analyzeJar(SCRDescriptorBndPlugin.java:178)
>   at aQute.bnd.osgi.Analyzer.doPlugins(Analyzer.java:656)
>   at aQute.bnd.osgi.Analyzer.analyze(Analyzer.java:209)
>   at aQute.bnd.osgi.Builder.analyze(Builder.java:385)
>   at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:687)
>   at aQute.bnd.osgi.Builder.build(Builder.java:105)
>   at 
> org.apache.felix.bundleplugin.BundlePlugin.buildOSGiBundle(BundlePlugin.java:972)
>   at 
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:470)
>   at 
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:387)
>   at 
> org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:378)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher

[jira] [Updated] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Derek Baum (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Derek Baum updated FELIX-5349:
--
Attachment: factory2.patch

patch to revision 1761012 so that stopping jetty bundle also stops service 
instances created by factory. Also added synchronisation to factory methods.

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6, http.bridge-3.0.14
>
> Attachments: factory.patch, factory2.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (FELIX-5341) Exception thrown when field in Map missing from DTO

2016-09-16 Thread David Bosschaert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved FELIX-5341.
-
Resolution: Fixed

Fixed and added test case in: 
https://svn.apache.org/viewvc?view=revision&revision=1761008

> Exception thrown when field in Map missing from DTO
> ---
>
> Key: FELIX-5341
> URL: https://issues.apache.org/jira/browse/FELIX-5341
> Project: Felix
>  Issue Type: Bug
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Bosschaert
>
> I believe that this is not the correct behaviour, so please correct me if I 
> am mistaken.
> If a Map (or Map representation of some object) contains a field, when 
> converting to a DTO that does *not* contain that field, instead of just 
> ignoring the field, an Exception is thrown, and the conversion fails.
> The related code is 
> [here|https://github.com/dleangen/felix/blob/trunk/converter/converter/src/main/java/org/apache/felix/converter/impl/ConvertingImpl.java#L242].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work started] (FELIX-5341) Exception thrown when field in Map missing from DTO

2016-09-16 Thread David Bosschaert (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on FELIX-5341 started by David Bosschaert.
---
> Exception thrown when field in Map missing from DTO
> ---
>
> Key: FELIX-5341
> URL: https://issues.apache.org/jira/browse/FELIX-5341
> Project: Felix
>  Issue Type: Bug
>  Components: Converter
>Reporter: David Leangen
>Assignee: David Bosschaert
>
> I believe that this is not the correct behaviour, so please correct me if I 
> am mistaken.
> If a Map (or Map representation of some object) contains a field, when 
> converting to a DTO that does *not* contain that field, instead of just 
> ignoring the field, an Exception is thrown, and the conversion fails.
> The related code is 
> [here|https://github.com/dleangen/felix/blob/trunk/converter/converter/src/main/java/org/apache/felix/converter/impl/ConvertingImpl.java#L242].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (FELIX-5344) HTTP_WHITEBOARD_TARGET doesn't work reliably

2016-09-16 Thread Derek Baum (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Derek Baum closed FELIX-5344.
-

I have tested this and verify that it resolves the issue. Thanks. Derek

> HTTP_WHITEBOARD_TARGET doesn't work reliably
> 
>
> Key: FELIX-5344
> URL: https://issues.apache.org/jira/browse/FELIX-5344
> Project: Felix
>  Issue Type: Bug
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
> Fix For: http.base-3.0.14, http.jetty-3.2.6, http.bridge-3.0.14
>
>
> I am trying to use HTTP_WHITEBOARD_TARGET to match a specific http instance:
> (I'm actually experimenting with multiple http instances, but the problem 
> occurs with a single instance).
> @Component(service = Servlet.class,
>   property = {
> HttpWhiteboardConstants.HTTP_WHITEBOARD_TARGET + 
> "=(org.osgi.service.http.port=)"
> })
> I am configuring http.jetty using config admin (via fileinstall)
> I have disabled automatic jetty startup using:
> org.apache.felix.http.enable=false
> Now I start jetty by dropping the file org.apache.felix.http.cfg into the 
> fileinstall load directory:
> org.apache.felix.http.enable=true
> org.osgi.service.http.port=
> and my servlet is not always registered.
> This appears to be because WhiteboardManager.addWhiteboardService() is being 
> called before the http service properties have been set.
> Here's the output of some debug I added to isMatchingService():
> XXXtarget =(org.osgi.service.http.port=) match=false
> XXXprop objectClass=[Ljava.lang.String;@292aebaf
> XXXprop osgi.http.service.id=[60]
> XXXprop service.bundleid=22
> XXXprop service.id=61
> XXXprop service.scope=singleton
> It doesn't contain any endpoint properties.
> To prove this is a timing issue, I stopped and started my web bundle, which 
> then registered correctly. The corresponding debug is:
> XXXtarget =(org.osgi.service.http.port=) match=true
> XXXprop objectClass=[Ljava.lang.String;@292aebaf
> XXXprop org.apache.felix.http.enable=true
> XXXprop org.apache.felix.https.enable=false
> XXXprop org.osgi.service.http.port=
> XXXprop org.osgi.service.http.port.secure=8443
> XXXprop osgi.http.endpoint=[Ljava.lang.String;@1d1447fa
> XXXprop osgi.http.service.id=[60]
> XXXprop service.bundleid=22
> XXXprop service.id=61
> XXXprop service.scope=singleton



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495645#comment-15495645
 ] 

Carsten Ziegeler commented on FELIX-5349:
-

I've changed the http.base code a little bit to make the code slightly cleaner 
and the JettyServiceStarter does not need to extend the activator anymore

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6, http.bridge-3.0.14
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated FELIX-5349:

Fix Version/s: http.bridge-3.0.14

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6, http.bridge-3.0.14
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Derek Baum (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495640#comment-15495640
 ] 

Derek Baum commented on FELIX-5349:
---

I was just trying to keep the existing Activator behaviour, but yes, it should 
shutdown all instances when the bundle is stopped. 

And I think you're right about needing synchronisation.

BTW, when testing this I was using configadmin 1.8.8, which didn't contain the 
fix for FELIX-5088 - CaseSensitiveDictionary should implement equals(). This 
caused JettyConfig.update(Dictionary props) to think that the props had not 
changed. It works fine with configadmin-1.8.10.

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Derek Baum (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495618#comment-15495618
 ] 

Derek Baum commented on FELIX-5349:
---

Yes, I'm using the same PID. This also means that the existing Metadata is 
available in webconsole when creating a new instance.

Enforcing the name property would be useful, otherwise it's difficult to target 
a specific whiteboard instance without using the port in the filter.


If you only want to use the ManagedServiceFactory, then setting 
org.apache.felix.http.enable=false, stops the ManagedService instance from 
starting; although it can be re-enabled from webconsole/config admin.

I did consider adding a property that would eenable either the existing 
ManagedService ot the new ManagedServiceFactory, but I don't think that's 
necessary.


The ManagedServiceFactory could also check for conflicting configurations, for 
example a port that conflicts with an existing instance.

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495596#comment-15495596
 ] 

Carsten Ziegeler commented on FELIX-5349:
-

I've applied your patch. I think we can improve this a little bit more, e.g. 
cleaning up/shutting down all jetty services if the jetty bundle is stopped. 
I'm not 100% sure but I think we might also need synchronization in the 
JettyManagedServiceFactory as updated might be called in parallel

> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work started] (FELIX-5349) add ManagedServiceFactory to HTTP service

2016-09-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/FELIX-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on FELIX-5349 started by Carsten Ziegeler.
---
> add ManagedServiceFactory to HTTP service
> -
>
> Key: FELIX-5349
> URL: https://issues.apache.org/jira/browse/FELIX-5349
> Project: Felix
>  Issue Type: New Feature
>  Components: HTTP Service
>Affects Versions: http.base-3.0.12, http.jetty-3.2.4
>Reporter: Derek Baum
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: http.base-3.0.14, http.jetty-3.2.6
>
> Attachments: factory.patch
>
>
> I need to run multiple HTTP services, with different configurations.
> I was surprised to find that felix.http.jetty does not provide a 
> ManagedServiceFactory and so were others as indicated in this stack overflow 
> conversation: 
> http://stackoverflow.com/questions/20074211/osgi-http-bundle-bind-to-two-ports
> I have experimented with creating a ManagedServiceFactory for the HTTP 
> service myself. It is difficult to do externally to the http.jetty bundle, as 
> it requires access to internal packages.
> I have therefore created a small patch to revision 1760954 which adds a 
> ManagedServiceFactory, without changing any of the existing functionality of 
> the ManagedService. This allows multiple http.jetty instances to be 
> configured using WebConsole, fileinstall or other config admin clients.
> I have also added a new configuration property: org.apache.felix.http.name,
> which is added as a service property to the HTTP runtime instance. This makes 
> it easier to target a specific HTTP whiteboard service than filtering on the 
> port:
> HTTP_WHITEBOARD_TARGET + "=(org.apache.felix.http.name=web1)"
> I would be grateful if you would consider adding this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)